linux.git/drivers/net/bonding, branch v4.0

bonding: Bonding Overriding Configuration logic restored.

2015-03-31T17:49:45+00:00

Before commit 3900f29021f0bc7fe9815aa32f1a993b7dfdd402 ("bonding: slight
optimizztion for bond_slave_override()") the override logic was to send packets
with non-zero queue_id through the slave with corresponding queue_id, under two
conditions only - if the slave can transmit and it's up.

The above mentioned commit changed this logic by introducing an additional
condition - whether the bond is active (indirectly, using the slave_can_tx and
later - bond_is_active_slave), that prevents the user from implementing more
complex policies according to the Documentation/networking/bonding.txt.

Signed-off-by: Anton Nayshtut 
Signed-off-by: Alexey Bogoslavsky 
Signed-off-by: Andy Gospodarek 
Signed-off-by: David S. Miller

net/bonding: Fix potential bad memory access during bonding events

2015-02-09T22:03:53+00:00

When queuing work to send the NETDEV_BONDING_INFO netdev event, it's
possible that when the work is executed, the pointer to the slave
becomes invalid. This can happen if between queuing the event and the
execution of the work, the net-device was un-ensvaled and re-enslaved.

Fix that by queuing a work with the data of the slave instead of the
slave structure.

Fixes: 69e6113343cf ('net/bonding: Notify state change on slaves')
Reported-by: Nikolay Aleksandrov 
Signed-off-by: Moni Shoua 
Signed-off-by: Or Gerlitz 
Signed-off-by: David S. Miller

net/bonding: Notify state change on slaves

2015-02-05T00:14:24+00:00

Use notifier chain to dispatch an event upon a change in slave state.
Event is dispatched with slave specific info.

Signed-off-by: Moni Shoua 
Signed-off-by: Or Gerlitz 
Signed-off-by: David S. Miller

net/bonding: Move slave state changes to a helper function

2015-02-05T00:14:24+00:00

Move slave state changes to a helper function, this is a pre-step for adding
functionality of dispatching an event when this helper is called.

This commit doesn't add new functionality.

Signed-off-by: Moni Shoua 
Signed-off-by: Or Gerlitz 
Signed-off-by: David S. Miller

bonding: handle NETIF_F_HW_SWITCH_OFFLOAD flag and add ndo_bridge_setlink/dellink handlers

2015-02-02T07:16:34+00:00

We want bond to pick up the offload flag if any of its slaves have it.

NETIF_F_HW_SWITCH_OFFLOAD flag is added to the mask, so that
netdev_increment_features does not ignore it.

This also adds ndo_bridge_setlink and ndo_bridge_dellink handlers.
These currently point to the default handlers provided by the
switchdev api.

Signed-off-by: Roopa Prabhu 
Signed-off-by: David S. Miller

bonding: cleanup and remove dead code

2015-01-28T01:09:04+00:00

fix sparse warning about non-static function

drivers/net/bonding/bond_main.c:3737:5: warning: symbol
'bond_3ad_xor_xmit' was not declared. Should it be static?

Reviewed-by: Nikolay Aleksandrov 
Signed-off-by: Jonathan Toppins 
Signed-off-by: Jay Vosburgh 
Signed-off-by: David S. Miller

bonding: fix LACP PDU not sent on slave port sometimes

2015-01-28T01:09:04+00:00

When a slave is added to a bond and it is not in full duplex mode,
AD_PORT_LACP_ENABLED flag is cleared, due to this LACP PDU is not sent
on slave. When the duplex is changed to full, the flag needs to be set
to send LACP PDU.

Cc: Andy Gospodarek 
Reviewed-by: Nikolay Aleksandrov 
Signed-off-by: Satish Ashok 
Signed-off-by: Jonathan Toppins 
Signed-off-by: Jay Vosburgh 
Signed-off-by: David S. Miller

bonding: fix incorrect lacp mux state when agg not active

2015-01-28T01:09:04+00:00

This patch attempts to fix the following problems when an actor or
partner's aggregator is not active:
    1. a slave's lacp port state is marked as AD_STATE_SYNCHRONIZATION
       even if it is attached to an inactive aggregator. LACP advertises
       this state to the partner, making the partner think he can move
       into COLLECTING_DISTRIBUTING state even though this link will not
       pass traffic on the local side

    2. a slave goes into COLLECTING_DISTRIBUTING state without checking
       if the aggregator is actually active

    3. when in COLLECTING_DISTRIBUTING state, the partner parameters may
       change, e.g. the partner_oper_port_state.SYNCHRONIZATION. The
       local mux machine is not reacting to the change and continue to
       keep the slave and bond up

    4. When bond slave leaves an inactive aggregator and joins an active
       aggregator, the actor oper port state need to update to SYNC state.

v2:
 * fix style issues in bond_3ad.c

Cc: Andy Gospodarek 
Reviewed-by: Nikolay Aleksandrov 
Signed-off-by: Wilson Kok 
Signed-off-by: Jonathan Toppins 
Signed-off-by: David S. Miller

bonding: fix bond_open() don't always set slave active flag

2015-01-28T01:09:03+00:00

Mode 802.3ad, fix incorrect bond slave active state when slave is not in
active aggregator. During bond_open(), the bonding driver always sets
the slave active flag to true if the bond is not in active-backup, alb,
or tlb modes. Bonding should let the aggregator selection logic set the
active flag when in 802.3ad mode.

Cc: Andy Gospodarek 
Reviewed-by: Nikolay Aleksandrov 
Signed-off-by: Wilson Kok 
Signed-off-by: Jonathan Toppins 
Signed-off-by: Jay Vosburgh 
Signed-off-by: David S. Miller

bonding: update bond carrier state when min_links option changes

2015-01-28T01:09:03+00:00

Cc: Andy Gospodarek 
Signed-off-by: Jonathan Toppins 
Signed-off-by: Jay Vosburgh 
Signed-off-by: David S. Miller