linux.git/drivers/net/bonding, branch v2.6.25

[BOND]: Fix warning in bond_sysfs.c

2008-03-28T23:15:38+00:00

original_mtu is only used if we end up with a non-NULL
dev, and it is assigned in all such cases, but GCC can't
see that.

Signed-off-by: David S. Miller

bonding: update version

2008-03-26T03:15:51+00:00

	Update version to 3.2.5.

Signed-off-by: Jay Vosburgh 
Signed-off-by: Jeff Garzik

bonding: Fix sysfs attribute handling

2008-03-26T03:15:48+00:00

For bonding interfaces any attempt to read the sysfs directory contents after
module removal results in an oops.  The fix is to release sysfs attributes
for the interfaces upon module unload.

Signed-off-by: Libor Pechacek 
Acked-by: Jay Vosburgh 
Signed-off-by: Jeff Garzik

bonding: fix two compiler warnings

2008-03-26T03:15:40+00:00

	Fix two compiler warnings that are new with recent versions of gcc
(apparently 4.2 and up).  One is fixed by refactoring; this change was
supplied by Stephen Hemminger.  The other was fixed by labelling the
variable as uninitialized_var() after confirming via inspection that it
cannot actually be used uninitialized.

Signed-off-by: Jay Vosburgh 
Signed-off-by: Stephen Hemminger 
Signed-off-by: Jeff Garzik

bonding: Fix locking in 802.3ad mode

2008-03-26T03:15:38+00:00

	The 802.3ad state machine lock can be acquired in both softirq and
not softirq context, but was not held at _bh to prevent a deadlock (which
could occur if a LACPDU arrived and was processed while the lock was
held).

	Corrected this, now hold the state machine lock at _bh to prevent
deadlock.

	Bug reported by Todd Fleisher .

Signed-off-by: Jay Vosburgh 
Signed-off-by: Jeff Garzik

bonding: update version

2008-02-03T12:28:34+00:00

	Update bonding to version 3.2.4.

Signed-off-by: Jay Vosburgh 
Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller

bonding: do not acquire rtnl in ARP monitor

2008-02-03T12:28:33+00:00

	The ARP monitor functions currently acquire RTNL when performing
failover operations, but do so incorrectly (out of order).  This causes
various warnings from might_sleep.

	The ARP monitor isn't supported for any of the bonding modes
that actually require RTNL, so it is safe to not hold RTNL when
failing over in the ARP monitor.

Signed-off-by: Jay Vosburgh 
Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller

bonding: fix race that causes invalid statistics

2008-02-03T12:28:13+00:00

I've seen reports of invalid stats in /proc/net/dev for bonding
interfaces, and found it's a pretty easy problem to reproduce.  Since
the current code zeros the bonding stats when a read is requested and a
pointer to that data is returned to the caller we cannot guarantee that
the caller has completely accessed the data before a successive call to
request the stats zeroes the stats again.

This patch creates a new stack variable to keep track of the updated
stats and copies the data from that variable into the bonding stats
structure.  This ensures that the value for any of the bonding stats
should not incorrectly return zero for any of the bonding statistics.
This does use more stack space and require an extra memcpy, but it seems
like a fair trade-off for consistently correct bonding statistics.

Signed-off-by: Andy Gospodarek 
Signed-off-by: Chris Snook 
Acked-by: Jay Vosburgh 
Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller

bonding: fix NULL pointer deref in startup processing

2008-02-03T12:28:12+00:00

	Fix the "are we creating a duplicate" check to not compare
the name if the name is NULL (meaning that the system should select
a name).  Bug reported by Benny Amorsen .

Signed-off-by: Jay Vosburgh 
Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller

bonding: fix set_multicast_list locking

2008-02-03T12:28:12+00:00

	This patch eliminates a problem (reported by lockdep) in the
bond_set_multicast_list function.  It first reduces the locking on
bond->lock to a simple read_lock, and second, adds netif_tx locking
around the bonding mc_list manipulations that occur outside of the
set_multicast_list function.

	The original problem was related to IPv6 addrconf activity.

Signed-off-by: Jay Vosburgh 
Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller