linux.git/drivers/net/benet, branch v2.6.37

be2net: use mutex instead of spin lock for mbox_lock

2010-12-16T22:12:26+00:00

Since the mbox polling uses the schedule_timeout, the mbox_lock should be
a mutex and not a spin lock.
The commit f25b03a replaced udelay() with schedule_timeout() but didn't
change mbox_lock to semaphore or mutex.

Signed-off-by: Ivan Vecera 
Signed-off-by: David S. Miller

driver/net/benet: fix be_cmd_multicast_set() memcpy bug

2010-12-08T20:13:43+00:00

Regarding  benet be_cmd_multicast_set() function, now using
netdev_for_each_mc_addr() helper for mac address copy, but
when copying to req->mac[] did not increase of the index.

Cc: Sathya Perla 
Cc: Subbu Seetharaman 
Cc: Sarveshwar Bandi 
Cc: Ajit Khaparde 
Signed-off-by: Joe Jin 
Signed-off-by: David S. Miller

be2net: Fix to avoid firmware update when interface is not open.

2010-11-19T16:57:19+00:00

Since interrupts are enabled only when open is called on the interface,
Attempting a firmware update operation when interface is down could lead to
partial success or failure of operation. This fix fails the request if
netif_running is false.

Signed-off-by: Sarveshwar Bandi 
Signed-off-by: David S. Miller

be2net: Schedule/Destroy worker thread in probe()/remove() rather than open()/close()

2010-10-27T18:37:30+00:00

When async mcc compls are rcvd on an i/f that is down (and so interrupts are disabled)
they just lie unprocessed in the compl queue.The compl queue can eventually get filled
up and cause the BE to lock up.The fix is to use be_worker to reap mcc compls when the
i/f is down.be_worker is now launched in be_probe() and canceled in be_remove().

Signed-off-by: Somnath Kotur 
Signed-off-by: David S. Miller

be2net: Fix CSO for UDP packets

2010-10-25T19:14:10+00:00

We're setting skb->ip_summed to CHECKSUM_NONE for all non-TCP pkts, making the stack
recompute checksum.This is a bug for UDP pkts for which cso must be used.

Signed-off-by: Somnath Kotur 
Signed-off-by: David S. Miller

be2net: Call netif_carier_off() after register_netdev()

2010-10-25T19:14:10+00:00

Calling netif_carrier_off before register_netdev was causing the network interface
to miss a linkwatch pending event leading to  an inconsistent state if the link
is not up when interface is initialized.This is now invoked after register_netdev.

Signed-off-by: Somnath Kotur 
Signed-off-by: David S. Miller

benet: make be_poll_rx local

2010-10-24T21:55:48+00:00

Only used in one file.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

benet: remove dead code

2010-10-24T21:55:48+00:00

The following code and data are defined but never used in current
driver.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

be2net: Changes to use only priority codes allowed by f/w

2010-10-21T14:11:14+00:00

Changes to use one of the priority codes allowed by CNA f/w for NIC traffic
from host. The driver gets the bit map of the priority codes allowed for
host traffic through a asynchronous message from the f/w that the driver
subscribes to.

Signed-off-by: Somnath Kotur 
Signed-off-by: David S. Miller

vlan: Don't check for vlan group before vlan_tx_tag_present.

2010-10-21T08:26:52+00:00

Many (but not all) drivers check to see whether there is a vlan
group configured before using a tag stored in the skb.  There's
not much point in this check since it just throws away data that
should only be present in the expected circumstances.  However,
it will soon be legal and expected to get a vlan tag when no
vlan group is configured, so remove this check from all drivers
to avoid dropping the tags.

Signed-off-by: Jesse Gross 
Signed-off-by: David S. Miller