linux.git/drivers/net/b44.c, branch v2.6.31

drivers/net: fixed drivers that support netpoll use ndo_start_xmit()

2009-08-14T23:41:16+00:00

The NETPOLL API requires that interrupts remain disabled in
netpoll_send_skb(). The use of spin_lock_irq() and spin_unlock_irq()
in the NETPOLL API callbacks causes the interrupts to get enabled and
can lead to kernel instability.

The solution is to use spin_lock_irqsave() and spin_unlock_restore()
to prevent the irqs from getting enabled while in netpoll_send_skb().

Call trace:
netpoll_send_skb()
{
   -> local_irq_save(flags)
     ---> dev->ndo_start_xmit(skb, dev)
         ---> spin_lock_irq()
         ---> spin_unlock_irq() *******here would enable the interrupt.
              ...
   -> local_irq_restore(flags)
}

Signed-off-by: Dongdong Deng 
Signed-off-by: Jason Wessel 
Acked-by: Bruce Ashfield 
Acked-by: Matt Mackall 
Signed-off-by: David S. Miller

net: use netdev stats in b44, sundance, via-rhine and via-velocity

2009-05-27T22:47:07+00:00

Use struct net_device_stats provided in struct net_device instead of
private ones.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

dma-mapping: replace all DMA_30BIT_MASK macro with DMA_BIT_MASK(30)

2009-04-07T15:31:11+00:00

Replace all DMA_30BIT_MASK macro with DMA_BIT_MASK(30)

Signed-off-by: Yang Hongyang
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

b44: Use kernel DMA addresses for the kernel DMA API

2009-04-07T00:51:29+00:00

We must not use the device DMA addresses for the kernel DMA API, because
device DMA addresses have an additional offset added for the SSB translation.

Use the original dma_addr_t for the sync operation.

Cc: stable@kernel.org
Signed-off-by: Michael Buesch 
Signed-off-by: David S. Miller

b44: Fix sizes passed to b44_sync_dma_desc_for_{device,cpu}()

2009-04-04T23:48:17+00:00

> > ------------[ cut here ]------------
> > WARNING: at lib/dma-debug.c:539 check_sync+0xe9/0x341() (Not tainted)
> > Hardware name: HP Compaq nx6110 (PY501EA#AB9)
> > b44 0000:02:0e.0: DMA-API: device driver tries to sync DMA memory it has not
> > allocated [device address=0x0000000075941040] [size=1566 bytes]
> > Modules linked in: llc bnep l2cap bluetooth autofs4 lm90 hwmon i2c_i801 sunrpc
> > ipv6 cpufreq_ondemand acpi_cpufreq uinput snd_intel8x0m snd_intel8x0
> > snd_ac97_codec snd_seq_dummy ac97_bus snd_seq_oss snd_seq_midi_event snd_seq
> > snd_seq_device snd_pcm_oss snd_mixer_oss snd_pcm b44 ssb firewire_ohci
> > snd_timer ipw2200 iTCO_wdt mii firewire_core snd iTCO_vendor_support libipw
> > yenta_socket crc_itu_t lib80211 rsrc_nonstatic soundcore snd_page_alloc joydev
> > pcspkr wmi serio_raw ata_generic pata_acpi i915 drm i2c_algo_bit i2c_core video
> > output [last unloaded: scsi_wait_scan]
> > Pid: 2418, comm: S58ntpd Not tainted 2.6.29-16.fc10.i686.PAE #1
> > Call Trace:
> >  [] warn_slowpath+0x7c/0xbd
> >  [] ? register_lock_class+0x17/0x290
> >  [] ? mark_lock+0x1e/0x349
> >  [] ? _raw_spin_unlock+0x74/0x78
> >  [] ? mark_lock+0x1e/0x349
> >  [] ? check_sync+0x37/0x341
> >  [] check_sync+0xe9/0x341
> >  [] ? _spin_unlock_irqrestore+0x45/0x55
> >  [] ? trace_hardirqs_on+0xb/0xd
> >  [] debug_dma_sync_single_for_device+0x2f/0x39
> >  [] dma_sync_single_for_device+0x4a/0x59 [b44]
> >  [] ssb_dma_sync_single_for_device+0x3e/0x48 [b44]
> >  [] b44_recycle_rx+0x18c/0x196 [b44]
> >  [] b44_poll+0x277/0x3c0 [b44]
> >  [] net_rx_action+0xa1/0x1ca
> >  [] __do_softirq+0x9d/0x154
> >  [] do_softirq+0x52/0x7e
> >  [] irq_exit+0x49/0x77
> >  [] do_IRQ+0x97/0xad
> >  [] common_interrupt+0x2c/0x34

I don't know if this is related, but the following patch seems to fix some DMA
mapping bug. Can somebody comment who does understand the code better than me?

(completely untested)

Signed-off-by: David S. Miller

Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6

2009-03-02T05:35:16+00:00

Conflicts:
	drivers/net/wireless/iwlwifi/iwl-tx.c
	net/8021q/vlan_core.c
	net/core/dev.c

b44: Disable device on shutdown

2009-02-27T06:35:02+00:00

Disable the SSB core on device shutdown.
This has two advantages:
1) A clean device shutdown is always desired here, because we disable
  the device's global crystal in the next statement.
2) This fixes a bug where the device will come up with the enable-bit
  set on the next initialization (without a reboot inbetween).
  This causes breakage on the second initialization due to code that
  checks this bit (ssb_device_is_enabled() checks).

Reported-by: Pantelis Koukousoulas 
Signed-off-by: Michael Buesch 
Signed-off-by: David S. Miller

b44: Unconditionally enable interrupt routing on reset

2009-02-27T06:33:00+00:00

Unconditionally setup the IRQ routing on chip reset.
It's safe to call ssb_pcicore_dev_irqvecs_enable() unconditionally, because
it has internal checks for redundant calls.

This fixes problems where hardware will not come up properly
due to quirks in the enable-bit hardware.

Reported-by: Pantelis Koukousoulas 
Signed-off-by: Michael Buesch 
Signed-off-by: David S. Miller

netdev: Use __netdev_alloc_skb() instead of __dev_alloc_skb().

2009-02-10T09:56:45+00:00

Signed-off-by: David S. Miller

net: Remove redundant NAPI functions

2009-01-21T22:33:50+00:00

Following the removal of the unused struct net_device * parameter from
the NAPI functions named *netif_rx_* in commit 908a7a1, they are
exactly equivalent to the corresponding *napi_* functions and are
therefore redundant.

Signed-off-by: Ben Hutchings 
Acked-by: Neil Horman 
Signed-off-by: David S. Miller