linux.git/drivers/mtd/mtdcore.c, branch v5.16

Merge tag 'mtd/for-5.16' of git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux

2021-11-08T19:37:39+00:00

Pull mtd updates from Miquel Raynal:
 "Core:
   - Remove obsolete macros only used by the old nand_ecclayout struct
   - Don't remove debugfs directory if device is in use
   - MAINTAINERS:
      - Add entry for Qualcomm NAND controller driver
      - Update the devicetree documentation path of hyperbus

  MTD devices:
   - block2mtd:
      - Add support for an optional custom MTD label
      - Minor refactor to avoid hard coded constant
   - mtdswap: Remove redundant assignment of pointer eb

  CFI:
   - Fixup CFI on ixp4xx

  Raw NAND controller drivers:
   - Arasan:
      - Prevent an unsupported configuration
   - Xway, Socrates: plat_nand, Pasemi, Orion, mpc5121, GPIO, Au1550nd,
     AMS-Delta:
      - Keep the driver compatible with on-die ECC engines
   - cs553x, lpc32xx_slc, ndfc, sharpsl, tmio, txx9ndfmc:
      - Revert the commits: "Fix external use of SW Hamming ECC helper"
      - And let callers use the bare Hamming helpers
   - Fsmc: Fix use of SM ORDER
   - Intel:
      - Fix potential buffer overflow in probe
   - xway, vf610, txx9ndfm, tegra, stm32, plat_nand, oxnas, omap, mtk,
     hisi504, gpmi, gpio, denali, bcm6368, atmel:
      - Make use of the helper function devm_platform_ioremap_resource{,byname}()

  Onenand drivers:
   - Samsung: Drop Exynos4 and describe driver in KConfig

  Raw NAND chip drivers:
   - Hynix: Add support for H27UCG8T2ETR-BC MLC NAND

  SPI NOR core:
   - Add spi-nor device tree binding under SPI NOR maintainers

  SPI NOR manufacturer drivers:
   - Enable locking for n25q128a13

  SPI NOR controller drivers:
   - Use devm_platform_ioremap_resource_byname()"

* tag 'mtd/for-5.16' of git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux: (50 commits)
  mtd: core: don't remove debugfs directory if device is in use
  MAINTAINERS: Update the devicetree documentation path of hyperbus
  mtd: block2mtd: add support for an optional custom MTD label
  mtd: block2mtd: minor refactor to avoid hard coded constant
  mtd: fixup CFI on ixp4xx
  mtd: rawnand: arasan: Prevent an unsupported configuration
  MAINTAINERS: Add entry for Qualcomm NAND controller driver
  mtd: rawnand: hynix: Add support for H27UCG8T2ETR-BC MLC NAND
  mtd: rawnand: xway: Keep the driver compatible with on-die ECC engines
  mtd: rawnand: socrates: Keep the driver compatible with on-die ECC engines
  mtd: rawnand: plat_nand: Keep the driver compatible with on-die ECC engines
  mtd: rawnand: pasemi: Keep the driver compatible with on-die ECC engines
  mtd: rawnand: orion: Keep the driver compatible with on-die ECC engines
  mtd: rawnand: mpc5121: Keep the driver compatible with on-die ECC engines
  mtd: rawnand: gpio: Keep the driver compatible with on-die ECC engines
  mtd: rawnand: au1550nd: Keep the driver compatible with on-die ECC engines
  mtd: rawnand: ams-delta: Keep the driver compatible with on-die ECC engines
  Revert "mtd: rawnand: cs553x: Fix external use of SW Hamming ECC helper"
  Revert "mtd: rawnand: lpc32xx_slc: Fix external use of SW Hamming ECC helper"
  Revert "mtd: rawnand: ndfc: Fix external use of SW Hamming ECC helper"
  ...

mtd: call bdi_unregister explicitly

2021-11-06T20:30:34+00:00

Call bdi_unregister explicitly instead of relying on the automatic
unregistration.

Link: https://lkml.kernel.org/r/20211021124441.668816-3-hch@lst.de
Signed-off-by: Christoph Hellwig 
Reviewed-by: Jan Kara 
Cc: Miquel Raynal 
Cc: Richard Weinberger 
Cc: Vignesh Raghavendra 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mtd: core: don't remove debugfs directory if device is in use

2021-10-15T10:30:40+00:00

Previously, if del_mtd_device() failed with -EBUSY due to a non-zero
usecount, a subsequent call to attempt the deletion again would try to
remove a debugfs directory that had already been removed and panic.
With this change the second call can instead proceed safely.

Fixes: e8e3edb95ce6 ("mtd: create per-device and module-scope debugfs entries")
Signed-off-by: Zev Weiss 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20211014203953.5424-1-zev@bewilderbeest.net

mtd: core: handle flashes without OTP gracefully

2021-07-15T22:49:20+00:00

There are flash drivers which registers the OTP callbacks although the
flash doesn't support OTP regions and return -ENODATA for these
callbacks if there is no OTP. If this happens, the probe of the whole
flash will fail. Fix it by handling the ENODATA return code and skip
the OTP region nvmem setup.

Fixes: 4b361cfa8624 ("mtd: core: add OTP nvmem provider support")
Reported-by: Guenter Roeck 
Signed-off-by: Michael Walle 
Tested-by: Guenter Roeck 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20210707135359.32398-1-michael@walle.cc

mtd: core: use MTD_DEVICE_ATTR_RO/RW() helper macros

2021-06-11T18:42:57+00:00

Use MTD_DEVICE_ATTR_RO/RW() helper macros instead of plain DEVICE_ATTR(),
which makes the code a bit shorter and easier to read.

Signed-off-by: Zhen Lei 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20210603125323.12142-3-thunder.leizhen@huawei.com

mtd: core: add MTD_DEVICE_ATTR_RO/RW() helper macros

2021-06-11T18:42:50+00:00

Compared with the definition of DEVICE_ATTR_RO/RW(), the read and write
function names of the sysfs attribute have an additional "mtd_" prefix.

Signed-off-by: Zhen Lei 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20210603125323.12142-2-thunder.leizhen@huawei.com

mtd: core: Potential NULL dereference in mtd_otp_size()

2021-05-26T08:41:43+00:00

If kmalloc() fails then it could lead to a NULL dereference.  Check and
return -ENOMEM on error.

Fixes: 4b361cfa8624 ("mtd: core: add OTP nvmem provider support")
Signed-off-by: Dan Carpenter 
Reviewed-by: Michael Walle 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/YJ6Iw3iNvGycAWV6@mwanda

mtd: core: Fix freeing of otp_info buffer

2021-05-26T08:39:27+00:00

Commit 4b361cfa8624 ("mtd: core: add OTP nvmem provider support") is
causing the following panic ...

 ------------[ cut here ]------------
 kernel BUG at /local/workdir/tegra/linux_next/kernel/mm/slab.c:2730!
 Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM
 Modules linked in:
 CPU: 3 PID: 1 Comm: swapper/0 Not tainted 5.13.0-rc2-next-20210518 #1
 Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
 PC is at ___cache_free+0x3f8/0x51c
 ...
 [] (___cache_free) from [] (kfree+0xac/0x1bc)
 [] (kfree) from [] (mtd_otp_size+0xc4/0x108)
 [] (mtd_otp_size) from [] (mtd_device_parse_register+0xe4/0x2b4)
 [] (mtd_device_parse_register) from [] (spi_nor_probe+0x210/0x2c0)
 [] (spi_nor_probe) from [] (spi_probe+0x88/0xac)
 [] (spi_probe) from [] (really_probe+0x214/0x3a4)
 [] (really_probe) from [] (driver_probe_device+0x68/0xc0)
 [] (driver_probe_device) from [] (bus_for_each_drv+0x5c/0xbc)
 [] (bus_for_each_drv) from [] (__device_attach+0xe4/0x150)
 [] (__device_attach) from [] (bus_probe_device+0x84/0x8c)
 [] (bus_probe_device) from [] (device_add+0x48c/0x868)
 [] (device_add) from [] (spi_add_device+0xa0/0x168)
 [] (spi_add_device) from [] (spi_register_controller+0x8b8/0xb38)
 [] (spi_register_controller) from [] (devm_spi_register_controller+0x14/0x50)
 [] (devm_spi_register_controller) from [] (tegra_spi_probe+0x33c/0x450)
 [] (tegra_spi_probe) from [] (platform_probe+0x5c/0xb8)
 [] (platform_probe) from [] (really_probe+0x214/0x3a4)
 [] (really_probe) from [] (driver_probe_device+0x68/0xc0)
 [] (driver_probe_device) from [] (device_driver_attach+0x58/0x60)
 [] (device_driver_attach) from [] (__driver_attach+0x80/0xc8)
 [] (__driver_attach) from [] (bus_for_each_dev+0x78/0xb8)
 [] (bus_for_each_dev) from [] (bus_add_driver+0x164/0x1e8)
 [] (bus_add_driver) from [] (driver_register+0x7c/0x114)
 [] (driver_register) from [] (do_one_initcall+0x50/0x2b0)
 [] (do_one_initcall) from [] (kernel_init_freeable+0x1a8/0x1fc)
 [] (kernel_init_freeable) from [] (kernel_init+0x8/0x118)
 [] (kernel_init) from [] (ret_from_fork+0x14/0x24)
 ...
 ---[ end trace 0f652dd222de75d7 ]---

In the function mtd_otp_size() a buffer is allocated by calling
kmalloc() and a pointer to the buffer is stored in a variable 'info'.
The pointer 'info' may then be incremented depending on the length
returned from mtd_get_user/fact_prot_info(). If 'info' is incremented,
when kfree() is called to free the buffer the above panic occurs because
we are no longer passing the original address of the buffer allocated.
Fix this by indexing through the buffer allocated to avoid incrementing
the pointer.

Fixes: 4b361cfa8624 ("mtd: core: add OTP nvmem provider support")
Signed-off-by: Jon Hunter 
Reviewed-by: Michael Walle 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20210518185503.162787-1-jonathanh@nvidia.com

mtd: Create partname and partid debug files for child MTDs

2021-05-10T10:48:45+00:00

Partname and partid are set by the upper driver (spi-nor) on the master
MTD. If this MTD is partitioned and CONFIG_MTD_PARTITIONED_MASTER is
disabled, the master MTD is not instantiated and partname and partid
aren't available to the userspace.

Always read the partname and partid from the master MTD, they describe
the HW, which can't differ between master and its children.

Signed-off-by: Petr Malat 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20210430065057.32018-1-oss@malat.biz

mtd: core: add OTP nvmem provider support

2021-05-10T10:42:55+00:00

Flash OTP regions can already be read via user space. Some boards have
their serial number or MAC addresses stored in the OTP regions. Add
support for them being a (read-only) nvmem provider.

The API to read the OTP data is already in place. It distinguishes
between factory and user OTP, thus there are up to two different
providers.

Signed-off-by: Michael Walle 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20210424110608.15748-6-michael@walle.cc