linux.git/drivers/mtd/mtdcore.c, branch v5.14

mtd: core: handle flashes without OTP gracefully

2021-07-15T22:49:20+00:00

There are flash drivers which registers the OTP callbacks although the
flash doesn't support OTP regions and return -ENODATA for these
callbacks if there is no OTP. If this happens, the probe of the whole
flash will fail. Fix it by handling the ENODATA return code and skip
the OTP region nvmem setup.

Fixes: 4b361cfa8624 ("mtd: core: add OTP nvmem provider support")
Reported-by: Guenter Roeck 
Signed-off-by: Michael Walle 
Tested-by: Guenter Roeck 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20210707135359.32398-1-michael@walle.cc

mtd: core: use MTD_DEVICE_ATTR_RO/RW() helper macros

2021-06-11T18:42:57+00:00

Use MTD_DEVICE_ATTR_RO/RW() helper macros instead of plain DEVICE_ATTR(),
which makes the code a bit shorter and easier to read.

Signed-off-by: Zhen Lei 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20210603125323.12142-3-thunder.leizhen@huawei.com

mtd: core: add MTD_DEVICE_ATTR_RO/RW() helper macros

2021-06-11T18:42:50+00:00

Compared with the definition of DEVICE_ATTR_RO/RW(), the read and write
function names of the sysfs attribute have an additional "mtd_" prefix.

Signed-off-by: Zhen Lei 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20210603125323.12142-2-thunder.leizhen@huawei.com

mtd: core: Potential NULL dereference in mtd_otp_size()

2021-05-26T08:41:43+00:00

If kmalloc() fails then it could lead to a NULL dereference.  Check and
return -ENOMEM on error.

Fixes: 4b361cfa8624 ("mtd: core: add OTP nvmem provider support")
Signed-off-by: Dan Carpenter 
Reviewed-by: Michael Walle 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/YJ6Iw3iNvGycAWV6@mwanda

mtd: core: Fix freeing of otp_info buffer

2021-05-26T08:39:27+00:00

Commit 4b361cfa8624 ("mtd: core: add OTP nvmem provider support") is
causing the following panic ...

 ------------[ cut here ]------------
 kernel BUG at /local/workdir/tegra/linux_next/kernel/mm/slab.c:2730!
 Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM
 Modules linked in:
 CPU: 3 PID: 1 Comm: swapper/0 Not tainted 5.13.0-rc2-next-20210518 #1
 Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
 PC is at ___cache_free+0x3f8/0x51c
 ...
 [] (___cache_free) from [] (kfree+0xac/0x1bc)
 [] (kfree) from [] (mtd_otp_size+0xc4/0x108)
 [] (mtd_otp_size) from [] (mtd_device_parse_register+0xe4/0x2b4)
 [] (mtd_device_parse_register) from [] (spi_nor_probe+0x210/0x2c0)
 [] (spi_nor_probe) from [] (spi_probe+0x88/0xac)
 [] (spi_probe) from [] (really_probe+0x214/0x3a4)
 [] (really_probe) from [] (driver_probe_device+0x68/0xc0)
 [] (driver_probe_device) from [] (bus_for_each_drv+0x5c/0xbc)
 [] (bus_for_each_drv) from [] (__device_attach+0xe4/0x150)
 [] (__device_attach) from [] (bus_probe_device+0x84/0x8c)
 [] (bus_probe_device) from [] (device_add+0x48c/0x868)
 [] (device_add) from [] (spi_add_device+0xa0/0x168)
 [] (spi_add_device) from [] (spi_register_controller+0x8b8/0xb38)
 [] (spi_register_controller) from [] (devm_spi_register_controller+0x14/0x50)
 [] (devm_spi_register_controller) from [] (tegra_spi_probe+0x33c/0x450)
 [] (tegra_spi_probe) from [] (platform_probe+0x5c/0xb8)
 [] (platform_probe) from [] (really_probe+0x214/0x3a4)
 [] (really_probe) from [] (driver_probe_device+0x68/0xc0)
 [] (driver_probe_device) from [] (device_driver_attach+0x58/0x60)
 [] (device_driver_attach) from [] (__driver_attach+0x80/0xc8)
 [] (__driver_attach) from [] (bus_for_each_dev+0x78/0xb8)
 [] (bus_for_each_dev) from [] (bus_add_driver+0x164/0x1e8)
 [] (bus_add_driver) from [] (driver_register+0x7c/0x114)
 [] (driver_register) from [] (do_one_initcall+0x50/0x2b0)
 [] (do_one_initcall) from [] (kernel_init_freeable+0x1a8/0x1fc)
 [] (kernel_init_freeable) from [] (kernel_init+0x8/0x118)
 [] (kernel_init) from [] (ret_from_fork+0x14/0x24)
 ...
 ---[ end trace 0f652dd222de75d7 ]---

In the function mtd_otp_size() a buffer is allocated by calling
kmalloc() and a pointer to the buffer is stored in a variable 'info'.
The pointer 'info' may then be incremented depending on the length
returned from mtd_get_user/fact_prot_info(). If 'info' is incremented,
when kfree() is called to free the buffer the above panic occurs because
we are no longer passing the original address of the buffer allocated.
Fix this by indexing through the buffer allocated to avoid incrementing
the pointer.

Fixes: 4b361cfa8624 ("mtd: core: add OTP nvmem provider support")
Signed-off-by: Jon Hunter 
Reviewed-by: Michael Walle 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20210518185503.162787-1-jonathanh@nvidia.com

mtd: Create partname and partid debug files for child MTDs

2021-05-10T10:48:45+00:00

Partname and partid are set by the upper driver (spi-nor) on the master
MTD. If this MTD is partitioned and CONFIG_MTD_PARTITIONED_MASTER is
disabled, the master MTD is not instantiated and partname and partid
aren't available to the userspace.

Always read the partname and partid from the master MTD, they describe
the HW, which can't differ between master and its children.

Signed-off-by: Petr Malat 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20210430065057.32018-1-oss@malat.biz

mtd: core: add OTP nvmem provider support

2021-05-10T10:42:55+00:00

Flash OTP regions can already be read via user space. Some boards have
their serial number or MAC addresses stored in the OTP regions. Add
support for them being a (read-only) nvmem provider.

The API to read the OTP data is already in place. It distinguishes
between factory and user OTP, thus there are up to two different
providers.

Signed-off-by: Michael Walle 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20210424110608.15748-6-michael@walle.cc

mtd: core: Convert sysfs sprintf/snprintf family to sysfs_emit

2021-05-10T08:44:40+00:00

Use sysfs_emit instead of snprintf to avoid buf overrun,because in
sysfs_emit it strictly checks whether buf is null or buf whether
pagesize aligned, otherwise it returns an error.

Signed-off-by: Tian Tao 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/1618220144-33839-2-git-send-email-tiantao6@hisilicon.com

mtd: core: Constify buf in mtd_write_user_prot_reg()

2021-04-16T18:30:54+00:00

The write buffer comes from user and should be const.
Constify write buffer in mtd core and across all _write_user_prot_reg()
users. cfi_cmdset_{0001, 0002} and onenand_base will pay the cost of an
explicit cast to discard the const qualifier since the beginning, since
they are using an otp_op_t function prototype that is used for both reads
and writes. mtd_dataflash and SPI NOR will benefit of the const buffer
because they are using different paths for writes and reads.

Signed-off-by: Tudor Ambarus 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20210403060931.7119-1-tudor.ambarus@microchip.com

Merge tag 'nand/for-5.13' of git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux into mtd/next

2021-04-15T19:14:51+00:00

MTD core:
* Handle possible -EPROBE_DEFER from parse_mtd_partitions()

NAND core:
* Fix error handling in nand_prog_page_op() (x2)
* Add a helper to retrieve the number of ECC bytes per step
* Add a helper to retrieve the number of ECC steps
* Let ECC engines advertize the exact number of steps
* ECC Hamming:
  - Populate the public nsteps field
  - Use the public nsteps field
* ECC BCH:
  - Populate the public nsteps field
  - Use the public nsteps field

Raw NAND core:
* Add support for secure regions in NAND memory
* Try not to use the ECC private structures
* Remove duplicate include in rawnand.h
* BBT:
  - Skip bad blocks when searching for the BBT in NAND

Raw NAND controller drivers:
* Qcom:
  - Convert bindings to YAML
  - Use dma_mapping_error() for error check
  - Add missing nand_cleanup() in error path
  - Return actual error code instead of -ENODEV
  - Update last code word register
  - Add helper to configure location register
  - Rename parameter name in macro
  - Add helper to check last code word
  - Convert nandc to chip in Read/Write helper
  - Update register macro name for 0x2c offset
* GPMI:
  - Fix a double free in gpmi_nand_init
* Rockchip:
  - Use flexible-array member instead of zero-length array
* Atmel:
  - Update ecc_stats.corrected counter
* MXC:
  - Remove unneeded of_match_ptr()
* R852:
  - replace spin_lock_irqsave by spin_lock in hard IRQ
* Brcmnand:
  - Move to polling in pio mode on oops write
  - Read/write oob during EDU transfer
  - Fix OOB R/W with Hamming ECC
* FSMC:
  - Fix error code in fsmc_nand_probe()
* OMAP:
  - Use ECC information from the generic structures

SPI-NAND core:
* Add missing MODULE_DEVICE_TABLE()

SPI-NAND drivers:
* gigadevice: Support GD5F1GQ5UExxG