linux.git/drivers/mtd/mtdcore.c, branch v4.14

mtd: make device_type const

2017-08-21T12:33:50+00:00

Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal 
Signed-off-by: Boris Brezillon

mtd: create per-device and module-scope debugfs entries

2017-07-21T20:25:29+00:00

Several MTD devices are using debugfs entries created in the root.
This commit provides the means for a standardized subtree, creating
one "mtd" entry at root, and one entry per device inside it, named
after the device.
The tree is registered in add_mtd_device, and released in
del_mtd_device.
Devices docg3, mtdswap and nandsim were updated to use this subtree
instead of custom ones, and their entries were prefixed with the
drivers' names.

Signed-off-by: Mario J. Rugiero 
Acked-by: Boris Brezillon 
Signed-off-by: Brian Norris

mtd: Fix check in mtd_unpoint()

2017-07-08T00:57:59+00:00

The code checks that ->_point is not NULL, but we should actually check
->_unpoint value which is dereferenced a few lines after the check.

Signed-off-by: Boris Brezillon 
Signed-off-by: Brian Norris

bdi: Drop 'parent' argument from bdi_register[_va]()

2017-04-20T18:09:55+00:00

Drop 'parent' argument of bdi_register() and bdi_register_va().  It is
always NULL.

Reviewed-by: Christoph Hellwig 
Signed-off-by: Jan Kara 
Signed-off-by: Jens Axboe

mtd: Convert to dynamically allocated bdi infrastructure

2017-04-20T18:09:55+00:00

MTD already allocates backing_dev_info dynamically. Convert it to use
generic infrastructure for this including proper refcounting. We drop
mtd->backing_dev_info as its only use was to pass mtd_bdi pointer from
one file into another and if we wanted to keep that in a clean way, we'd
have to make mtd hold and drop bdi reference as needed which seems
pointless for passing one global pointer...

CC: David Woodhouse 
CC: Brian Norris 
CC: linux-mtd@lists.infradead.org
Reviewed-by: Christoph Hellwig 
Signed-off-by: Jan Kara 
Signed-off-by: Jens Axboe

mtd: fix typos in ooblayout comment blocks

2017-02-08T21:32:08+00:00

- "This functions return ..." -> "This function returns ..."
 - "I you want ..." -> "If you want ..."

Signed-off-by: Masahiro Yamada 
Acked-by: Boris Brezillon 
Signed-off-by: Brian Norris

mtd: Allocate bdi objects dynamically

2016-12-01T18:03:17+00:00

The MTD backing dev info objects mtd_bdi was statically allocated.
So when MTD is built as a loadable module, this object fall in the
vmalloc address space.

The problem with that, is that the BDI APIs use wake_up_bit(), which calls
virt_to_page() to retrieve the memory zone of the page containing the
wait_queue to wake up, and virt_to_page() is not valid for vmalloc or
highmem addresses.

Fix this by allocating the BDI objects dynamically with kmalloc. The
objects now fall in the logical address space so that BDI APIs will
work in all cases (mtd builtin or module).

Signed-off-by: Steve Longerbeam 
Signed-off-by: Jim Baxter 
Signed-off-by: Sandeep Jain 
Reviewed-by: Richard Weinberger 
Reviewed-by: Marek Vasut 
Signed-off-by: Brian Norris

mtd: remove unneeded initializer in mtd_ooblayout_count_bytes()

2016-11-19T18:31:34+00:00

There is no need to initialize oobregion since it will be filled by
the iterator.

This function is called with mtd_ooblayout_free or mtd_ooblayout_ecc
for the iterator; both of them calls memset() to clear the oobregion.

Signed-off-by: Masahiro Yamada 
Reviewed-by: Marek Vasut 
Signed-off-by: Boris Brezillon

mtd: use min_t() to refactor mtd_ooblayout_{get, set}_bytes()

2016-11-19T18:31:32+00:00

I hope this will make the code a little more readable.

Signed-off-by: Masahiro Yamada 
Reviewed-by: Marek Vasut 
Signed-off-by: Boris Brezillon

mtd: remove unneeded initializer in mtd_ooblayout_{get, set}_bytes()

2016-11-19T18:31:29+00:00

There is no need to initialize oobregion and section since they will
be filled by mtd_ooblayout_find_region().

Signed-off-by: Masahiro Yamada 
Reviewed-by: Marek Vasut 
Signed-off-by: Boris Brezillon