linux.git/drivers/mtd/lpddr, branch v6.7

mtd: lpddr2_nvm: Convert to platform remove callback returning void

2023-10-16T08:56:48+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Miquel Raynal 
Acked-by: Tudor Ambarus 
Link: https://lore.kernel.org/linux-mtd/20231008200143.196369-12-u.kleine-koenig@pengutronix.de

mtd: lpddr_cmds: Add literal suffix

2023-09-11T15:50:42+00:00

The value of an arithmetic expression
1 << lpddr->qinfo->DevSizeShift is subject to overflow
due to a failure to cast operands to a larger data
type before performing arithmetic

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Denis Arefev 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20230824130215.10396-1-arefev@swemel.ru

mtd: lpddr2_nvm: Convert to devm_platform_ioremap_resource()

2023-07-12T12:08:26+00:00

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by: Yangtao Li 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20230707040622.78174-15-frank.li@vivo.com

mtd: lpddr_cmds: remove unused words variable

2023-03-28T12:59:21+00:00

clang with W=1 reports
drivers/mtd/lpddr/lpddr_cmds.c:409:31: error: variable
  'words' set but not used [-Werror,-Wunused-but-set-variable]
        int ret, wbufsize, word_gap, words;
                                     ^
This variable is not used so remove it.

Signed-off-by: Tom Rix 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20230328000620.1778033-1-trix@redhat.com

mtd: lpddr2_nvm: Fix possible null-ptr-deref

2022-11-17T20:59:03+00:00

It will cause null-ptr-deref when resource_size(add_range) invoked,
if platform_get_resource() returns NULL.

Fixes: 96ba9dd65788 ("mtd: lpddr: add driver for LPDDR2-NVM PCM memories")
Signed-off-by: Hui Tang 
Acked-by: Uwe Kleine-König 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20221114090240.244172-1-tanghui20@huawei.com

mtd: lpddr2_nvm: Warn about failure to unregister mtd device

2022-06-09T13:06:16+00:00

mtd_device_unregister() shouldn't fail. Wail loudly if it does anyhow.

This matches how other drivers (e.g. nand/raw/nandsim.c) use
mtd_device_unregister().

By returning 0 in the platform remove callback a generic error message
by the device core is suppressed, nothing else changes.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20220603210758.148493-6-u.kleine-koenig@pengutronix.de

mtd: lpddr: fix excessive stack usage with clang

2020-08-27T12:36:07+00:00

Building lpddr2_nvm with clang can result in a giant stack usage
in one function:

drivers/mtd/lpddr/lpddr2_nvm.c:399:12: error: stack frame size of 1144 bytes in function 'lpddr2_nvm_probe' [-Werror,-Wframe-larger-than=]

The problem is that clang decides to build a copy of the mtd_info
structure on the stack and then do a memcpy() into the actual version. It
shouldn't really do it that way, but it's not strictly a bug either.

As a workaround, use a static const version of the structure to assign
most of the members upfront and then only set the few members that
require runtime knowledge at probe time.

Fixes: 96ba9dd65788 ("mtd: lpddr: add driver for LPDDR2-NVM PCM memories")
Signed-off-by: Arnd Bergmann 
Reviewed-by: Nathan Chancellor 
Acked-by: Miquel Raynal 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20200505140136.263461-1-arnd@arndb.de

mtd: lpddr: Move function print_drs_error to lpddr_cmds.c

2020-08-27T12:14:46+00:00

Function print_drs_error is only used in drivers/mtd/lpddr/lpddr_cmds.c
so, better to move it there.

Also, notice that there's no need for inline as the function is used
once.  Lastly, fix the following checkpatch warning:

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
+static void print_drs_error(unsigned dsr)

Suggested-by: Joe Perches 
Signed-off-by: Gustavo A. R. Silva 
Reviewed-by: Miquel Raynal 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/e0063cbd65f3b47be1db34efc494ea3047634d88.1588016644.git.gustavo@embeddedor.com

mtd: Convert fallthrough comments into statements

2020-03-30T08:14:54+00:00

Use Joe Perches cvt_fallthrough.pl script to convert

	/* fallthrough */

comments (and its derivatives) into a

	fallthrough;

statement. This automatically drops useless ones.

Do it MTD-wide.

Signed-off-by: Miquel Raynal 
Acked-by: Vignesh Raghavendra 
Acked-by: Tudor Ambarus 
Acked-by: Richard Weinberger 
Link: https://lore.kernel.org/linux-mtd/20200325212115.14170-1-miquel.raynal@bootlin.com

mtd: lpddr: Fix a double free in probe()

2020-03-11T13:49:30+00:00

This function is only called from lpddr_probe().  We free "lpddr" both
here and in the caller, so it's a double free.  The best place to free
"lpddr" is in lpddr_probe() so let's delete this one.

Fixes: 8dc004395d5e ("[MTD] LPDDR qinfo probing.")
Signed-off-by: Dan Carpenter 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20200228092554.o57igp3nqhyvf66t@kili.mountain