linux.git/drivers/mmc, branch v2.6.39

drivercore: revert addition of of_match to struct device

2011-05-18T18:32:23+00:00

Commit b826291c, "drivercore/dt: add a match table pointer to struct
device" added an of_match pointer to struct device to cache the
of_match_table entry discovered at driver match time.  This was unsafe
because matching is not an atomic operation with probing a driver.  If
two or more drivers are attempted to be matched to a driver at the
same time, then the cached matching entry pointer could get
overwritten.

This patch reverts the of_match cache pointer and reworks all users to
call of_match_device() directly instead.

Signed-off-by: Grant Likely

Revert "mmc: fix a race between card-detect rescan and clock-gate work instances"

2011-05-16T15:32:26+00:00

This reverts commit 26fc8775b51484d8c0a671198639c6d5ae60533e, which has
been reported to cause boot/resume-time crashes for some users:

https://bbs.archlinux.org/viewtopic.php?id=118751.

Signed-off-by: Chris Ball 
Cc:

mmc: sdhci: Check mrq != NULL in sdhci_tasklet_finish

2011-04-27T23:16:50+00:00

It seems that under certain circumstances the sdhci_tasklet_finish()
call can be entered with mrq set to NULL, causing the system to crash
with a NULL pointer de-reference.

Seen on S3C6410 system.  Based on a patch by Dimitris Papastamos.

Reported-by: Dimitris Papastamos 
Cc: 
Signed-off-by: Chris Ball

mmc: sdhci: Check mrq->cmd in sdhci_tasklet_finish

2011-04-27T23:16:45+00:00

It seems that under certain circumstances that the sdhci_tasklet_finish()
call can be entered with mrq->cmd set to NULL, causing the system to crash
with a NULL pointer de-reference.

Unable to handle kernel NULL pointer dereference at virtual address 00000000
PC is at sdhci_tasklet_finish+0x34/0xe8
LR is at sdhci_tasklet_finish+0x24/0xe8

Seen on S3C6410 system.

Signed-off-by: Ben Dooks 
Signed-off-by: Mark Brown 
Cc: 
Signed-off-by: Chris Ball

mmc: tmio: fix .set_ios(MMC_POWER_UP) handling

2011-04-27T23:16:29+00:00

The aggressive clock gating for TMIO MMC patch has broken switching
interface power on, using MFD or platform callbacks. Restore the
ios->power_mode == MMC_POWER_UP && ios->clock == 0 case handling.

Signed-off-by: Guennadi Liakhovetski 
Signed-off-by: Chris Ball

mmc: fix a race between card-detect rescan and clock-gate work instances

2011-04-27T23:16:12+00:00

Currently there is a race in the MMC core between a card-detect
rescan work and the clock-gating work, scheduled from a command
completion. Fix it by removing the dedicated clock-gating mutex
and using the MMC standard locking mechanism instead.

Signed-off-by: Guennadi Liakhovetski 
Cc: Simon Horman 
Cc: Magnus Damm 
Acked-by: Linus Walleij 
Cc: 
Signed-off-by: Chris Ball

mmc: omap: Fix possible NULL pointer deref

2011-04-27T23:15:12+00:00

Either OMAP_MMC_STAT_CARD_ERR or OMAP_MMC_STAT_END_OF_CMD might fire
if there is no host->cmd pointer.

Check for a valid host->cmd pointer before calling mmc_omap_cmd_done().

Signed-off-by: Michael Buesch 
Acked-by: Tony Lindgren 
Signed-off-by: Chris Ball

mmc: core: mmc_add_card(): fix missing break in switch statement

2011-04-27T23:15:07+00:00

Fixes a cosmetic bug that affects printk() for SD-combo cards.

Reported-by: Prashanth Bhat 
Signed-off-by: Michał Mirosław 
Signed-off-by: Chris Ball

mmc: sdhci-pci: Fix error case in sdhci_pci_probe_slot()

2011-04-27T23:14:55+00:00

If pci_ioremap_bar() fails during probe, we "goto release;" and free the
host, but then we return 0 -- which tells sdhci_pci_probe() that the probe
succeeded.  Since we think the probe succeeded, when we unload sdhci we'll
go to sdhci_pci_remove_slot() and it will try to dereference slot->host,
which is now NULL because we freed it in the error path earlier.

The patch simply sets ret appropriately, so that sdhci_pci_probe() will
detect the failure immediately and bail out.

Signed-off-by: Chris Ball 
Cc:

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi