linux.git/drivers/mmc/core, branch v3.4-rc2

mmc: use really long write timeout to deal with crappy cards

2012-04-06T00:32:34+00:00

Several people have noticed that crappy SD cards take much longer to
complete multiple block writes than the 300ms that Linux specifies.
Try to work around this by using a three second write timeout instead.

This is a generalized version of a patch from Chase Maupin
, whose patch description said:

* With certain SD cards timeouts like the following have been seen
  due to an improper calculation of the dto value:
    mmcblk0: error -110 transferring data, sector 4126233, nr 8,
    card status 0xc00
* By removing the dto calculation and setting the timeout value
  to the maximum specified by the SD card specification part A2
  section 2.2.15 these timeouts can be avoided.
* This change has been used by beagleboard users as well as the
  Texas Instruments SDK without a negative impact.
* There are multiple discussion threads about this but the most
  relevant ones are:
    * http://talk.maemo.org/showthread.php?p=1000707#post1000707
    * http://www.mail-archive.com/linux-omap@vger.kernel.org/msg42213.html
* Original proposal for this fix was done by Sukumar Ghoral of
  Texas Instruments
* Tested using a Texas Instruments AM335x EVM

Signed-off-by: Paul Walmsley 
Tested-by: Tony Lindgren 
Signed-off-by: Chris Ball

mmc: core: fix power class selection

2012-04-06T00:32:31+00:00

mmc_select_powerclass() function returns error if eMMC
VDD level supported by host is between 2.7v to 3.2v.

According to eMMC specification, valid voltage for high
voltage cards is 2.7v to 3.6v. This patch ensures that
2.7v to 3.6v VDD range is treated as valid range.

Also, failure to set the power class shouldn't be treated
as fatal error because even if setting the power class
fails, card can still work in default power class.
If mmc_select_powerclass() returns error, just print
the warning message and go ahead with rest of the card
initialization.

Signed-off-by: Subhash Jadavani 
Acked-by: Girish K S 
Reviewed-by: Namjae Jeon 
Signed-off-by: Chris Ball

mmc: sdio: Use empty system suspend/resume callbacks at the bus level

2012-04-06T00:32:26+00:00

Neil Brown reports that commit 35cd133c

   PM: Run the driver callback directly if the subsystem one is not there

breaks suspend for his libertas wifi, because SDIO has a protocol
where the suspend method can return -ENOSYS and this means "There is
no point in suspending, just turn me off".  Moreover, the suspend
methods provided by SDIO drivers are not supposed to be called by
the PM core or bus-level suspend routines (which aren't presend for
SDIO).  Instead, when the SDIO core gets to suspend the device's
ancestor, it calls the device driver's suspend function, catches the
ENOSYS, and turns the device off.

The commit above breaks the SDIO core's assumption that the device
drivers' callbacks won't be executed if it doesn't provide any
bus-level callbacks.  If fact, however, this assumption has never
been really satisfied, because device class or device type suspend
might very well use the driver's callback even without that commit.

The simplest way to address this problem is to make the SDIO core
tell the PM core to ignore driver callbacks, for example by providing
no-operation suspend/resume callbacks at the bus level for it,
which is implemented by this change.

Reported-and-tested-by: Neil Brown 
Signed-off-by: Rafael J. Wysocki 
[stable: please apply to 3.3-stable only]
Cc: 
Signed-off-by: Chris Ball

mmc: bus: print bus speed mode of UHS-I card

2012-04-06T00:32:26+00:00

When UHS-I card is detected also print the bus speed mode in which
UHS-I card will be running.

Signed-off-by: Subhash Jadavani 
Reviewed-by: Namjae Jeon 
Acked-by: Aaron Lu 
Signed-off-by: Chris Ball

mmc: simplify mmc_cd_gpio_request() by removing two parameters

2012-03-27T16:20:14+00:00

Calculate the IRQ number, using gpio_to_irq() and use fixed flags: trigger
on both edges. This makes two out of four arguments of the
mmc_cd_gpio_request() function redundant.

Signed-off-by: Guennadi Liakhovetski 
Signed-off-by: Chris Ball

mmc: core: warn when card doesn't support HPI

2012-03-27T16:20:12+00:00

Someone could use send_hpi_cmd() on a card that doesn't advertise support
for HPI.  Then maybe didn't work fine.  Because card->ext_csd.hpi_cmd
didn't set.  So if card didn't support hpi, return the warning message.

And CMD12's flags is MMC_RSP_R1B.

Signed-off-by: Jaehoon Chung 
Signed-off-by: Kyungmin Park 
Signed-off-by: Chris Ball

mmc: core: add high-capacity erase size capability flag

2012-03-27T16:20:07+00:00

Let drivers specify the use of high-capacity erase size.

Signed-off-by: Adrian Hunter 
Signed-off-by: Chris Ball

mmc: core: hs200 fixes

2012-03-27T16:20:05+00:00

This patch fixes following issues when HS200 is enabled:

1. If executing_tuning() host ops is called without mmc_host_clk_hold(),
   card clocks might get turned off (if MMC_CLK_GATING is enabled)
   while execute_tuning() is in progress. So this patch makes sure
   that execute_tuning() is called with mmc_host_clk_hold().

2. If host timing mode is set to HS200 mode, there should not be
   any communication with the card until execute_tuning() is completed.
   But there is a chance that CMD6 might be sent to enable set HPI_EN
   (of HPI_MGMT field in EXT_CSD) before execute_tuning() is called.
   So this patch moves this operation after execute_tuning() is completed.

Signed-off-by: Subhash Jadavani 
Reviewed-by: girish.shivananjappa@linaro.org
Signed-off-by: Chris Ball

mmc: core: Clean up after mmc_pre_req if card was removed

2012-03-27T16:20:04+00:00

Make sure mmc_start_req cancels the prepared job, if the request
was prevented to be started due to the card has been removed.

This bug was introduced in commit:
mmc: allow upper layers to know immediately if card has been removed

Signed-off-by: Ulf Hansson 
Reviewed-by: Per Forlin 
Tested-by: Jaehoon Chung 
Signed-off-by: Chris Ball

mmc: start removing enable / disable API

2012-03-27T16:20:03+00:00

Most parts of the enable / disable API are no longer used and
can be removed.

Signed-off-by: Adrian Hunter 
Tested-by: Venkatraman S 
Tested-by: Jaehoon Chung 
Signed-off-by: Chris Ball