linux.git/drivers/mmc/core/sd.c, branch v4.13

mmc: core: Re-factor code for sending CID

2017-06-20T08:30:45+00:00

Instead of having the caller to check for SPI mode, let's leave that to
internals of mmc_send_cid(). In this way the code gets cleaner and it
becomes clear what is specific to SPI and non-SPI mode.

Signed-off-by: Ulf Hansson 
Reviewed-by: Linus Walleij 
Reviewed-by: Shawn Lin

mmc: core: Delete error messages for failed memory allocations

2017-06-20T08:30:21+00:00

Omit an extra message for memory allocation failures.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring 
Signed-off-by: Ulf Hansson

mmc: core: add proper be32 annotation

2017-04-24T19:42:19+00:00

Annotate big endian values correctly and make sparse happy.
In mmc_app_send_scr remove scr function parameter as it was
updating card->raw_scr anyway.

Signed-off-by: Tomas Winkler 
Signed-off-by: Ulf Hansson

mmc: core: Clarify usage of mmc_set_signal_voltage()

2017-02-13T12:20:43+00:00

The mmc_set_signal_voltage() function is used for SD/SDIO when switching to
1.8V for UHS mode. To clarify this let's do the following changes.

- We are always providing MMC_SIGNAL_VOLTAGE_180 as the signal_voltage
  parameter to the function. Then, let's just remove the parameter as it
  serves no purpose.
- Rename the function to mmc_set_uhs_voltage().

Signed-off-by: Ulf Hansson 
Reviewed-by: Shawn Lin 
Tested-by: Jan Glauber 
Tested-by: Stefan Wahren

mmc: core: Move public functions from host.h to private headers

2017-02-13T12:20:25+00:00

A significant amount of functions are available through the public mmc
host.h header file. Let's slim down this public mmc interface, as to
prevent users from abusing it, by moving some of the functions to private
mmc host.h header file.

This change concentrates on moving the functions into private mmc headers,
following changes may continue with additional clean-ups.

Signed-off-by: Ulf Hansson 
Reviewed-by: Linus Walleij 
Reviewed-by: Shawn Lin

mmc: core: Move public functions from card.h to private headers

2017-02-13T12:20:24+00:00

A significant amount of functions and other definitions are available
through the public mmc card.h header file. Let's slim down this public mmc
interface, as to prevent users from abusing it, by moving some of the
functions/definitions to private mmc header files.

This change concentrates on moving the functions into private mmc headers,
following changes may continue with additional clean-ups.

Signed-off-by: Ulf Hansson 
Reviewed-by: Linus Walleij 
Reviewed-by: Shawn Lin

mmc: sd: Meet alignment requirements for raw_ssr DMA

2016-12-21T07:34:30+00:00

The mmc_read_ssr() function results in DMA to the raw_ssr member of
struct mmc_card, which is not guaranteed to be cache line aligned & thus
might not meet the requirements set out in Documentation/DMA-API.txt:

  Warnings:  Memory coherency operates at a granularity called the cache
  line width.  In order for memory mapped by this API to operate
  correctly, the mapped region must begin exactly on a cache line
  boundary and end exactly on one (to prevent two separately mapped
  regions from sharing a single cache line).  Since the cache line size
  may not be known at compile time, the API will not enforce this
  requirement.  Therefore, it is recommended that driver writers who
  don't take special care to determine the cache line size at run time
  only map virtual regions that begin and end on page boundaries (which
  are guaranteed also to be cache line boundaries).

On some systems where DMA is non-coherent this can lead to us losing
data that shares cache lines with the raw_ssr array.

Fix this by kmalloc'ing a temporary buffer to perform DMA into. kmalloc
will ensure the buffer is suitably aligned, allowing the DMA to be
performed without any loss of data.

Signed-off-by: Paul Burton 
Fixes: 5275a652d296 ("mmc: sd: Export SD Status via “ssr” device attribute")
Cc: 
Signed-off-by: Ulf Hansson

mmc: core: remove BUG_ONs from sd

2016-12-05T09:31:10+00:00

BUG_ONs doesn't help anything except for stop the system from
running. If it occurs, it implies we should deploy proper error
handling for that. So this patch is gonna discard these meaningless
BUG_ONs and deploy error handling if needed.

Signed-off-by: Shawn Lin 
Signed-off-by: Ulf Hansson

mmc: sd: Export SD Status via “ssr” device attribute

2016-09-26T19:31:09+00:00

The SD Status register contains several important fields related to the
SD Card proprietary features.
Those fields may be used by user space applications for vendor specific
usage.
None of those fields are exported today by the driver to user space.
In this patch, we are reading the SD Status register and exporting
(using MMC_DEV_ATTR) the SD Status register to the user space.

Signed-off-by: Uri Yanai 
Signed-off-by: Ulf Hansson

mmc: core: Extend sysfs with DSR register

2016-07-25T08:34:51+00:00

Export DSR register through sysfs same as we did for the CID, CSD and
OCR registers.

Signed-off-by: Bojan Prtvar 
Signed-off-by: Ulf Hansson