linux.git/drivers/mmc/core/core.c, branch v3.17

mmc: Do not advertise secure discard if it is blacklisted

2014-07-26T09:13:39+00:00

Currently when the device secure discard implementation is
blacklisted (MMC_QUIRK_SEC_ERASE_TRIM_BROKEN quirk is set)
instead of secure discard we're going to do normal discard,
which is wrong.

When the secure discard is known to be broken we should just
disallow it entirely and not advertise this functionality to
the user. Fix it.

Also move mmc_fixup_device() in from of mmc_blk_alloc() so we
can get quirks set before we attempt to set queue information.

Signed-off-by: Lukas Czerner 
Acked-by: Jaehoon Chung 
Signed-off-by: Ulf Hansson

mmc: core: Improve support for deferred regulators

2014-05-12T22:08:24+00:00

Callers of mmc_regulator_get_supply could benefit from knowing if either
of the regulators are present but not yet available.  Since callers do
not currently examine the return value, modify this function to return
zero or -EPROBE_DEFER if either regulator get returns the same.

Furthermore, since callers check vmmc/vqmmc using IS_ERR and can deal
with absent regulators, switch to devm_regulator_get_optional. This has
the added benefit of allowing this function to behave correctly even in
the !CONFIG_REGULATOR case such that the stub can be removed.

Signed-off-by: Tim Kryger 
Signed-off-by: Ulf Hansson 
Signed-off-by: Chris Ball

mmc: drop the speed mode of card's state

2014-05-12T22:05:53+00:00

Timing mode identifier has same role and can take the place
of speed mode. This change removes all related speed mode.

Signed-off-by: Seungwon Jeon 
Tested-by: Jaehoon Chung 
Acked-by: Jaehoon Chung 
Signed-off-by: Ulf Hansson 
Signed-off-by: Chris Ball

mmc: core: Try other signal levels during power up

2014-05-12T22:05:22+00:00

The eMMC signalling voltage is determined by VCCQ which is provided to
the card by the host.  Signalling is not required to begin at 3.3v and,
if the host and card both support a particular VCC/VCCQ combination, it
can be used immediately.

In contrast, SD Cards must begin with 3.3v signalling and may switch to
a lower voltage signalling if instructed to do so in CMD11.  A message
is required to coordinate this operation because the card only receives
a 3.3v VDD and must know when to use the 1.8v produced by its internal
regulator.

It makes sense for the core to begin with 3.3v signalling but when that
can't be set, 1.8v and 1.2v signalling also should be attempted.  This
is especially important when an external regulator with a limited range
is used to supply VCCQ to an eMMC part.

Signed-off-by: Tim Kryger 
Signed-off-by: Ulf Hansson 
Signed-off-by: Chris Ball

mmc: core: Use maximum timeout values in case TACC field is zero

2014-04-22T11:06:39+00:00

When plugging a specific micro SD card at MMC socket of a custom i.MX28 board,
we get the following kernel warning:

WARNING: CPU: 0 PID: 30 at drivers/mmc/host/mxs-mmc.c:342 mxs_mmc_start_cmd+0x34c/0x378()
Modules linked in:
CPU: 0 PID: 30 Comm: kworker/u2:1 Not tainted 3.14.0-rc5 #8
Workqueue: kmmcd mmc_rescan
[] (unwind_backtrace) from [] (show_stack+0x10/0x14)
[] (show_stack) from [] (warn_slowpath_common+0x6c/0x8c)
[] (warn_slowpath_common) from [] (warn_slowpath_null+0x1c/0x24)
[] (warn_slowpath_null) from [] (mxs_mmc_start_cmd+0x34c/0x378)
[] (mxs_mmc_start_cmd) from [] (mmc_start_request+0xc4/0xf4)
[] (mmc_start_request) from [] (mmc_wait_for_req+0x50/0x164)
[] (mmc_wait_for_req) from [] (mmc_app_send_scr+0x158/0x1c8)
[] (mmc_app_send_scr) from [] (mmc_sd_setup_card+0x80/0x3c8)
[] (mmc_sd_setup_card) from [] (mmc_sd_init_card+0x124/0x66c)
[] (mmc_sd_init_card) from [] (mmc_attach_sd+0xac/0x174)
[] (mmc_attach_sd) from [] (mmc_rescan+0x25c/0x2d8)
[] (mmc_rescan) from [] (process_one_work+0x1b4/0x4ec)
[] (process_one_work) from [] (worker_thread+0x130/0x464)
[] (worker_thread) from [] (kthread+0xb4/0xd0)
[] (kthread) from [] (ret_from_fork+0x14/0x34)

The error is due to an invalid value in CSD register of a specific 2GB
micro SD card. The CSD version of this card is 1.0 but the TACC field
has the invalid value 0.

cid:0000005553442020000000000000583f
csd:00000032535a83bfedb7ffbf1680003f
date:08/2005
erase_size:512
fwrev:0x0
hwrev:0x0
manfid:0x000000
name:USD
oemid:0x0000
preferred_erase_size:4194304
scr:0225000000000000
serial:0x00000000
type:SD

Since the kernel is making use of this TACC field to calculate the SD
card timeout, an invalid value 0 leads to a warning at
mxs_ns_to_ssp_ticks() and later the following misleading error message
appears in a loop:

mxs-mmc 80010000.ssp: card claims to support voltages below defined range
mxs-mmc 80010000.ssp: no support for card's volts
mmc0: error -22 whilst initialising MMC card

This error is only found on this 2GB SD card on mxs platform.
On x86 this card works without any problems.

The following patch based on the work of Peter Chan and Otavio Salvador.
It catches the case that the determined timeout is still 0 and sets it
to a valid value.

Successful tested on a i.MX28 board.

Signed-off-by: Stefan Wahren 
Signed-off-by: Ulf Hansson 
Signed-off-by: Chris Ball

mmc: Delay the card_event callback into the mmc_rescan worker

2014-04-22T11:06:36+00:00

This change removes the callback from atomic context which it doesn't
need to be in, and puts it in line with the debounced rescan.

This code is based on these e-mail threads with Christian Daudt:

  https://lkml.org/lkml/2013/8/19/539
  https://lkml.org/lkml/2014/3/19/79

Signed-off-by: Markus Mayer 
Signed-off-by: Ulf Hansson 
Signed-off-by: Chris Ball

mmc: slot-gpio: Add GPIO descriptor based CD GPIO API

2014-03-17T13:12:00+00:00

Add functions to request a CD GPIO using the GPIO descriptor API.
Note that the new request function is paired with mmc_gpiod_free_cd()
not mmc_gpio_free_cd().  Note also that it must be called prior to
mmc_add_host() otherwise the caller must also call
mmc_gpiod_request_cd_irq().

Signed-off-by: Adrian Hunter 
Reviewed-by: Linus Walleij 
Signed-off-by: Chris Ball

mmc: core: Add ignore_crc flag to __mmc_switch

2014-02-23T15:40:30+00:00

Instead of handle specific adaptations, releated to certain switch
operations, inside __mmc_switch, push this to be handled by the caller
instead.

Signed-off-by: Ulf Hansson 
Signed-off-by: Chris Ball

mmc: core: Rename cmd_timeout_ms to busy_timeout

2014-02-23T15:40:26+00:00

To better reflect that the cmd_timeout_ms is directly related to the
busy detection timeout, let's rename it.

Signed-off-by: Ulf Hansson 
Signed-off-by: Chris Ball

mmc: core: Rename max_discard_to to max_busy_timeout

2014-02-23T15:40:08+00:00

Rename host->max_discard_to to host->max_busy_timeout, to reflect that
it tells the mmc core layer about the maximum supported busy detection
timeout by the host.

This timeout is at the moment only applicable to erase/trim/discard
commands. By the renaming we provide the option of make use of it for
other commands that cares about busy detection. In other words, those
commands that wants an R1B response, like for example the mmc switch
command.

Do note that the max_busy_timeout is supposed to be specified only by
hosts supporting MMC_CAP_WAIT_WHILE_BUSY.

Signed-off-by: Ulf Hansson 
Signed-off-by: Chris Ball