linux.git/drivers/misc/mei/client.c, branch v3.13

mei: mei_cl_link remove duplicated check for open_handle_count

2013-10-29T23:20:43+00:00

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

mei: move host_clients_map cleanup to device init

2013-10-20T02:53:46+00:00

Move host_clients_map cleanup from host client init to device init.

This fixes bug where we cleaned up the bitmask that servers as pool for
host client ids while file descriptors are kept open during suspend.
On resume a new connection will be assigned id that is already taken
by opened file descriptor. Consequently read/write will fail due to
mismatched book keeping.

Signed-off-by: Alexander Usyskin 
Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

mei: revamp open handler counts

2013-10-03T23:01:16+00:00

Make open counter to be incremented and decremented
from mei_cl_link and mei_cl_unlik function respectively

Nfc was assuming symmetric linking API and thus open handler
count was never decreased. This patch fixes that.
We need to add separate open hander count for amthif which
is handled out of link/unlink functions and doesn't break
the symmetric API.

Last we do not waste clients slots if amthif or wd are not present
in the device. we don't need to allocates slots ahead
it is all covered by link/unlink before the devices is responding
to user space connection and thus not racing on allocation

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

mei: simplify mei_open error handling

2013-10-03T23:00:52+00:00

1. Perform simple checks first and only then attempt to allocate cl structure.
2. Remove open_handler_count test, this is already checked in mei_cl_link function
3. return -EMFILE instead of -ENOENT as expected by user space

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

mei: mei_cl_unlink: no need to loop over dev list

2013-09-26T15:42:44+00:00

we can call list_del_init regardless the client is
linked or not it is always properly initialized

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

mei: push credentials inside the irq write handler

2013-09-26T15:42:02+00:00

this eventually allows as use a single write queue
both for control and data messages and removing possible
race

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

mei: propagate error from write routines instead of ENODEV

2013-09-26T15:42:02+00:00

ENODEV will cause application to try to reconnect since
it assumes that device went through the reset
write errors are not always fatal it can happen due to
resource contention

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

mei: prefix client log messages with client me and host ids

2013-09-26T15:39:27+00:00

define cl_dbg and cl_err macros that add me and host id
prefix for debug and error log messages so we can track
for the client context of the flow.

Signed-off-by: Alexander Usyskin 
Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

mei: mei_cl_link protect open_handle_count from overflow

2013-09-26T15:23:00+00:00

mei_cl_link is called both from mei_open and also from
in-kernel drivers so we need to protect open_handle_count
from overflow

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

mei: don't get stuck in select during reset

2013-07-27T00:54:30+00:00

Clear pending connection after hw reset but before hw start
and wake up the waiting task in poll. Signal POLLERR in select
when device went through reset.

Add wrapper mei_cl_is_connected for checking if
the device and client are connected.

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman