linux.git/drivers/mfd/max77693.c, branch v3.15

mfd: max77693: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-03-19T08:58:12+00:00

During probe the driver allocates dummy I2C devices for MUIC and haptic
with i2c_new_dummy() but it does not check the return value of this
calls.

In case of error (i2c_new_device(): memory allocation failure or I2C
address cannot be used) this function returns NULL which is later used
by devm_regmap_init_i2c() and i2c_unregister_device().

If i2c_new_dummy() fails for MUIC or haptic devices, fail also the probe
for main MFD driver.

Cc: stable@vger.kernel.org
Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones

mfd: max77693: Set proper maximum register for MUIC regmap

2014-01-21T08:28:13+00:00

The MUIC block in max77693 has different I2C address than PMIC. The
driver allocated two regmaps: for PMIC and MUIC. However it used the
same regmap_config (with max_register field) for both regmaps. Actual
maximum address of register for MUIC is different than for PMIC.

Define another regmap_config for MUIC with proper max_register value.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones

mfd: maxim: Constify struct mfd_cell where possible

2014-01-06T09:13:27+00:00

As of commit 03e361b25ee8dfb1fd9b890072c23c4aae01c6c7 ("mfd: Stop setting
refcounting pointers in original mfd_cell arrays"), the "cell" parameter of
mfd_add_devices() is "const" again. Hence make all cell data passed to
mfd_add_devices() const where possible.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Lee Jones

mfd: max77693: Include linux/of.h header

2013-10-23T15:22:30+00:00

'of_match_ptr' is defined in linux/of.h. Include it explicitly to
avoid build breakage in the future.

Signed-off-by: Sachin Kamat 
Signed-off-by: Lee Jones

mfd: max77693: Added device tree support

2013-10-23T15:21:29+00:00

This patch adds only of_match_table. There are no device specific
properties.

Reviewed-by: Sylwester Nawrocki 
Signed-off-by: Andrzej Hajda 
Signed-off-by: Kyungmin Park 
Signed-off-by: Lee Jones

mfd: max77693: Remove device wakeup from driver

2013-10-23T15:21:26+00:00

The patch removes wakeup related code from the driver and plaftorm
data - it is already handled by i2c core using I2C_CLIENT_WAKE flag
from struct i2c_board_info. As a result MFD itself do not requires
platform data.

Signed-off-by: Andrzej Hajda 
Signed-off-by: Kyungmin Park 
Signed-off-by: Lee Jones

mfd: Use dev_get_platdata()

2013-07-31T12:01:29+00:00

Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly.

Signed-off-by: Jingoo Han 
Signed-off-by: Lee Jones

mfd: max77693: Init max77693->dev before using it

2013-01-22T02:02:22+00:00

Current code uses max77693->dev in the dev_err call before setting it to
&i2c->dev. Fix it.

This patch also includes below cleanups:
 - Move checking pdata earlier and show dev_err if no platform data found.
 - Remove unnecessary err_regmap goto label.
 - Unregister i2c devices if regmap init for muic fails.

Signed-off-by: Axel Lin 
Signed-off-by: Samuel Ortiz

mfd: MAX77693: Fix NULL pointer error when initializing irqs

2012-09-15T22:33:09+00:00

This patch initialize register map of MUIC device because mfd driver
of Maxim MAX77693 use regmap-muic instance of MUIC device when irqs of
Maxim MAX77693 is initialized before call max77693-muic probe() function.

Signed-off-by: Chanwoo Choi 
Signed-off-by: Myungjoo Ham 
Signed-off-by: Kyungmin Park 
Reported-by: Sylwester Nawrocki 
Acked-by: Greg Kroah-Hartman 
Signed-off-by: Samuel Ortiz

mfd: core: Push irqdomain mapping out into devices

2012-09-15T21:22:04+00:00

Currently the MFD core supports remapping MFD cell interrupts using an
irqdomain but only if the MFD is being instantiated using device tree
and only if the device tree bindings use the pattern of registering IPs
in the device tree with compatible properties.  This will be actively
harmful for drivers which support non-DT platforms and use this pattern
for their DT bindings as it will mean that the core will silently change
remapping behaviour and it is also limiting for drivers which don't do
DT with this particular pattern.  There is also a potential fragility if
there are interrupts not associated with MFD cells and all the cells are
omitted from the device tree for some reason.

Instead change the code to take an IRQ domain as an optional argument,
allowing drivers to take the decision about the parent domain for their
interrupts.  The one current user of this feature is ab8500-core, it has
the domain lookup pushed out into the driver.

Signed-off-by: Mark Brown 
Signed-off-by: Samuel Ortiz