linux.git/drivers/mfd/ipaq-micro.c, branch for-next

mfd: ipaq-micro: Add missing break for the default case

2024-10-31T14:59:40+00:00

Even default case should have a break statement to make code robust
against changes (e.g., adding a case after the default one).

Add missing break for the default case.

Signed-off-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20241016130023.872277-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Lee Jones

mfd: ipaq-micro: Remove unused variable i in micro_rx_msg()

2023-08-22T07:07:50+00:00

There is a warning reported by kernel test robot:

drivers/mfd/ipaq-micro.c:81:6: warning: unused variable ‘i’ [-Wunused-variable]

Since the commit 92d82d76c842 ("mfd: ipaq-micro: Use %*ph for printing
hexdump of a small buffer"), the variable 'i' is unused. Remove it to
silence the warning.

Reported-by: kernelci.org bot 
Closes: https://lore.kernel.org/all/64c8aeac.170a0220.e3234.2745@mx.google.com/
Signed-off-by: Li Zetao 
Link: https://lore.kernel.org/r/20230817114505.1810920-1-lizetao1@huawei.com
Signed-off-by: Lee Jones

mfd: ipaq-micro: Use %*ph for printing hexdump of a small buffer

2023-08-18T20:47:59+00:00

The kernel already has a helper to print a hexdump of a small
buffer via pointer extension. Use that instead of open coded
variant.

In long term it helps to kill pr_cont() or at least narrow down
its use.

Signed-off-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20230703140923.2840-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Lee Jones

mfd: ipaq-micro: Use devm_platform_get_and_ioremap_resource()

2023-04-26T10:40:27+00:00

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Ye Xingchen 
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/202302081733542304522@zte.com.cn

mfd: ipaq-micro: Fix error check return value of platform_get_irq()

2022-04-26T14:12:22+00:00

platform_get_irq() return negative value on failure, so null check of
irq is incorrect. Fix it by comparing whether it is less than zero.

Fixes: dcc21cc09e3c ("mfd: Add driver for Atmel Microcontroller on iPaq h3xxx")
Reported-by: Zeal Robot 
Signed-off-by: Lv Ruyi 
Reviewed-by: Linus Walleij 
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/20220412085305.2533030-1-lv.ruyi@zte.com.cn

mfd: ipaq-micro: Use devm_platform_ioremap_resource() in micro_probe()

2019-11-11T08:45:01+00:00

Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Lee Jones

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

2019-06-19T15:09:55+00:00

Based on 2 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license version 2 as
  published by the free software foundation

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license version 2 as
  published by the free software foundation #

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 4122 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Enrico Weigelt 
Reviewed-by: Kate Stewart 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.de
Signed-off-by: Greg Kroah-Hartman

mfd: ipaq-micro: Dump debugging hexdumps

2017-07-06T07:29:11+00:00

These hexdumps get printed no matter if CONFIG_DEBUG is set or
not. Just get rid of them.

Signed-off-by: Linus Walleij 
Signed-off-by: Lee Jones

mfd: ipaq-micro: Delete redundant return value check of platform_get_resource()

2017-04-27T08:25:05+00:00

devm_ioremap_resource does checks on the resource. No need to
duplicate this in the driver.

Signed-off-by: Belén Sarabia 
Signed-off-by: Lee Jones

mfd: ipaq-micro: Use __maybe_unused to hide pm functions

2016-03-16T08:50:41+00:00

The ipaq-micro driver uses SET_SYSTEM_SLEEP_PM_OPS() to
remove the reference to its resume function, but does
not use an #ifdef around the definition, so we get
a build warning:

drivers/mfd/ipaq-micro.c:379:12: error: 'micro_resume' defined but not used [-Werror=unused-function]

This adds a __maybe_unused annotation so the compiler knows
it can silently drop it instead of warning.

Signed-off-by: Arnd Bergmann 
Signed-off-by: Lee Jones