linux.git/drivers/message/fusion/mptfc.c, branch for-next

scsi: message: fusion: Constify struct pci_device_id

2024-11-21T02:38:24+00:00

'struct pci_device_id' is not modified in these drivers.

Constifying this structure moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig, as an example:
Before:
======
   text	   data	    bss	    dec	    hex	filename
  36999	   2451	     88	  39538	   9a72	drivers/message/fusion/mptfc.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
  37415	   2043	     88	  39546	   9a7a	drivers/message/fusion/mptfc.o

Signed-off-by: Christophe JAILLET 
Link: https://lore.kernel.org/r/fe8f17a999b6def2649b2ef52ea5c9ee61e28bd0.1731705152.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Martin K. Petersen

scsi: mptfusion: Simplify the alloc*_workqueue() invocations

2024-08-23T01:28:55+00:00

Let alloc*_workqueue() format the workqueue names instead of calling
snprintf() explicitly.

Signed-off-by: Bart Van Assche 
Link: https://lore.kernel.org/r/20240822195944.654691-3-bvanassche@acm.org
Signed-off-by: Martin K. Petersen

scsi: core: Add a dma_alignment field to the host and host template

2024-04-12T01:37:48+00:00

Get drivers out of the business of having to call the block layer DMA
alignment limits helpers themselves.

Signed-off-by: Christoph Hellwig 
Link: https://lore.kernel.org/r/20240409143748.980206-8-hch@lst.de
Reviewed-by: Bart Van Assche 
Reviewed-by: John Garry 
Reviewed-by: Damien Le Moal 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Acked-by: Greg Kroah-Hartman 
Signed-off-by: Martin K. Petersen

scsi: message: fusion: Remove redundant pointer 'hd'

2024-01-24T02:39:21+00:00

The pointer 'hd' is being assigned a value that is not being read
later. The variable is redundant and can be removed.

Cleans up clang scan build warning:

warning: Although the value stored to 'hd' is used in the enclosing
expression, the value is never actually read from 'hd'
[deadcode.DeadStores]

Signed-off-by: Colin Ian King 
Link: https://lore.kernel.org/r/20240118122039.2541425-1-colin.i.king@gmail.com
Signed-off-by: Martin K. Petersen

scsi: message: fusion: Initialize return value in mptfc_bus_reset()

2023-10-25T02:36:39+00:00

Detected by smatch.

Fixes: 17865dc2eccc ("scsi: message: fusion: Open-code mptfc_block_error_handler() for bus reset")
Reported-by: Dan Carpenter 
Signed-off-by: Hannes Reinecke 
Link: https://lore.kernel.org/r/20231023073005.20766-1-hare@suse.de
Reviewed-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi: message: fusion: Open-code mptfc_block_error_handler() for bus reset

2023-10-13T18:23:14+00:00

When calling bus_reset we have potentially several ports to be reset, so
this patch open-codes the existing mptfc_block_error_handler() to wait for
all ports attached to this bus.

Signed-off-by: Hannes Reinecke 
Link: https://lore.kernel.org/r/20231002154328.43718-4-hare@suse.de
Reviewed-by: Christoph Hellwig 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: message: fusion: Simplify mptfc_block_error_handler()

2023-10-13T18:23:14+00:00

Instead of passing in a function to mptfc_block_error_handler() we can as
well return a status and call the function afterwards.

Signed-off-by: Hannes Reinecke 
Link: https://lore.kernel.org/r/20231002154328.43718-2-hare@suse.de
Reviewed-by: Christoph Hellwig 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: message: fusion: Declare SCSI host template members const

2023-03-24T23:19:19+00:00

Make it explicit that the SCSI host templates are not modified.

Signed-off-by: Bart Van Assche 
Link: https://lore.kernel.org/r/20230322195515.1267197-8-bvanassche@acm.org
Signed-off-by: Martin K. Petersen

scsi: message: fusion: Switch to attribute groups

2021-10-17T01:45:53+00:00

struct device supports attribute groups directly but does not support
struct device_attribute directly. Hence switch to attribute groups.

Link: https://lore.kernel.org/r/20211012233558.4066756-6-bvanassche@acm.org
Signed-off-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: message: fusion: Call scsi_done() directly

2021-10-17T01:28:43+00:00

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-7-bvanassche@acm.org
Signed-off-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen