linux.git/drivers/memstick/core/ms_block.c, branch v4.9

memstick: don't allocate unused major for ms_block

2016-08-02T21:31:41+00:00

When alloc_disk(0) is used the ->major number is completely ignored.
All devices are allocated with a major of BLOCK_EXT_MAJOR.

So remove registration and deregistration of 'major'.

Link: http://lkml.kernel.org/r/20160602064318.4403.49955.stgit@noble
Signed-off-by: NeilBrown 
Cc: Keith Busch 
Cc: Jens Axboe 
Cc: Maxim Levitsky 
Cc: Greg Kroah-Hartman 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

memstick: don't allow REQ_TYPE_BLOCK_PC requests

2016-07-20T23:38:27+00:00

There is no code to issue or handle REQ_TYPE_BLOCK_PC request in the
memstick drivers, so remove the bogus conditional.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: convert to device_add_disk()

2016-06-27T19:26:08+00:00

For block drivers that specify a parent device, convert them to use
device_add_disk().

This conversion was done with the following semantic patch:

    @@
    struct gendisk *disk;
    expression E;
    @@

    - disk->driverfs_dev = E;
    ...
    - add_disk(disk);
    + device_add_disk(E, disk);

    @@
    struct gendisk *disk;
    expression E1, E2;
    @@

    - disk->driverfs_dev = E1;
    ...
    E2 = disk;
    ...
    - add_disk(E2);
    + device_add_disk(E1, E2);

...plus some manual fixups for a few missed conversions.

Cc: Jens Axboe 
Cc: Keith Busch 
Cc: Michael S. Tsirkin 
Cc: David Woodhouse 
Cc: David S. Miller 
Cc: James Bottomley 
Cc: Ross Zwisler 
Cc: Konrad Rzeszutek Wilk 
Cc: Martin K. Petersen 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Dan Williams

memstick: trivial fix of spelling mistake on management

2016-04-28T08:58:33+00:00

fix spelling mistake, managment -> management in literal
strings, in a variable and a macro.

Signed-off-by: Colin Ian King 
Signed-off-by: Jiri Kosina

memstick: use sector_div instead of do_div

2016-01-21T01:09:18+00:00

do_div is the wrong way to divide a sector_t, as it is less efficient
when sector_t is 32-bit wide.  With the upcoming do_div optimizations,
the kernel starts warning about this:

  drivers/memstick/core/ms_block.c: In function 'msb_io_work':
  include/asm-generic/div64.h:207:28: warning: comparison of distinct pointer types lacks a cast

This changes the code to use sector_div instead, which always produces
optimal code.

Signed-off-by: Arnd Bergmann 
Cc: Maxim Levitsky 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/memstick/core/ms_block.c: fix spelling of MSB_RP_RECIVE_STATUS_REG

2013-11-15T00:32:13+00:00

Cc: Maxim Levitsky 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/memstick/core/ms_block.c: fix unreachable state in h_msb_read_page()

2013-11-13T03:09:35+00:00

In h_msb_read_page() in ms_block.c, flow never reaches case
MSB_RP_RECIVE_STATUS_REG.  This causes error when MEMSTICK_INT_ERR is
encountered and status error bits are going to be examined, but the status
will never be copied back.

Fix it by transitioning to MSB_RP_RECIVE_STATUS_REG right after
MSB_RP_SEND_READ_STATUS_REG.

Signed-off-by: Roger Tseng 
Acked-by: Maxim Levitsky 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

memstick: add support for legacy memorysticks

2013-09-11T22:59:35+00:00

Based partially on MS standard spec quotes from Alex Dubov.

As any code that works with user data this driver isn't recommended to use
to write cards that contain valuable data.

It tries its best though to avoid data corruption and possible damage to
the card.

Tested on MS DUO 64 MB card on Ricoh R592 card reader.

Signed-off-by: Maxim Levitsky 
Cc: Valdis Kletnieks 
Cc: Jens Axboe 
Cc: Alex Dubov 
Cc: Tejun Heo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds