linux.git/drivers/media/usb, branch v6.8

media: videobuf2: core: Rename min_buffers_needed field in vb2_queue

2023-12-13T16:31:27+00:00

Rename min_buffers_needed into min_queued_buffers and update
the documentation about it.

Signed-off-by: Benjamin Gaignard 
Signed-off-by: Hans Verkuil 
[hverkuil: Drop the change where min_queued_buffers + 1 buffers would be]
[hverkuil: allocated. Now this patch only renames this field instead of making]
[hverkuil: a functional change as well.]
[hverkuil: Renamed 3 remaining min_buffers_needed occurrences.]

media: v4l2-subdev: Turn .[gs]_frame_interval into pad operations

2023-12-13T15:52:35+00:00

The subdev .[gs]_frame_interval are video operations, but they operate
on pads (and even on streams). Not only is this confusing, it causes
practical issues for drivers as the operations don't receive a subdev
state pointer, requiring manual state handling.

To improve the situation, turn the operations into pad operations, and
extend them to receive a state pointer like other pad operations.

While at it, rename the operations to .[gs]et_frame_interval at the same
time to match the naming scheme of other pad operations. This isn't
strictly necessary, but given that all drivers using those operations
need to be modified, handling the rename separately would generate more
churn for very little gain (if at all).

Signed-off-by: Laurent Pinchart 
Reviewed-by: Hans Verkuil 
Reviewed-by: Philipp Zabel  # for imx-media
Reviewed-by: Luca Ceresoli  # for tegra-video
Signed-off-by: Hans Verkuil

media: uvcvideo: Fix power line control for SunplusIT camera

2023-12-09T06:37:33+00:00

The device does not implement the power line frequency control
correctly. It is a UVC 1.5 device, but implements the control as a UVC
1.1 device.

Add the corresponding control mapping override.

Bus 003 Device 002: ID 2b7e:b752 SunplusIT Inc HD Camera
Device Descriptor:
  bLength                18
  bDescriptorType         1
  bcdUSB               2.01
  bDeviceClass          239 Miscellaneous Device
  bDeviceSubClass         2
  bDeviceProtocol         1 Interface Association
  bMaxPacketSize0        64
  idVendor           0x2b7e
  idProduct          0xb752
  bcdDevice            0.04
  iManufacturer           1 SunplusIT Inc
  iProduct                2 HD Camera
  iSerial                 3 01.00.00
  bNumConfigurations      1

Cc: Yunke Cao 
Signed-off-by: Ricardo Ribalda 
Signed-off-by: Laurent Pinchart 
Signed-off-by: Mauro Carvalho Chehab

media: uvcvideo: Pick first best alternate setting insteed of last

2023-12-09T06:36:47+00:00

When selecting an alternate setting, the driver loops over all available
alternate settings to find the one with the lowest bandwidth high enough
for the selected format and resolution. While all alternate settings
should have different packet sizes, some buggy devices report multiple
alternate settings with the same size. The driver happens to pick the
last one in this case.

In theory this should work fine, but in real life we have device bugs.
The Ali Corp. Newmine Camera (0402:8841) exposes four alternate
settings with the same packet size. The first three seem to work fine,
while selecting the last one results in lots of transmission errors.

Switch to using the first best alternate setting when multiple are
present. This should be safe (last famous words), as sniffing USB
traffic with the faulty device shows that Windows 10 picks the first
alternate setting, and devices are typically tested on Windows.

Closes: https://lore.kernel.org/linux-media/Nh6D0WI--3-9@tutanota.com/

Reported-by: Karel Janda 
Suggested-by: Karel Janda 
Signed-off-by: Laurent Pinchart 
Signed-off-by: Mauro Carvalho Chehab

media: uvcvideo: Fix power line control for a Chicony camera

2023-12-09T06:35:46+00:00

The device does not implement the control properly.

Fixes v4l2-compliance error:

info: checking control 'Power Line Frequency' (0x00980918)
fail: v4l2-test-controls.cpp(552): could not set valid menu item 3

Signed-off-by: Ricardo Ribalda 
Signed-off-by: Laurent Pinchart 
Signed-off-by: Mauro Carvalho Chehab

media: stk1160: Fixed high volume of stk1160_dbg messages

2023-12-07T07:31:15+00:00

The function stk1160_dbg gets called too many times, which causes
the output to get flooded with messages. Since stk1160_dbg uses
printk, it is now replaced with printk_ratelimited.

Suggested-by: Phillip Potter 
Signed-off-by: Ghanshyam Agrawal 
Signed-off-by: Hans Verkuil

media: cx231xx: fix a memleak in cx231xx_init_isoc

2023-12-07T07:31:15+00:00

The dma_q->p_left_data alloced by kzalloc should be freed in all the
following error handling paths. However, it hasn't been freed in the
allocation error paths of dev->video_mode.isoc_ctl.urb and
dev->video_mode.isoc_ctl.transfer_buffer.

On the other hand, the dma_q->p_left_data did be freed in the
error-handling paths after that of dev->video_mode.isoc_ctl.urb and
dev->video_mode.isoc_ctl.transfer_buffer, by calling
cx231xx_uninit_isoc(dev). So the same free operation should be done in
error-handling paths of those two allocation.

Fixes: 64fbf4445526 ("[media] cx231xx: Added support for Carraera, Shelby, RDx_253S and VIDEO_GRABBER")
Signed-off-by: Zhipeng Lu 
Signed-off-by: Hans Verkuil

media: pvrusb2: fix use after free on context disconnection

2023-11-23T12:35:08+00:00

Upon module load, a kthread is created targeting the
pvr2_context_thread_func function, which may call pvr2_context_destroy
and thus call kfree() on the context object. However, that might happen
before the usb hub_event handler is able to notify the driver. This
patch adds a sanity check before the invalid read reported by syzbot,
within the context disconnection call stack.

Reported-and-tested-by: syzbot+621409285c4156a009b3@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/000000000000a02a4205fff8eb92@google.com/

Fixes: e5be15c63804 ("V4L/DVB (7711): pvrusb2: Fix race on module unload")
Signed-off-by: Ricardo B. Marliere 
Acked-by: Mike Isely 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: usb: usbtv: Stop direct calls to queue num_buffers field

2023-11-23T11:37:17+00:00

Use vb2_get_num_buffers() to avoid using queue num_buffers field directly.
This allows us to change how the number of buffers is computed in the
future.

Signed-off-by: Benjamin Gaignard 
Reviewed-by: Andrzej Pietrasiewicz 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: usb: hackrf: Stop direct calls to queue num_buffers field

2023-11-23T11:36:42+00:00

Use vb2_get_num_buffers() to avoid using queue num_buffers field directly.
This allows us to change how the number of buffers is computed in the
future.

Signed-off-by: Benjamin Gaignard 
Reviewed-by: Andrzej Pietrasiewicz 
CC: Antti Palosaari 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab