linux.git/drivers/media/rc, branch v5.16

media: ite-cir: IR receiver stop working after receive overflow

2021-10-19T07:08:39+00:00

On an Intel NUC6iSYK, no IR is reported after a receive overflow.

When a receiver overflow occurs, this condition is only cleared by
reading the fifo. Make sure we read anything in the fifo.

Fixes: 28c7afb07ccf ("media: ite-cir: check for receive overflow")
Suggested-by: Bryan Pass 
Tested-by: Bryan Pass 
Cc: stable@vger.kernel.org>
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: sir_ir: remove broken driver

2021-10-19T07:08:39+00:00

This driver is a port of the lirc_sir driver to rc-core. However, for
this driver I could not find any hardware to test, so it was done without
testing. This is a mistake.

There are clear bugs in the code. For example the two arguments
to ktime_us_delta() are reversed, which means the result is garbage.

The driver has been in the kernel for four years, and noone has ever
reported an issue. So, remove this driver.

Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: ir_toy: assignment to be16 should be of correct type

2021-10-19T07:08:39+00:00

commit f0c15b360fb6 ("media: ir_toy: prevent device from hanging during
transmit") removed a cpu_to_be16() cast, which causes a sparse warning.

Fixes: f0c15b360fb6 ("media: ir_toy: prevent device from hanging during transmit")
Reported-by: Hans Verkuil 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: ir_toy: prevent device from hanging during transmit

2021-09-30T08:10:26+00:00

If the IR Toy is receiving IR while a transmit is done, it may end up
hanging. We can prevent this from happening by re-entering sample mode
just before issuing the transmit command.

Link: https://github.com/bengtmartensson/HarcHardware/discussions/25

Cc: stable@vger.kernel.org
[mchehab: renamed: s/STATE_RESET/STATE_COMMAND_NO_RESP/ ]
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: mceusb: return without resubmitting URB in case of -EPROTO error.

2021-09-30T08:08:01+00:00

Syzkaller reported a warning called "rcu detected stall in dummy_timer".

The error seems to be an error in mceusb_dev_recv(). In the case of
-EPROTO error, the routine immediately resubmits the URB. Instead it
should return without resubmitting URB.

Reported-by: syzbot+4d3749e9612c2cfab956@syzkaller.appspotmail.com
Signed-off-by: Rajat Asthana 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: meson-ir-tx: fix platform_no_drv_owner.cocci warnings

2021-09-30T08:08:01+00:00

./drivers/media/rc/meson-ir-tx.c:398:3-8: No need to set .owner here. The core will do it.

Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Reported-by: Zeal Robot 
Signed-off-by: jing yangyang 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: ir_toy: do not resubmit broken urb

2021-09-30T08:08:01+00:00

This causes the same urb to resubmitted continuously, hogging up a cpu.

Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: ir_toy: deal with residual irdata before expected response

2021-09-30T08:08:01+00:00

After sending the start transmit command, the device is supposed to
respond with the length of the buffer which can be sent. There might
be some residual ir data there.

Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: ir_toy: print firmware version in correct format

2021-09-30T08:08:00+00:00

A value of 25 means firmware version 2.5.

Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: rc: sunxi-cir: Make use of the helper function devm_platform_ioremap_resource()

2021-09-30T08:07:51+00:00

Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing 
Acked-by: Maxime Ripard 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab