linux.git/drivers/media/rc, branch v4.5

[media] rc: sunxi-cir: Initialize the spinlock properly

2015-12-23T17:51:40+00:00

The driver allocates the spinlock but fails to initialize it correctly.
The kernel reports a BUG indicating bad spinlock magic when spinlock
debugging is enabled.

Call spin_lock_init() on it to initialize it correctly.

Fixes: b4e3e59fb59c ("[media] rc: add sunxi-ir driver")

Signed-off-by: Chen-Yu Tsai 
Acked-by: Hans de Goede 
Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab

[media] ir-lirc-codec.c: don't leak lirc->drv-rbuf

2015-12-21T16:59:36+00:00

As reported by kmemleak:

	unreferenced object 0xffff8802adae0ba0 (size 192):
	  comm "modprobe", pid 3024, jiffies 4296503588 (age 324.368s)
	  hex dump (first 32 bytes):
	    00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00  .....N..........
	    ff ff ff ff ff ff ff ff c0 48 25 a0 ff ff ff ff  .........H%.....
	  backtrace:
	    [] kmemleak_alloc+0x4e/0xb0
	    [] kmem_cache_alloc_trace+0x1ec/0x280
	    [] ir_lirc_register+0x8d/0x7a0 [ir_lirc_codec]
	    [] ir_raw_event_register+0x318/0x4b0 [rc_core]
	    [] rc_register_device+0xf2d/0x1450 [rc_core]
	    [] au0828_rc_register+0x7d1/0xa10 [au0828]
	    [] au0828_usb_probe+0x6c2/0xcf0 [au0828]
	    [] usb_probe_interface+0x45d/0x940
	    [] driver_probe_device+0x454/0xd90
	    [] __driver_attach+0x121/0x160
	    [] bus_for_each_dev+0x11f/0x1a0
	    [] driver_attach+0x3d/0x50
	    [] bus_add_driver+0x4c9/0x770
	    [] driver_register+0x18c/0x3b0
	    [] usb_register_driver+0x1f8/0x440
	    [] 0xffffffffa13680b7

	0xf3d is in ir_lirc_register (drivers/media/rc/ir-lirc-codec.c:348).
	343		drv = kzalloc(sizeof(struct lirc_driver), GFP_KERNEL);
	344		if (!drv)
	345			return rc;
	346
	347		rbuf = kzalloc(sizeof(struct lirc_buffer), GFP_KERNEL);
	348		if (!rbuf)
	349			goto rbuf_alloc_failed;
	350
	351		rc = lirc_buffer_init(rbuf, sizeof(int), LIRCBUF_SIZE);
	352		if (rc)

Signed-off-by: Mauro Carvalho Chehab

[media] media: rc: remove unneeded code

2015-12-03T17:01:11+00:00

Now that that the decoder modules are loaded on-demand we can move
loading the lirc module to rc_register_device directly and remove
unneeded functions and comments.

Signed-off-by: Heiner Kallweit

[media] media: rc: move check whether a protocol is enabled to the core

2015-11-19T13:39:17+00:00

Checking whether a protocol is enabled and calling the related decoder
functions should be done by the rc core, not the protocol handlers.

Properly handle lirc considering that no protocol bit is set for lirc.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Mauro Carvalho Chehab

[media] media: rc: load decoder modules on-demand

2015-11-19T13:38:41+00:00

Remove code for unconditional decoder module loading (except lirc).

Signed-off-by: Heiner Kallweit 
Signed-off-by: Mauro Carvalho Chehab

[media] media: rc: constify struct proto_names

2015-11-19T13:38:14+00:00

Declare struct proto_names and its member name as const.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Mauro Carvalho Chehab

[media] media: rc: preparation for on-demand decoder module loading

2015-11-19T13:37:40+00:00

Prepare on-demand decoder module loading by adding a module_name member
to struct proto_names and introducing the related load function.

After this patch of the series the decoder modules are still loaded
unconditionally.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Mauro Carvalho Chehab

[media] media: rc: fix decoder module unloading

2015-11-19T13:36:29+00:00

Currently, if a decoder module is unloadad, the respective protocol
is still shown as enabled (if it was enabled before).
Fix this by resetting the respective protocol bits if a decoder
module is unloaded.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Mauro Carvalho Chehab

[media] media: rc-core: simplify logging in rc_register_device

2015-11-19T11:38:19+00:00

Simplify the logging.

I had some doubts about using the elvis operator as it's GNU extension.
However GNU extensions are explicitely allowed and this operator is
used at several places in the kernel code.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Mauro Carvalho Chehab

[media] media: rc: nuvoton-cir: replace nvt_pr with dev_ functions

2015-11-19T11:37:34+00:00

Replace nvt_pr with the respective dev_ functions thus slightly
simplifying the code.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Mauro Carvalho Chehab