linux.git/drivers/media/platform/mediatek, branch v6.8

media: platform: mtk-mdp3: Use devicetree phandle to retrieve SCP

2023-12-07T07:31:14+00:00

Instead of walking the entire parent node for something that has the
right compatible, use the scp_get() function provided by the MediaTek
SCP remoteproc driver to retrieve a handle to mtk_scp through the
devicetree "mediatek,scp" (phandle) property.

In case of multi-core SCP, this also allows to select a specific core.

Reviewed-by: Chen-Yu Tsai 
Signed-off-by: AngeloGioacchino Del Regno 
Reviewed-by: Alexandre Mergnat 
Signed-off-by: Hans Verkuil

media: mediatek: vcodec: Set the supported vp9 profile for each platform

2023-11-23T18:26:22+00:00

Set the maximum VP9 codec profile for each platform.
The various mediatek platforms support different profiles for decoding,
the profile of the codec limits the capabilities for decoding.

Signed-off-by: Yunfei Dong 
Reviewed-by: Sebastian Fricke 
Reviewed-by: AngeloGioacchino Del Regno 
Signed-off-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil

media: mediatek: vcodec: Set the supported vp9 level for each platform

2023-11-23T18:26:22+00:00

Set the maximum VP9 codec level for each platform.
The various mediatek platforms support different levels for decoding, the
level of the codec limits among others the maximum resolution, bit rate,
frame rate and compression rate for the decoder.

Signed-off-by: Yunfei Dong 
Reviewed-by: Sebastian Fricke 
Reviewed-by: AngeloGioacchino Del Regno 
Signed-off-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil

media: mediatek: vcodec: Set the supported h265 profile for each platform

2023-11-23T18:26:22+00:00

Set the maximum H265 codec profile for each platform.
The various mediatek platforms support different profiles for decoding,
the profile of the codec limits the capabilities for decoding.

Signed-off-by: Yunfei Dong 
Reviewed-by: Sebastian Fricke 
Reviewed-by: AngeloGioacchino Del Regno 
Signed-off-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil

media: mediatek: vcodec: Set the supported h264 profile for each platform

2023-11-23T18:26:22+00:00

Set the maximum H264 codec profile for each platform.
The various mediatek platforms support different profiles for decoding,
the profile of the codec limits the capabilities for decoding.

Signed-off-by: Yunfei Dong 
Reviewed-by: Sebastian Fricke 
Reviewed-by: AngeloGioacchino Del Regno 
Signed-off-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil

media: mediatek: vcodec: Set the supported h265 level for each platform

2023-11-23T18:26:22+00:00

Set the maximum H265 codec level for each platform.
The various mediatek platforms support different levels for decoding, the
level of the codec limits among others the maximum resolution, bit rate
and frame rate for the decoder.

Signed-off-by: Yunfei Dong 
Reviewed-by: Sebastian Fricke 
Reviewed-by: AngeloGioacchino Del Regno 
Signed-off-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil

media: mediatek: vcodec: Set the supported h264 level for each platform

2023-11-23T18:26:22+00:00

Set the maximum H264 codec level for each platform.
The various mediatek platforms support different levels for decoding, the
level of the codec limits among others the maximum resolution, bit rate
and frame rate for the decoder.

Signed-off-by: Yunfei Dong 
Reviewed-by: Sebastian Fricke 
Reviewed-by: AngeloGioacchino Del Regno 
Signed-off-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil

media: mediatek: vcodec: Get the chip name for each platform

2023-11-23T18:26:22+00:00

Store the name of the chip in the context of the driver in order
to be able to choose the correct configuration values for the
different codecs.
Use a enum value instead of an integer to store a more descriptive name.

Signed-off-by: Yunfei Dong 
Reviewed-by: AngeloGioacchino Del Regno 
Reviewed-by: Sebastian Fricke 
Signed-off-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil

media: mtk-jpeg: Fix timeout schedule error in mtk_jpegdec_worker.

2023-11-23T12:37:57+00:00

In mtk_jpegdec_worker, if error occurs in mtk_jpeg_set_dec_dst, it
will start the timeout worker and invoke v4l2_m2m_job_finish at
the same time. This will break the logic of design for there should
be only one function to call v4l2_m2m_job_finish. But now the timeout
handler and mtk_jpegdec_worker will both invoke it.

Fix it by start the worker only if mtk_jpeg_set_dec_dst successfully
finished.

Fixes: da4ede4b7fd6 ("media: mtk-jpeg: move data/code inside CONFIG_OF blocks")
Signed-off-by: Zheng Wang 
Signed-off-by: Dmitry Osipenko 
Cc: stable@vger.kernel.org
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: mtk-jpeg: Fix use after free bug due to error path handling in mtk_jpeg_dec_device_run

2023-11-23T12:37:33+00:00

In mtk_jpeg_probe, &jpeg->job_timeout_work is bound with
mtk_jpeg_job_timeout_work.

In mtk_jpeg_dec_device_run, if error happens in
mtk_jpeg_set_dec_dst, it will finally start the worker while
mark the job as finished by invoking v4l2_m2m_job_finish.

There are two methods to trigger the bug. If we remove the
module, it which will call mtk_jpeg_remove to make cleanup.
The possible sequence is as follows, which will cause a
use-after-free bug.

CPU0                  CPU1
mtk_jpeg_dec_...    |
  start worker	    |
                    |mtk_jpeg_job_timeout_work
mtk_jpeg_remove     |
  v4l2_m2m_release  |
    kfree(m2m_dev); |
                    |
                    | v4l2_m2m_get_curr_priv
                    |   m2m_dev->curr_ctx //use

If we close the file descriptor, which will call mtk_jpeg_release,
it will have a similar sequence.

Fix this bug by starting timeout worker only if started jpegdec worker
successfully. Then v4l2_m2m_job_finish will only be called in
either mtk_jpeg_job_timeout_work or mtk_jpeg_dec_device_run.

Fixes: b2f0d2724ba4 ("[media] vcodec: mediatek: Add Mediatek JPEG Decoder Driver")
Signed-off-by: Zheng Wang 
Signed-off-by: Dmitry Osipenko 
Cc: stable@vger.kernel.org
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab