linux.git/drivers/media/platform/mediatek/vcodec, branch for-next

media: mediatek: vcodec: mark vdec_vp9_slice_map_counts_eob_coef noinline

2024-12-13T16:51:35+00:00

With KASAN enabled, clang fails to optimize the inline version of
vdec_vp9_slice_map_counts_eob_coef() properly, leading to kilobytes
of temporary values spilled to the stack:

drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c:1526:12: error: stack frame size (2160) exceeds limit (2048) in 'vdec_vp9_slice_update_prob' [-Werror,-Wframe-larger-than]

This seems to affect all versions of clang including the latest (clang-20),
but the degree of stack overhead is different per release.

Marking the function as noinline_for_stack is harmless here and avoids
the problem completely.

Signed-off-by: Arnd Bergmann 
Reviewed-by: Nathan Chancellor 
Signed-off-by: Sebastian Fricke 
Signed-off-by: Mauro Carvalho Chehab

media: platform: drop vb2_ops_wait_prepare/finish

2024-10-28T08:20:07+00:00

Since commit 88785982a19d ("media: vb2: use lock if wait_prepare/finish
are NULL") it is no longer needed to set the wait_prepare/finish
vb2_ops callbacks as long as the lock field in vb2_queue is set.

Since the vb2_ops_wait_prepare/finish callbacks already rely on that field,
we can safely drop these callbacks.

This simplifies the code and this is a step towards the goal of deleting
these callbacks.

Signed-off-by: Hans Verkuil 
Reviewed-by: Neil Armstrong  # for meson-ge2d
Acked-by: Andrzej Pietrasiewicz

media: Switch back to struct platform_driver::remove()

2024-10-12T14:28:25+00:00

After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers.

Convert all platform drivers below drivers/media to use .remove(), with
the eventual goal to drop struct platform_driver::remove_new(). As
.remove() and .remove_new() have the same prototypes, conversion is done
by just changing the structure member name in the driver initializer.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Hans Verkuil

media: mediatek: vcodec: Constify struct vb2_ops

2024-08-28T08:01:10+00:00

"struct vb2_ops" are not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig:
Before:
======
   text	   data	    bss	    dec	    hex	filename
  18059	   3096	     16	  21171	   52b3	drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateful.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
  18171	   2968	     16	  21155	   52a3	drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateful.o

Signed-off-by: Christophe JAILLET 
Signed-off-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil

media: mediatek: vcodec: Fix H264 stateless decoder smatch warning

2024-08-28T08:01:09+00:00

Fix a smatch static checker warning on vdec_h264_req_if.c.
Which leads to a kernel crash when fb is NULL.

Fixes: 06fa5f757dc5 ("media: mtk-vcodec: vdec: support stateless H.264 decoding")
Signed-off-by: Yunfei Dong 
Reviewed-by: AngeloGioacchino Del Regno 
Signed-off-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil

media: mediatek: vcodec: Fix VP8 stateless decoder smatch warning

2024-08-28T08:01:09+00:00

Fix a smatch static checker warning on vdec_vp8_req_if.c.
Which leads to a kernel crash when fb is NULL.

Fixes: 7a7ae26fd458 ("media: mediatek: vcodec: support stateless VP8 decoding")
Signed-off-by: Yunfei Dong 
Reviewed-by: AngeloGioacchino Del Regno 
Signed-off-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil

media: mediatek: vcodec: Fix H264 multi stateless decoder smatch warning

2024-08-28T08:01:09+00:00

Fix a smatch static checker warning on vdec_h264_req_multi_if.c.
Which leads to a kernel crash when fb is NULL.

Fixes: 397edc703a10 ("media: mediatek: vcodec: add h264 decoder driver for mt8186")
Signed-off-by: Yunfei Dong 
Reviewed-by: AngeloGioacchino Del Regno 
Signed-off-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil

media: mediatek: vcodec: Alloc DMA memory with DMA_ATTR_ALLOC_SINGLE_PAGES

2024-06-10T08:24:11+00:00

As talked about in commit 14d3ae2efeed ("ARM: 8507/1: dma-mapping: Use
DMA_ATTR_ALLOC_SINGLE_PAGES hint to optimize alloc"), it doesn't
really make sense to try to allocate contiguous chunks of memory for
video encoding/decoding. Let's switch the Mediatek vcodec driver to
pass DMA_ATTR_ALLOC_SINGLE_PAGES and take some of the stress off the
memory subsystem.

Signed-off-by: Douglas Anderson 
Tested-by: Fei Shao 
Reviewed-by: Fei Shao 
Reviewed-by: Nicolas Dufresne 
Signed-off-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil

media: mediatek: vcodec: Fix unreasonable data conversion

2024-06-10T08:24:11+00:00

Both 'bs_dma' and 'dma_addr' are integers. No need to convert the
type from dma_addr_t to uint64_t again.

Fixes: d353c3c34af0 ("media: mediatek: vcodec: support 36 bits physical address")

Signed-off-by: Yunfei Dong 
Signed-off-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil

media: mediatek: vcodec: Handle invalid decoder vsi

2024-06-10T08:24:11+00:00

Handle an invalid decoder vsi in vpu_dec_init to ensure the decoder vsi
is valid for future use.

Fixes: 590577a4e525 ("[media] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver")

Signed-off-by: Irui Wang 
Reviewed-by: AngeloGioacchino Del Regno 
Signed-off-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil