linux.git/drivers/media/dvb-frontends, branch v5.8

media: dvb-frontends: remove redundant initialization of variable status

2020-05-12T15:33:31+00:00

The variable status is being initialized with a value that is never read
and it is being updated later with a new value.  The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")

Signed-off-by: Colin Ian King 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: stv0900_core: remove redundant assignment to variable val

2020-05-12T15:31:30+00:00

The variable val is being initializeed with a value that is never read
and it is being updated later with a new value. The initialization
is redundant and can be removed.

Addresses-Coverity: ("Unused value")

Signed-off-by: Colin Ian King 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: dvb: remove redundant assignment to variable bw

2020-05-12T15:30:57+00:00

The variable bw is being initialized with a value that is
never read and it is being updated later with a new value.  The
initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")

Signed-off-by: Colin Ian King 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: m88ds3103: error in set_frontend is swallowed and not reported

2020-04-29T09:58:27+00:00

Bail out if registers can not be updated.

Addresses-Coverity-ID: 1461655 ("Code maintainability issues")

Reported-by: coverity-bot 
Fixes: e6089feca460 ("media: m88ds3103: Add support for ds3103b demod")
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: lgdt3306a: Add CNR v5 stat

2020-04-21T14:50:56+00:00

The CNR is already calculated, so populate DVBv5 CNR stat
during read_status.

Signed-off-by: Brad Love 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: m88ds3103: Add missing '\n' in log messages

2020-04-21T10:56:27+00:00

Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'.

While at it, change the log level from 'err' to 'debug'.

Fixes: e6089feca460 ("media: m88ds3103: Add support for ds3103b demod")
Signed-off-by: Christophe JAILLET 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: dvb-frontends: DUMMY_FE should depends on DVB_CORE

2020-04-17T07:21:47+00:00

Using select for DVB_CORE doesn't work, as reported by
Randy:

	CONFIG_I2C=m
	CONFIG_DVB_CORE=y

	ld: drivers/media/dvb-core/dvbdev.o: in function `dvb_module_probe':
	dvbdev.c:(.text+0xf92): undefined reference to `i2c_new_client_device'
	ld: dvbdev.c:(.text+0xffb): undefined reference to `i2c_unregister_device'
	ld: drivers/media/dvb-core/dvbdev.o: in function `dvb_module_release':
	dvbdev.c:(.text+0x107d): undefined reference to `i2c_unregister_device'

The problem is actually caused by the dummy frontend driver,
which uses select, and it is missing an I2C dependency:

	WARNING: unmet direct dependencies detected for DVB_CORE
	  Depends on [m]: MEDIA_SUPPORT [=y] && MEDIA_DIGITAL_TV_SUPPORT [=y] && (I2C [=m] || I2C [=m]=n)
	  Selected by [y]:
	  - DVB_DUMMY_FE [=y] && MEDIA_SUPPORT [=y] && MEDIA_TEST_SUPPORT [=y]

As this is the only frontend driver using "select DVB_CORE",
change it do depends on DVB_CORE.

Reported-by: Randy Dunlap 
Signed-off-by: Mauro Carvalho Chehab

media: i2c/Kconfig: use sub-menus for I2C support

2020-04-16T08:34:40+00:00

There are *lots* of I2C ancillary drivers. While we're using
comments to group them, all options appear at the same menu.

It should be a lot clearer to group them into sub-menus, with
may help people to go directly to the driver(s) he's needing
to enable.

Suggested-by: Hans Verkuil 
Acked-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: docs: move driver-specific info to driver-api

2020-04-14T08:36:18+00:00

Those documents don't really describe the driver API.

Instead, they contain development-specific information.

Yet, as the main index file describes the content of it as:

	"how specific kernel subsystems work
	 from the point of view of a kernel developer"

It seems to be the better fit.

Signed-off-by: Mauro Carvalho Chehab

media: add SPDX headers on Kconfig and Makefile files

2020-04-14T08:29:05+00:00

Most of media Kconfig/Makefile files already has SPDX,
but there are a few ones still missing. Add it to them.

Signed-off-by: Mauro Carvalho Chehab