linux.git/drivers/media/dvb-core/dvb_vb2.c, branch for-next

media: dvb-core: add missing buffer index check

2024-10-15T05:00:58+00:00

dvb_vb2_expbuf() didn't check if the given buffer index was
for a valid buffer. Add this check.

Signed-off-by: Hans Verkuil 
Reported-by: Chenyuan Yang 
Closes: https://lore.kernel.org/linux-media/?q=WARNING+in+vb2_core_reqbufs
Fixes: 7dc866df4012 ("media: dvb-core: Use vb2_get_buffer() instead of directly access to buffers array")
Reviewed-by: Benjamin Gaignard 
Cc: 
Signed-off-by: Mauro Carvalho Chehab

media: videobuf2: core: Rename min_buffers_needed field in vb2_queue

2023-12-13T16:31:27+00:00

Rename min_buffers_needed into min_queued_buffers and update
the documentation about it.

Signed-off-by: Benjamin Gaignard 
Signed-off-by: Hans Verkuil 
[hverkuil: Drop the change where min_queued_buffers + 1 buffers would be]
[hverkuil: allocated. Now this patch only renames this field instead of making]
[hverkuil: a functional change as well.]
[hverkuil: Renamed 3 remaining min_buffers_needed occurrences.]

media: dvb-core: Do not initialize twice queue num_buffer field

2023-11-23T11:10:06+00:00

The above memset already zeroed all the ctx fields, it is useless
to do it here again.

Signed-off-by: Benjamin Gaignard 
Reviewed-by: Andrzej Pietrasiewicz 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: dvb-core: Use vb2_get_buffer() instead of directly access to buffers array

2023-11-23T11:09:43+00:00

Use vb2_get_buffer() instead of direct access to the vb2_queue bufs array.
This allows us to change the type of the bufs in the future.
After each call to vb2_get_buffer() we need to be sure that we get
a valid pointer so check the return value of all of them.

Signed-off-by: Benjamin Gaignard 
Reviewed-by: Andrzej Pietrasiewicz 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: videobuf2: Use vb2_buffer instead of index

2023-11-23T10:52:04+00:00

Directly use vb2_buffer pointer instead of index inside queue array.

Signed-off-by: Benjamin Gaignard 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: dvb_vb2: fix possible out of bound access

2022-09-27T08:24:44+00:00

vb2_core_qbuf and vb2_core_querybuf don't check the range of b->index
controlled by the user.

Fix this by adding range checking code before using them.

Fixes: 57868acc369a ("media: videobuf2: Add new uAPI for DVB streaming I/O")
Signed-off-by: Hangyu Hua 
Reviewed-by: Sergey Senozhatsky 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: dvb-core: Convert to SPDX identifier

2021-11-19T15:22:13+00:00

use SPDX-License-Identifier instead of a verbose license text
and remove verbose license text.

Link: https://lore.kernel.org/linux-media/20210916020018.8550-1-caihuoqing@baidu.com

Signed-off-by: Cai Huoqing 
Signed-off-by: Mauro Carvalho Chehab

media: videobuf2: add queue memory coherency parameter

2021-09-30T08:07:57+00:00

Preparations for future V4L2_MEMORY_FLAG_NON_COHERENT support.

Extend the vb2_core_reqbufs() parameters list to accept requests'
->flags, which will be used for memory coherency configuration.

An attempt to allocate a buffer with coherency requirements
that do not match the queue's consistency model will fail.

Signed-off-by: Sergey Senozhatsky 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: media/v4l2: remove V4L2_FLAG_MEMORY_NON_CONSISTENT flag

2020-09-14T13:28:06+00:00

The patch partially reverts some of the UAPI bits of the buffer
cache management hints. Namely, the queue consistency (memory
coherency) user-space hint because, as it turned out, the kernel
implementation of this feature was misusing DMA_ATTR_NON_CONSISTENT.

The patch reverts both kernel and user space parts: removes the
DMA consistency attr functions, rolls back changes to v4l2_requestbuffers,
v4l2_create_buffers structures and corresponding UAPI functions
(plus compat32 layer) and cleans up the documentation.

[hverkuil: fixed a few typos in the commit log]
[hverkuil: fixed vb2_core_reqbufs call in drivers/media/dvb-core/dvb_vb2.c]
[mchehab: fixed a typo in the commit log: revers->reverts]

Signed-off-by: Christoph Hellwig 
Signed-off-by: Sergey Senozhatsky 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: videobuf2: add queue memory consistency parameter

2020-06-23T11:31:12+00:00

Preparations for future V4L2_FLAG_MEMORY_NON_CONSISTENT support.

Extend vb2_core_reqbufs() parameters list to accept requests'
->flags, which will be used for memory consistency configuration.

An attempt to allocate a buffer with consistency requirements
which don't match queue's consistency model will fail.

Signed-off-by: Sergey Senozhatsky 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab