linux.git/drivers/md/raid1.c, branch v6.9-rc2

md: remove mddev->queue

2024-03-06T16:59:53+00:00

Just use the request_queue from the gendisk pointer in the relatively
few places that sill need it.

Signed-off-by: Christoph Hellwig 
Reviewed--by: Song Liu 
Tested-by: Song Liu 
Signed-off-by: Song Liu 
Link: https://lore.kernel.org/r/20240303140150.5435-11-hch@lst.de

md/raid1: use the atomic queue limit update APIs

2024-03-06T16:59:53+00:00

Build the queue limits outside the queue and apply them using
queue_limits_set.  To make the code more obvious also split the queue
limits handling into a separate helper function.

Signed-off-by: Christoph Hellwig 
Reviewed--by: Song Liu 
Tested-by: Song Liu 
Signed-off-by: Song Liu 
Link: https://lore.kernel.org/r/20240303140150.5435-7-hch@lst.de

md: add a mddev_is_dm helper

2024-03-06T16:59:53+00:00

Add a helper to check for a DM-mapped MD device instead of using
the obfuscated ->gendisk or ->queue NULL checks.

Signed-off-by: Christoph Hellwig 
Reviewed--by: Song Liu 
Tested-by: Song Liu 
Signed-off-by: Song Liu 
Link: https://lore.kernel.org/r/20240303140150.5435-4-hch@lst.de

md: add a mddev_add_trace_msg helper

2024-03-06T16:59:52+00:00

Add a small wrapper around blk_add_trace_msg that hides some argument
dereferences and the check for a DM-mapped MD device.

Signed-off-by: Christoph Hellwig 
Reviewed--by: Song Liu 
Tested-by: Song Liu 
Signed-off-by: Song Liu 
Link: https://lore.kernel.org/r/20240303140150.5435-3-hch@lst.de

md: add a mddev_trace_remap helper

2024-03-06T16:59:52+00:00

Add a helper to trace bio remapping that hides some argument
dereferences and the check for a DM-mapped MD device.

Signed-off-by: Christoph Hellwig 
Reviewed--by: Song Liu 
Tested-by: Song Liu 
Signed-off-by: Song Liu 
Link: https://lore.kernel.org/r/20240303140150.5435-2-hch@lst.de

md/raid1: factor out helpers to choose the best rdev from read_balance()

2024-03-01T06:49:46+00:00

The way that best rdev is chosen:

1) If the read is sequential from one rdev:
 - if rdev is rotational, use this rdev;
 - if rdev is non-rotational, use this rdev until total read length
   exceed disk opt io size;

2) If the read is not sequential:
 - if there is idle disk, use it, otherwise:
 - if the array has non-rotational disk, choose the rdev with minimal
   inflight IO;
 - if all the underlaying disks are rotational disk, choose the rdev
   with closest IO;

There are no functional changes, just to make code cleaner and prepare
for following refactor.

Co-developed-by: Paul Luse 
Signed-off-by: Paul Luse 
Signed-off-by: Yu Kuai 
Reviewed-by: Xiao Ni 
Signed-off-by: Song Liu 
Link: https://lore.kernel.org/r/20240229095714.926789-12-yukuai1@huaweicloud.com

md/raid1: factor out the code to manage sequential IO

2024-03-01T06:49:46+00:00

There is no functional change for now, make read_balance() cleaner and
prepare to fix problems and refactor the handler of sequential IO.

Co-developed-by: Paul Luse 
Signed-off-by: Paul Luse 
Signed-off-by: Yu Kuai 
Reviewed-by: Xiao Ni 
Signed-off-by: Song Liu 
Link: https://lore.kernel.org/r/20240229095714.926789-11-yukuai1@huaweicloud.com

md/raid1: factor out choose_bb_rdev() from read_balance()

2024-03-01T06:49:46+00:00

read_balance() is hard to understand because there are too many status
and branches, and it's overlong.

This patch factor out the case to read the rdev with bad blocks from
read_balance(), there are no functional changes.

Co-developed-by: Paul Luse 
Signed-off-by: Paul Luse 
Signed-off-by: Yu Kuai 
Reviewed-by: Xiao Ni 
Signed-off-by: Song Liu 
Link: https://lore.kernel.org/r/20240229095714.926789-10-yukuai1@huaweicloud.com

md/raid1: factor out choose_slow_rdev() from read_balance()

2024-03-01T06:49:46+00:00

read_balance() is hard to understand because there are too many status
and branches, and it's overlong.

This patch factor out the case to read the slow rdev from
read_balance(), there are no functional changes.

Co-developed-by: Paul Luse 
Signed-off-by: Paul Luse 
Signed-off-by: Yu Kuai 
Reviewed-by: Xiao Ni 
Signed-off-by: Song Liu 
Link: https://lore.kernel.org/r/20240229095714.926789-9-yukuai1@huaweicloud.com

md/raid1: factor out read_first_rdev() from read_balance()

2024-03-01T06:49:46+00:00

read_balance() is hard to understand because there are too many status
and branches, and it's overlong.

This patch factor out the case to read the first rdev from
read_balance(), there are no functional changes.

Co-developed-by: Paul Luse 
Signed-off-by: Paul Luse 
Signed-off-by: Yu Kuai 
Reviewed-by: Xiao Ni 
Signed-off-by: Song Liu 
Link: https://lore.kernel.org/r/20240229095714.926789-8-yukuai1@huaweicloud.com