linux.git/drivers/md/raid1.c, branch v2.6.38

md: avoid spinlock problem in blk_throtl_exit

2011-02-21T07:25:57+00:00

blk_throtl_exit assumes that ->queue_lock still exists,
so make sure that it does.
To do this, we stop redirecting ->queue_lock to conf->device_lock
and leave it pointing where it is initialised - __queue_lock.

As the blk_plug functions check the ->queue_lock is held, we now
take that spin_lock explicitly around the plug functions.  We don't
need the locking, just the warning removal.

This is needed for any kernel with the blk_throtl code, which is
which is 2.6.37 and later.

Cc: stable@kernel.org
Signed-off-by: NeilBrown

md-new-param-to_sync_page_io

2011-01-13T22:14:33+00:00

Add new parameter to 'sync_page_io'.

The new parameter allows us to distinguish between metadata and data
operations.  This becomes important later when we add the ability to
use separate devices for data and metadata.

Signed-off-by: Jonathan Brassow

md: Fix single printks with multiple KERN_s

2011-01-13T22:14:33+00:00

Noticed-by: Russell King 
Signed-off-by: Joe Perches 
Signed-off-by: NeilBrown

md/raid1: really fix recovery looping when single good device fails.

2010-11-24T05:39:46+00:00

Commit 4044ba58dd15cb01797c4fd034f39ef4a75f7cc3 supposedly fixed a
problem where if a raid1 with just one good device gets a read-error
during recovery, the recovery would abort and immediately restart in
an infinite loop.

However it depended on raid1_remove_disk removing the spare device
from the array.  But that does not happen in this case.  So add a test
so that in the 'recovery_disabled' case, the device will be removed.

This suitable for any kernel since 2.6.29 which is when
recovery_disabled was introduced.

Cc: stable@kernel.org
Reported-by: Sebastian Färber 
Signed-off-by: NeilBrown

md: tidy up device searches in read_balance.

2010-10-29T05:40:33+00:00

The code for searching through the device list to read-balance in
raid1 is rather clumsy and hard to follow.  Try to simplify it a bit.

No important functionality change here.


Signed-off-by: NeilBrown

md/raid1: fix some typos in comments.

2010-10-29T05:40:33+00:00

Signed-off-by: NeilBrown

md/raid1: discard unused variable.

2010-10-29T05:40:33+00:00

This structure field (flushing_bio_list) is never used, so remove it.

Signed-off-by: NeilBrown

md: use separate bio pool for each md device.

2010-10-28T06:36:15+00:00

bio_clone and bio_alloc allocate from a common bio pool.
If an md device is stacked with other devices that use this pool, or under
something like swap which uses the pool, then the multiple calls on
the pool can cause deadlocks.

So allocate a local bio pool for each md array and use that rather
than the common pool.

This pool is used both for regular IO and metadata updates.

Signed-off-by: NeilBrown

md: change type of first arg to sync_page_io.

2010-10-28T06:36:11+00:00

Currently sync_page_io takes a 'bdev'.
Every caller passes 'rdev->bdev'.
We will soon want another field out of the rdev in sync_page_io,
So just pass the rdev instead of the bdev out of it.

Signed-off-by: NeilBrown

md/raid1: perform mem allocation before disabling writes during resync.

2010-10-28T06:36:09+00:00

Though this mem alloc is GFP_NOIO an so will not deadlock, it seems
better to do the allocation before 'raise_barrier' which stops any IO
requests while the resync proceeds.

raid10 always uses this order, so it is at least consistent to do the
same in raid1.

Signed-off-by: NeilBrown