linux.git/drivers/md/raid0.c, branch v2.6.29

md: use list_for_each_entry macro directly

2009-01-08T21:31:08+00:00

The rdev_for_each macro defined in  is identical to
list_for_each_entry_safe, from , it should be defined to
use list_for_each_entry_safe, instead of reinventing the wheel.

But some calls to each_entry_safe don't really need a safe version,
just a direct list_for_each_entry is enough, this could save a temp
variable (tmp) in every function that used rdev_for_each.

In this patch, most rdev_for_each loops are replaced by list_for_each_entry,
totally save many tmp vars; and only in the other situations that will call
list_del to delete an entry, the safe version is used.

Signed-off-by: Cheng Renquan 
Signed-off-by: NeilBrown

md: raid0: make hash_spacing and preshift sector-based.

2009-01-08T21:31:08+00:00

This patch renames the hash_spacing and preshift members of struct
raid0_private_data to spacing and sector_shift respectively and
changes the semantics as follows:

We always have spacing = 2 * hash_spacing. In case
sizeof(sector_t) > sizeof(u32) we also have sector_shift = preshift + 1
while sector_shift = preshift = 0 otherwise.

Note that the values of nb_zone and zone are unaffected by these changes
because in the sector_div() preceeding the assignement of these two
variables both arguments double.

Signed-off-by: Andre Noll 
Signed-off-by: NeilBrown

md: raid0: Represent the size of strip zones in sectors.

2009-01-08T21:31:07+00:00

This completes the block -> sector conversion of struct strip_zone.

Signed-off-by: Andre Noll 
Signed-off-by: NeilBrown

md: raid0 create_strip_zones(): Add KERN_INFO/KERN_ERR to printk's.

2009-01-08T21:31:07+00:00

This patch consists only of these trivial changes.

Signed-off-by: Andre Noll 
Signed-off-by: NeilBrown

md: raid0 create_strip_zones(): Make two local variables sector-based.

2009-01-08T21:31:07+00:00

current_offset and curr_zone_offset stored the corresponding offsets
as 1K quantities. Rename them to current_start and curr_zone_start
to match the naming of struct strip_zone and store the offsets as
sector counts.

Also, add KERN_INFO to the printk() affected by this change to make
checkpatch happy.

Signed-off-by: Andre Noll 
Signed-off-by: NeilBrown

md: raid0: Represent zone->zone_offset in sectors.

2009-01-08T21:31:07+00:00

For the same reason as in the previous patch, rename it from zone_offset
to zone_start.

Signed-off-by: Andre Noll 
Signed-off-by: NeilBrown

md: raid0: Represent device offset in sectors.

2009-01-08T21:31:06+00:00

Rename zone->dev_offset to zone->dev_start to make sure all users
have been converted.

Signed-off-by: Andre Noll 
Signed-off-by: NeilBrown

md: raid0_make_request(): Replace local variable block by sector.

2009-01-08T21:31:06+00:00

This change already simplifies the code a bit.

Signed-off-by: Andre Noll 
Signed-off-by: NeilBrown

md: raid0_make_request(): Remove local variable chunk_size.

2009-01-08T21:31:06+00:00

We might as well use chunk_sects instead.

Signed-off-by: Andre Noll 
Signed-off-by: NeilBrown

md: raid0_make_request(): Replace chunksize_bits by chunksect_bits.

2009-01-08T21:31:06+00:00

As ffz(~(2 * x)) = ffz(~x) + 1, we have

	chunksect_bits = chunksize_bits + 1.

Fixup all users accordingly.

Signed-off-by: Andre Noll 
Signed-off-by: NeilBrown