linux.git/drivers/md/dm-thin.c, branch v3.17

dm thin: set minimum_io_size to pool's data block size

2014-08-01T16:30:35+00:00

Before, if the block layer's limit stacking didn't establish an
optimal_io_size that was compatible with the thin-pool's data block size
we'd set optimal_io_size to the data block size and minimum_io_size to 0
(which the block layer adjusts to be physical_block_size).

Update pool_io_hints() to set both minimum_io_size and optimal_io_size
to the thin-pool's data block size.  This fixes an issue reported where
mkfs.xfs would create more XFS Allocation Groups on thinp volumes than
on a normal linear LV of comparable size, see:
https://bugzilla.redhat.com/show_bug.cgi?id=1003227

Reported-by: Chris Murphy 
Signed-off-by: Mike Snitzer

dm thin: relax external origin size constraints

2014-08-01T16:30:32+00:00

Track the size of any external origin.  Previously the external origin's
size had to be a multiple of the thin-pool's block size, that is no
longer a requirement.  In addition, snapshots that are larger than the
external origin are now supported.

Signed-off-by: Joe Thornber 
Signed-off-by: Mike Snitzer

dm thin: switch to an atomic_t for tracking pending new block preparations

2014-08-01T16:30:31+00:00

Previously we used separate boolean values to track quiescing and
copying actions.  By switching to an atomic_t we can support blocks that
need a partial copy and partial zero.

Signed-off-by: Joe Thornber 
Signed-off-by: Mike Snitzer

dm thin: update discard_granularity to reflect the thin-pool blocksize

2014-06-11T20:56:12+00:00

DM thinp already checks whether the discard_granularity of the data
device is a factor of the thin-pool block size.  But when using the
dm-thin-pool's discard passdown support, DM thinp was not selecting the
max of the underlying data device's discard_granularity and the
thin-pool's block size.

Update set_discard_limits() to set discard_granularity to the max of
these values.  This enables blkdev_issue_discard() to properly align the
discards that are sent to the DM thin device on a full block boundary.
As such each discard will now cover an entire DM thin-pool block and the
block will be reclaimed.

Reported-by: Zdenek Kabelac 
Signed-off-by: Lukas Czerner 
Signed-off-by: Mike Snitzer 
Cc: stable@vger.kernel.org

dm thin: return ENOSPC instead of EIO when error_if_no_space enabled

2014-06-03T17:44:08+00:00

Update the DM thin provisioning target's allocation failure error to be
consistent with commit a9d6ceb8 ("[SCSI] return ENOSPC on thin
provisioning failure").

The DM thin target now returns -ENOSPC rather than -EIO when
block allocation fails due to the pool being out of data space (and
the 'error_if_no_space' thin-pool feature is enabled).

Signed-off-by: Mike Snitzer 
Acked-By: Joe Thornber

dm thin: cleanup noflush_work to use a proper completion

2014-06-03T17:44:07+00:00

Factor out a pool_work interface that noflush_work makes use of to wait
for and complete work items (in terms of a proper completion struct).
Allows discontinuing the use of a custom completion in terms of atomic_t
and wait_event.

Signed-off-by: Joe Thornber 
Signed-off-by: Mike Snitzer

dm thin: add 'no_space_timeout' dm-thin-pool module param

2014-05-20T18:30:36+00:00

Commit 85ad643b ("dm thin: add timeout to stop out-of-data-space mode
holding IO forever") introduced a fixed 60 second timeout.  Users may
want to either disable or modify this timeout.

Allow the out-of-data-space timeout to be configured using the
'no_space_timeout' dm-thin-pool module param.  Setting it to 0 will
disable the timeout, resulting in IO being queued until more data space
is added to the thin-pool.

Signed-off-by: Mike Snitzer 
Cc: stable@vger.kernel.org # 3.14+

dm thin: add timeout to stop out-of-data-space mode holding IO forever

2014-05-14T20:11:37+00:00

If the pool runs out of data space, dm-thin can be configured to
either error IOs that would trigger provisioning, or hold those IOs
until the pool is resized.  Unfortunately, holding IOs until the pool is
resized can result in a cascade of tasks hitting the hung_task_timeout,
which may render the system unavailable.

Add a fixed timeout so IOs can only be held for a maximum of 60 seconds.
If LVM is going to resize a thin-pool that is out of data space it needs
to be prompt about it.

Signed-off-by: Joe Thornber 
Signed-off-by: Mike Snitzer 
Cc: stable@vger.kernel.org # 3.14+

dm thin: allow metadata commit if pool is in PM_OUT_OF_DATA_SPACE mode

2014-05-14T20:11:36+00:00

Commit 3e1a0699 ("dm thin: fix out of data space handling") introduced
a regression in the metadata commit() method by returning an error if
the pool is in PM_OUT_OF_DATA_SPACE mode.  This oversight caused a thin
device to return errors even if the default queue_if_no_space ENOSPC
handling mode is used.

Fix commit() to only fail if pool is in PM_READ_ONLY or PM_FAIL mode.

Reported-by: qindehua@163.com
Signed-off-by: Joe Thornber 
Signed-off-by: Mike Snitzer 
Cc: stable@vger.kernel.org # 3.14+

dm thin: use INIT_WORK_ONSTACK in noflush_work to avoid ODEBUG warning

2014-04-29T15:22:04+00:00

Use INIT_WORK_ONSTACK to silence "ODEBUG: object is on stack, but not
annotated".

Reported-by: Zdeněk Kabeláč 
Signed-off-by: Mike Snitzer 
Acked-by: Joe Thornber