linux.git/drivers/md/dm-crypt.c, branch v2.6.24

dm crypt: use bio_add_page

2007-12-20T17:32:13+00:00

Fix possible max_phys_segments violation in cloned dm-crypt bio.

In write operation dm-crypt needs to allocate new bio request
and run crypto operation on this clone. Cloned request has always
the same size, but number of physical segments can be increased
and violate max_phys_segments restriction.

This can lead to data corruption and serious hardware malfunction.
This was observed when using XFS over dm-crypt and at least
two HBA controller drivers (arcmsr, cciss) recently.

Fix it by using bio_add_page() call (which tests for other
restrictions too) instead of constructing own biovec.

All versions of dm-crypt are affected by this bug.

Cc: stable@kernel.org
Cc:  dm-crypt@saout.de
Signed-off-by: Milan Broz 
Signed-off-by: Alasdair G Kergon

dm crypt: fix write endio

2007-12-20T17:32:10+00:00

Fix BIO_UPTODATE test for write io.

Cc: stable@kernel.org
Cc: dm-crypt@saout.de
Signed-off-by: Milan Broz 
Signed-off-by: Alasdair G Kergon

[CRYPTO] users: Fix up scatterlist conversion errors

2007-10-27T07:52:07+00:00

This patch fixes the errors made in the users of the crypto layer during
the sg_init_table conversion.  It also adds a few conversions that were
missing altogether.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

SG: Change sg_set_page() to take length and offset argument

2007-10-24T09:20:47+00:00

Most drivers need to set length and offset as well, so may as well fold
those three lines into one.

Add sg_assign_page() for those two locations that only needed to set
the page, where the offset/length is set outside of the function context.

Signed-off-by: Jens Axboe

[SG] Update drivers to use sg helpers

2007-10-22T19:19:53+00:00

Signed-off-by: Jens Axboe

Merge git://git.kernel.org/pub/scm/linux/kernel/git/bunk/trivial

2007-10-20T03:36:17+00:00

* git://git.kernel.org/pub/scm/linux/kernel/git/bunk/trivial: (74 commits)
  fix do_sys_open() prototype
  sysfs: trivial: fix sysfs_create_file kerneldoc spelling mistake
  Documentation: Fix typo in SubmitChecklist.
  Typo: depricated -> deprecated
  Add missing profile=kvm option to Documentation/kernel-parameters.txt
  fix typo about TBI in e1000 comment
  proc.txt: Add /proc/stat field
  small documentation fixes
  Fix compiler warning in smount example program from sharedsubtree.txt
  docs/sysfs: add missing word to sysfs attribute explanation
  documentation/ext3: grammar fixes
  Documentation/java.txt: typo and grammar fixes
  Documentation/filesystems/vfs.txt: typo fix
  include/asm-*/system.h: remove unused set_rmb(), set_wmb() macros
  trivial copy_data_pages() tidy up
  Fix typo in arch/x86/kernel/tsc_32.c
  file link fix for Pegasus USB net driver help
  remove unused return within void return function
  Typo fixes retrun -> return
  x86 hpet.h: remove broken links
  ...

dm crypt: tidy pending

2007-10-20T01:01:28+00:00

Add crypt prefix to dec_pending to avoid confusing it in backtraces with
the dm core function of the same name.

No functional change here.

Signed-off-by: Milan Broz 
Signed-off-by: Alasdair G Kergon

dm crypt: tidy labels

2007-10-20T01:01:17+00:00

Replace numbers with names in labels in error paths, to avoid confusion
when new one get added between existing ones.

Signed-off-by: Milan Broz 
Signed-off-by: Alasdair G Kergon

dm crypt: tidy whitespace

2007-10-20T01:01:15+00:00

Clean up, convert some spaces to tabs.

No functional change here.

Signed-off-by: Milan Broz 
Signed-off-by: Alasdair G Kergon

dm crypt: add post processing queue

2007-10-20T01:01:14+00:00

Add post-processing queue (per crypt device) for read operations.

Current implementation uses only one queue for all operations
and this can lead to starvation caused by many requests waiting
for memory allocation. But the needed memory-releasing operation
is queued after these requests (in the same queue).

Signed-off-by: Milan Broz 
Signed-off-by: Herbert Xu 
Signed-off-by: Alasdair G Kergon