linux.git/drivers/md/bcache, branch v4.19-rc2

bcache: release dc->writeback_lock properly in bch_writeback_thread()

2018-08-22T21:06:29+00:00

The writeback thread would exit with a lock held when the cache device
is detached via sysfs interface, fix it by releasing the held lock
before exiting the while-loop.

Fixes: fadd94e05c02 (bcache: quit dc->writeback_thread when BCACHE_DEV_DETACHING is set)
Signed-off-by: Shan Hai 
Signed-off-by: Coly Li 
Tested-by: Shenghui Wang 
Cc: stable@vger.kernel.org #4.17+
Signed-off-by: Jens Axboe

Merge tag 'for-4.19/post-20180822' of git://git.kernel.dk/linux-block

2018-08-22T20:38:05+00:00

Pull more block updates from Jens Axboe:

 - Set of bcache fixes and changes (Coly)

 - The flush warn fix (me)

 - Small series of BFQ fixes (Paolo)

 - wbt hang fix (Ming)

 - blktrace fix (Steven)

 - blk-mq hardware queue count update fix (Jianchao)

 - Various little fixes

* tag 'for-4.19/post-20180822' of git://git.kernel.dk/linux-block: (31 commits)
  block/DAC960.c: make some arrays static const, shrinks object size
  blk-mq: sync the update nr_hw_queues with blk_mq_queue_tag_busy_iter
  blk-mq: init hctx sched after update ctx and hctx mapping
  block: remove duplicate initialization
  tracing/blktrace: Fix to allow setting same value
  pktcdvd: fix setting of 'ret' error return for a few cases
  block: change return type to bool
  block, bfq: return nbytes and not zero from struct cftype .write() method
  block, bfq: improve code of bfq_bfqq_charge_time
  block, bfq: reduce write overcharge
  block, bfq: always update the budget of an entity when needed
  block, bfq: readd missing reset of parent-entity service
  blk-wbt: fix IO hang in wbt_wait()
  block: don't warn for flush on read-only device
  bcache: add the missing comments for smp_mb()/smp_wmb()
  bcache: remove unnecessary space before ioctl function pointer arguments
  bcache: add missing SPDX header
  bcache: move open brace at end of function definitions to next line
  bcache: add static const prefix to char * array declarations
  bcache: fix code comments style
  ...

bcache: use routines from lib/crc64.c for CRC64 calculation

2018-08-22T17:52:48+00:00

Now we have crc64 calculation in lib/crc64.c, it is unnecessary for
bcache to use its own version.  This patch changes bcache code to use
crc64 routines in lib/crc64.c.

Link: http://lkml.kernel.org/r/20180718165545.1622-3-colyli@suse.de
Signed-off-by: Coly Li 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Andy Shevchenko 
Cc: Michael Lyle 
Cc: Kent Overstreet 
Cc: Thomas Gleixner 
Cc: Kate Stewart 
Cc: Randy Dunlap 
Cc: Eric Biggers 
Cc: Greg Kroah-Hartman 
Cc: Noah Massey 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

bcache: add the missing comments for smp_mb()/smp_wmb()

2018-08-11T21:46:42+00:00

Checkpatch.pl warns there are 2 locations of smp_mb() and smp_wmb()
without code comment. This patch adds the missing code comments for
these memory barrier calls.

Signed-off-by: Coly Li 
Reviewed-by: Shenghui Wang 
Signed-off-by: Jens Axboe

bcache: remove unnecessary space before ioctl function pointer arguments

2018-08-11T21:46:42+00:00

This is warned by checkpatch.pl, this patch removes the extra space.

Signed-off-by: Coly Li 
Reviewed-by: Shenghui Wang 
Signed-off-by: Jens Axboe

bcache: add missing SPDX header

2018-08-11T21:46:42+00:00

The SPDX header is missing fro closure.c, super.c and util.c, this
patch adds SPDX header for GPL-2.0 into these files.

Signed-off-by: Coly Li 
Reviewed-by: Shenghui Wang 
Signed-off-by: Jens Axboe

bcache: move open brace at end of function definitions to next line

2018-08-11T21:46:42+00:00

This is not a preferred style to place open brace '{' at the end of
function definition, checkpatch.pl reports error for such coding
style. This patch moves them into the start of the next new line.

Signed-off-by: Coly Li 
Reviewed-by: Shenghui Wang 
Signed-off-by: Jens Axboe

bcache: add static const prefix to char * array declarations

2018-08-11T21:46:42+00:00

This patch declares char * array with const prefix in sysfs.c,
which is suggested by checkpatch.pl.

Signed-off-by: Coly Li 
Reviewed-by: Shenghui Wang 
Signed-off-by: Jens Axboe

bcache: fix code comments style

2018-08-11T21:46:42+00:00

This patch fixes 3 style issues warned by checkpatch.pl,
- Comment lines are not aligned
- Comments use "/*" on subsequent lines
- Comment lines use a trailing "*/"

Signed-off-by: Coly Li 
Reviewed-by: Shenghui Wang 
Signed-off-by: Jens Axboe

bcache: do not check NULL pointer before calling kmem_cache_destroy

2018-08-11T21:46:42+00:00

kmem_cache_destroy() is safe for NULL pointer as input, the NULL pointer
checking is unncessary. This patch just removes the NULL pointer checking
to make code simpler.

Signed-off-by: Coly Li 
Reviewed-by: Shenghui Wang 
Signed-off-by: Jens Axboe