linux.git/drivers/md/bcache/super.c, branch v5.1

bcache: fix indentation issue, remove tabs on a hunk of code

2019-02-09T14:18:31+00:00

There is a hunk of code that is indented one level too deep, fix this
by removing the extra tabs.

Signed-off-by: Colin Ian King 
Signed-off-by: Coly Li 
Signed-off-by: Jens Axboe

bcache: make cutoff_writeback and cutoff_writeback_sync tunable

2018-12-13T15:15:54+00:00

Currently the cutoff writeback and cutoff writeback sync thresholds are
defined by CUTOFF_WRITEBACK (40) and CUTOFF_WRITEBACK_SYNC (70) as
static values. Most of time these they work fine, but when people want
to do research on bcache writeback mode performance tuning, there is no
chance to modify the soft and hard cutoff writeback values.

This patch introduces two module parameters bch_cutoff_writeback_sync
and bch_cutoff_writeback which permit people to tune the values when
loading bcache.ko. If they are not specified by module loading, current
values CUTOFF_WRITEBACK_SYNC and CUTOFF_WRITEBACK will be used as
default and nothing changes.

When people want to tune this two values,
- cutoff_writeback can be set in range [1, 70]
- cutoff_writeback_sync can be set in range [1, 90]
- cutoff_writeback always <= cutoff_writeback_sync

The default values are strongly recommended to most of users for most of
workloads. Anyway, if people wants to take their own risk to do research
on new writeback cutoff tuning for their own workload, now they can make
it.

Signed-off-by: Coly Li 
Signed-off-by: Jens Axboe

bcache: add MODULE_DESCRIPTION information

2018-12-13T15:15:54+00:00

This patch moves MODULE_AUTHOR and MODULE_LICENSE to end of super.c, and
add MODULE_DESCRIPTION("Bcache: a Linux block layer cache").

This is preparation for adding module parameters.

Signed-off-by: Coly Li 
Signed-off-by: Jens Axboe

bcache: do not check if debug dentry is ERR or NULL explicitly on remove

2018-12-13T15:15:54+00:00

debugfs_remove and debugfs_remove_recursive will check if the dentry
pointer is NULL or ERR, and will do nothing in that case.

Remove the check in cache_set_free and bch_debug_init.

Signed-off-by: Shenghui Wang 
Signed-off-by: Coly Li 
Signed-off-by: Jens Axboe

bcache: panic fix for making cache device

2018-10-08T14:19:59+00:00

when the nbuckets of cache device is smaller than 1024, making cache
device will trigger BUG_ON in kernel, add a condition to avoid this.

Reported-by: nitroxis 
Signed-off-by: Dongbo Cao 
Signed-off-by: Coly Li 
Signed-off-by: Jens Axboe

bcache: split combined if-condition code into separate ones

2018-10-08T14:19:57+00:00

Split the combined '||' statements in if() check, to make the code easier
for debug.

Signed-off-by: Dongbo Cao 
Signed-off-by: Coly Li 
Signed-off-by: Jens Axboe

bcache: remove useless parameter of bch_debug_init()

2018-10-08T14:19:53+00:00

Parameter "struct kobject *kobj" in bch_debug_init() is useless,
remove it in this patch.

Signed-off-by: Dongbo Cao 
Signed-off-by: Coly Li 
Signed-off-by: Jens Axboe

bcache: recal cached_dev_sectors on detach

2018-10-08T14:19:50+00:00

Recal cached_dev_sectors on cached_dev detached, as recal done on
cached_dev attached.

Update the cached_dev_sectors before bcache_device_detach called
as bcache_device_detach will set bcache_device->c to NULL.

Signed-off-by: Shenghui Wang 
Signed-off-by: Coly Li 
Signed-off-by: Jens Axboe

bcache: correct dirty data statistics

2018-10-08T14:19:45+00:00

When bcache device is clean, dirty keys may still exist after
journal replay, so we need to count these dirty keys even
device in clean status, otherwise after writeback, the amount
of dirty data would be incorrect.

Signed-off-by: Tang Junhui 
Cc: stable@vger.kernel.org
Signed-off-by: Coly Li 
Signed-off-by: Jens Axboe

bcache: fix ioctl in flash device

2018-10-08T14:19:42+00:00

When doing ioctl in flash device, it will call ioctl_dev() in super.c,
then we should not to get cached device since flash only device has
no backend device. This patch just move the jugement dc->io_disable
to cached_dev_ioctl() to make ioctl in flash device correctly.

Fixes: 0f0709e6bfc3c ("bcache: stop bcache device when backing device is offline")
Signed-off-by: Tang Junhui 
Cc: stable@vger.kernel.org
Signed-off-by: Coly Li 
Signed-off-by: Jens Axboe