linux.git/drivers/macintosh/rack-meter.c, branch for-next

powerpc/macio: Make remove callback of macio driver void returned

2024-03-07T12:06:19+00:00

Commit fc7a6209d571 ("bus: Make remove callback return void") forces
bus_type::remove be void-returned, it doesn't make much sense for any
bus based driver implementing remove callbalk to return non-void to
its caller.

This change is for macio bus based drivers.

Signed-off-by: Dawei Li 
Acked-by: Damien Le Moal 
Acked-by: Jakub Kicinski 
Signed-off-by: Michael Ellerman 
Link: https://msgid.link/TYCP286MB232391520CB471E7C8D6EA84CAD19@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM

macintosh: Use of_property_present() for testing DT property presence

2023-03-30T12:36:35+00:00

It is preferred to use typed property access functions (i.e.
of_property_read_ functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring 
Signed-off-by: Michael Ellerman 
Link: https://msgid.link/20230310144735.1546817-1-robh@kernel.org

macintosh: Prepare cleanup of powerpc's asm/prom.h

2022-05-11T13:06:39+00:00

powerpc's asm/prom.h brings some headers that it doesn't
need itself.

In order to clean it up, first add missing headers in
users of asm/prom.h

Signed-off-by: Christophe Leroy 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/04961364547fe4556e30cb302b0e20a939b83426.1648833027.git.christophe.leroy@csgroup.eu

rackmeter: Use vtime aware kcpustat accessor

2019-11-21T06:59:00+00:00

Now that we have a vtime safe kcpustat accessor, use it to fetch
CPUTIME_NICE and fix frozen kcpustat values on nohz_full CPUs.

Reported-by: Yauheni Kaliuta 
Signed-off-by: Frederic Weisbecker 
Cc: Benjamin Herrenschmidt 
Cc: Peter Zijlstra 
Cc: Wanpeng Li 
Link: https://lkml.kernel.org/r/20191121024430.19938-7-frederic@kernel.org
Signed-off-by: Ingo Molnar

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 246

2019-06-19T15:09:08+00:00

Based on 1 normalized pattern(s):

  released under the term of the gnu gpl v2

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 16 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Allison Randal 
Reviewed-by: Enrico Weigelt 
Reviewed-by: Alexios Zavras 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190602204654.922331175@linutronix.de
Signed-off-by: Greg Kroah-Hartman

macintosh: Use of_node_name_{eq, prefix} for node name comparisons

2018-12-22T10:29:56+00:00

Convert string compares of DT node names to use of_node_name_{eq,prefix}
helpers instead. This removes direct access to the node name pointer.

This changes a single case insensitive node name comparison to case
sensitive for "ata4". This is the only instance of a case insensitive
comparison for all the open coded node name comparisons on powerpc.
Searching the commit history, there doesn't appear to be any reason for
it to be case insensitive.

A couple of open coded iterating thru the child node names are converted
to use for_each_child_of_node() instead.

Signed-off-by: Rob Herring 
Signed-off-by: Michael Ellerman

drivers: macintosh: rack-meter: really fix bogus memsets

2018-03-30T13:10:35+00:00

We should zero an array using sizeof instead of number of elements.

Fixes the following compiler (GCC 7.3.0) warnings:

drivers/macintosh/rack-meter.c: In function 'rackmeter_do_pause':
drivers/macintosh/rack-meter.c:157:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
drivers/macintosh/rack-meter.c:158:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]

Fixes: 4f7bef7a9f69 ("drivers: macintosh: rack-meter: fix bogus memsets")
Reported-by: Stephen Rothwell 
Signed-off-by: Aaro Koskinen 
Signed-off-by: Michael Ellerman

powerpc: Use sizeof(*foo) rather than sizeof(struct foo)

2018-03-20T05:47:53+00:00

It's slightly less error prone to use sizeof(*foo) rather than
specifying the type.

Signed-off-by: Markus Elfring 
[mpe: Consolidate into one patch, rewrite change log]
Signed-off-by: Michael Ellerman

macintosh: Convert to using %pOF instead of full_name

2017-09-01T06:42:52+00:00

Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.

Signed-off-by: Rob Herring 
[mpe: Also convert the two cases inside #if 0]
Signed-off-by: Michael Ellerman

macintosh/rack-meter: Make of_device_ids const

2017-08-21T07:21:34+00:00

of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by  work with const
of_device_ids. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
    407	    576	      0	    983	    3d7	drivers/macintosh/rack-meter.o

File size after constify rackmeter_match.
   text	   data	    bss	    dec	    hex	filename
    807	    176	      0	    983	    3d7	drivers/macintosh/rack-meter.o

Signed-off-by: Arvind Yadav 
Signed-off-by: Michael Ellerman