linux.git/drivers/lightnvm/pblk-write.c, branch v4.20

lightnvm: pblk: encapsulate rb pointer operations

2018-10-09T14:25:08+00:00

pblk's read/write buffer is always a power-of-2, thus wrapping up the
buffer can be done with a bit mask. Since this is an implementation
detail internal to the write buffer, make a helper that hides pointer
increment + wrap, and allows to transparently relax this assumption in
the future.

Signed-off-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: add SPDX license tag

2018-10-09T14:25:08+00:00

Add GLP-2.0 SPDX license tag to all pblk files

Signed-off-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: encapsulate rqd dma allocations

2018-10-09T14:25:07+00:00

dma allocations for ppa_list and meta_list in rqd are replicated in
several places across the pblk codebase. Make helpers to encapsulate
creation and deletion to simplify the code.

Signed-off-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: fix mapping issue on failed writes

2018-10-09T14:25:07+00:00

On 1.2-devices, the mapping-out of remaning sectors in the
failed-write's block can result in an infinite loop,
stalling the write pipeline, fix this.

Fixes: 6a3abf5beef6 ("lightnvm: pblk: rework write error recovery path")
Signed-off-by: Hans Holmberg 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: add trace events for chunk states

2018-10-09T14:25:07+00:00

Introduce trace points for tracking chunk states in pblk - this is
useful for inspection of the entire state of the drive, and real handy
for both fw and pblk debugging.

Signed-off-by: Hans Holmberg 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: remove debug from pblk_[down/up]_page

2018-10-09T14:25:07+00:00

Remove the debug only iteration within __pblk_down_page, which
then allows us to reduce the number of arguments down to pblk and
the parallel unit from the functions that calls it. Simplifying the
callers logic considerably.

Also, rename the functions pblk_[down/up]_page to
pblk_[down/up]_chunk, to communicate that it manages the write
pointer of the chunk. Note that it also protects the parallel unit
such that at most one chunk is active per parallel unit.

Signed-off-by: Matias Bjørling 
Reviewed-by: Javier González 
Signed-off-by: Jens Axboe

lightnvm: pblk: remove unused parameters in pblk_up_rq

2018-10-09T14:25:07+00:00

The parameters nr_ppas and ppa_list are not used, so remove them.

Signed-off-by: Hans Holmberg 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: introduce nvm_rq_to_ppa_list

2018-10-09T14:25:07+00:00

There is a number of places in the lightnvm subsystem where the user
iterates over the ppa list. Before iterating, the user must know if it
is a single or multiple LBAs due to vector commands using either the
nvm_rq ->ppa_addr or ->ppa_list fields on command submission, which
leads to open-coding the if/else statement.

Instead of having multiple if/else's, move it into a function that can
be called by its users.

A nice side effect of this cleanup is that this patch fixes up a
bunch of cases where we don't consider the single-ppa case in pblk.

Signed-off-by: Hans Holmberg 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: fix comment typo

2018-10-09T14:25:06+00:00

Fix comment typo Decrese -> Decrease

Signed-off-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: improve line helpers

2018-10-09T14:25:06+00:00

The current helper to obtain a line from a ppa returns the line id,
which requires its users to explicitly retrieve the pointer to the line
with the id.

Make 2 different helpers: one returning the line id and one returning
the line directly.

Signed-off-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe