linux.git/drivers/leds/led-class.c, branch v6.5

leds: Replace all non-returning strlcpy with strscpy

2023-05-25T11:31:55+00:00

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh 
Reviewed-by: Kees Cook 
Link: https://lore.kernel.org/r/20230523021451.2406362-1-azeemshaikh38@gmail.com
Signed-off-by: Lee Jones

driver core: class: remove module * from class_create()

2023-03-17T14:16:33+00:00

The module pointer in class_create() never actually did anything, and it
shouldn't have been requred to be set as a parameter even if it did
something.  So just remove it and fix up all callers of the function in
the kernel tree at the same time.

Cc: "Rafael J. Wysocki" 
Acked-by: Benjamin Tissoires 
Link: https://lore.kernel.org/r/20230313181843.1207845-4-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman

leds: led-core: Fix refcount leak in of_led_get()

2023-01-30T08:03:13+00:00

class_find_device_by_of_node() calls class_find_device(), it will take
the reference, use the put_device() to drop the reference when not need
anymore.

Fixes: 699a8c7c4bd3 ("leds: Add of_led_get() and led_put()")
Signed-off-by: Miaoqian Lin 
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/20221220121807.1543790-1-linmq006@gmail.com

leds: led-class: Add generic [devm_]led_get()

2023-01-27T11:07:11+00:00

Add a generic [devm_]led_get() method which can be used on both devicetree
and non devicetree platforms to get a LED classdev associated with
a specific function on a specific device, e.g. the privacy LED associated
with a specific camera sensor.

Note unlike of_led_get() this takes a string describing the function
rather then an index. This is done because e.g. camera sensors might
have a privacy LED, or a flash LED, or both and using an index
approach leaves it unclear what the function of index 0 is if there is
only 1 LED.

This uses a lookup-table mechanism for non devicetree platforms.
This allows the platform code to map specific LED class_dev-s to a specific
device,function combinations this way.

For devicetree platforms getting the LED by function-name could be made
to work using the standard devicetree pattern of adding a -names string
array to map names to the indexes.

Reviewed-by: Linus Walleij 
Signed-off-by: Hans de Goede 
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/20230120114524.408368-5-hdegoede@redhat.com

leds: led-class: Add __devm_led_get() helper

2023-01-27T11:06:42+00:00

Add a __devm_led_get() helper which registers a passed in led_classdev
with devm for unregistration.

This is a preparation patch for adding a generic (non devicetree specific)
devm_led_get() function.

Reviewed-by: Andy Shevchenko 
Reviewed-by: Linus Walleij 
Signed-off-by: Hans de Goede 
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/20230120114524.408368-4-hdegoede@redhat.com

leds: led-class: Add led_module_get() helper

2023-01-27T11:06:17+00:00

Split out part of of_led_get() into a generic led_module_get() helper
function.

This is a preparation patch for adding a generic (non devicetree specific)
led_get() function.

Reviewed-by: Andy Shevchenko 
Reviewed-by: Linus Walleij 
Signed-off-by: Hans de Goede 
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/20230120114524.408368-3-hdegoede@redhat.com

leds: led-class: Add missing put_device() to led_put()

2023-01-27T11:06:03+00:00

led_put() is used to "undo" a successful of_led_get() call,
of_led_get() uses class_find_device_by_of_node() which returns
a reference to the device which must be free-ed with put_device()
when the caller is done with it.

Add a put_device() call to led_put() to free the reference returned
by class_find_device_by_of_node().

And also add a put_device() in the error-exit case of try_module_get()
failing.

Fixes: 699a8c7c4bd3 ("leds: Add of_led_get() and led_put()")
Reviewed-by: Andy Shevchenko 
Reviewed-by: Linus Walleij 
Signed-off-by: Hans de Goede 
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/20230120114524.408368-2-hdegoede@redhat.com

leds: led-core: Update fwnode with device_set_node

2022-01-12T18:43:14+00:00

Update a newly created device's fwnode and of_node pointers using the
recently added device_set_node helper. This keeps some firmware node
specifics out of led-class and should help tracking future changes
regarding device firmware node updates.

Signed-off-by: Sander Vanheule 
Signed-off-by: Pavel Machek

leds: leds-core: Implement the retain-state-shutdown property

2021-08-20T09:00:06+00:00

Read the retain-state-shutdown device tree property to set the
existing LED_RETAIN_AT_SHUTDOWN flag. Then check the flag when
unregistering, and if set, don't set the brightness to OFF. This
is useful for systems that want to keep the HW state of the LED
across reboots.

Signed-off-by: Eddie James 
Signed-off-by: Pavel Machek

leds: class: The -ENOTSUPP should never be seen by user space

2021-05-28T09:59:59+00:00

Drop the bogus error code and let of_led_get() to take care about absent
of_node.

Fixes: e389240ad992 ("leds: Add managed API to get a LED from a device driver")
Cc: Jean-Jacques Hiblot 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Pavel Machek