linux.git/drivers/leds/led-class.c, branch v4.1

leds: Don't treat the LED name as a format string

2015-03-30T21:26:32+00:00

The LED name was wrongly interpreted as format string. Stop doing that.

Signed-off-by: Sakari Ailus 
Signed-off-by: Bryan Wu 
Signed-off-by: Ricardo Ribalda Delgado

leds: Use log level warn instead of info when telling about a name clash

2015-03-30T21:26:25+00:00

The LED names are expected to be unique in the system. Use KERN_WARNING log
level to notify the user about the matter.

Signed-off-by: Sakari Ailus 
Signed-off-by: Bryan Wu 
Signed-off-by: Ricardo Ribalda Delgado

leds/led-class: Handle LEDs with the same name

2015-03-30T18:55:57+00:00

The current code expected that every LED had an unique name. This is a
legit expectation when the device tree can no be modified or extended.
But with device tree overlays this requirement can be easily broken.

This patch finds out if the name is already in use and adds the suffix
_1, _2... if not.

Signed-off-by: Ricardo Ribalda Delgado 
Reported-by: Geert Uytterhoeven 
Signed-off-by: Bryan Wu

leds: Introduce devres helper for led_classdev_register

2015-03-09T20:43:41+00:00

(cooloney@gmail.com: add _unregister function into the document)

Suggested-by: Stephen Boyd 
Signed-off-by: Bjorn Andersson 
Signed-off-by: Bryan Wu

leds: Add LED Flash class extension to the LED subsystem

2015-01-26T22:59:08+00:00

Some LED devices support two operation modes - torch and flash.
This patch provides support for flash LED devices in the LED subsystem
by introducing new sysfs attributes and kernel internal interface.
The attributes being introduced are: flash_brightness, flash_strobe,
flash_timeout, max_flash_timeout, max_flash_brightness, flash_fault,
flash_sync_strobe and available_sync_leds. All the flash related
features are placed in a separate module.

The modifications aim to be compatible with V4L2 framework requirements
related to the flash devices management. The design assumes that V4L2
sub-device can take of the LED class device control and communicate
with it through the kernel internal interface. When V4L2 Flash sub-device
file is opened, the LED class device sysfs interface is made
unavailable.

Signed-off-by: Jacek Anaszewski 
Acked-by: Kyungmin Park 
Cc: Richard Purdie 
Acked-by: Pavel Machek 
Signed-off-by: Bryan Wu

leds: Use setup_timer

2015-01-14T18:40:20+00:00

Convert a call to init_timer and accompanying intializations of
the timer's data and function fields to a call to setup_timer.

A simplified version of the semantic match that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// 
@@
expression t,f,d;
@@

-init_timer(&t);
+setup_timer(&t,f,d);
-t.function = f;
-t.data = d;
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Bryan Wu

leds: Add support for setting brightness in a synchronous way

2014-11-14T22:29:35+00:00

There are use cases when setting a LED brightness has to
have immediate effect (e.g. setting a torch LED brightness).
This patch extends LED subsystem to support such operations.
The LED subsystem internal API __led_set_brightness is changed
to led_set_brightness_async and new led_set_brightness_sync API
is added.

Signed-off-by: Jacek Anaszewski 
Acked-by: Kyungmin Park 
Cc: Richard Purdie 
Signed-off-by: Bryan Wu

leds: implement sysfs interface locking mechanism

2014-11-14T22:29:35+00:00

Add a mechanism for locking LED subsystem sysfs interface.
This patch prepares ground for addition of LED Flash Class
extension, whose API will be integrated with V4L2 Flash API.
Such a fusion enforces introducing a locking scheme, which
will secure consistent access to the LED Flash Class device.

The mechanism being introduced allows for disabling LED
subsystem sysfs interface by calling led_sysfs_disable function
and enabling it by calling led_sysfs_enable. The functions
alter the LED_SYSFS_DISABLE flag state and must be called
under mutex lock. The state of the lock is checked with use
of led_sysfs_is_disabled function. Such a design allows for
providing immediate feedback to the user space on whether
the LED Flash Class device is available or is under V4L2 Flash
sub-device control.

Signed-off-by: Jacek Anaszewski 
Acked-by: Kyungmin Park 
Cc: Richard Purdie 
Signed-off-by: Bryan Wu

leds: Improve and export led_update_brightness

2014-09-12T21:01:54+00:00

led_update_brightness helper function used to be exploited only locally
in the led-class.c module, where its result was being passed to the
brightness_show sysfs callback. With the introduction of v4l2-flash
subdevice the same functionality becomes required for reading current
brightness from a LED device. This patch adds checking of return value
of the brightness_get callback and moves the led_update_brightness()
function to the LED subsystem public API.

Signed-off-by: Jacek Anaszewski 
Acked-by: Kyungmin Park 
Cc: Richard Purdie 
Signed-off-by: Bryan Wu

leds: avoid using DEVICE_ATTR macro for max_brightness attribute

2014-09-11T23:55:26+00:00

Make definition of the brightness related sysfs attributes
consistent. The modification entails change of the function
name: led_max_brightness_show -> max_brightness_show

Signed-off-by: Jacek Anaszewski 
Acked-by: Sakari Ailus 
Acked-by: Kyungmin Park 
Cc: Richard Purdie 
Signed-off-by: Bryan Wu