linux.git/drivers/leds/blink, branch v5.19

leds: lgm-sso: Get rid of duplicate of_node assignment

2022-01-12T18:43:15+00:00

GPIO library does copy the of_node from the parent device of
the GPIO chip, there is no need to repeat this in the individual
drivers. Remove assignment here.

For the details one may look into the of_gpio_dev_init() implementation.

Call graph:
   --> sso_gpio_gc_init()
     --> devm_gpiochip_add_data
       --> devm_gpiochip_add_data_with_key
         --> gpiochip_add_data_with_key()
           --> of_gpio_dev_init()

Signed-off-by: Andy Shevchenko 
Signed-off-by: Pavel Machek

leds: lgm-sso: Propagate error codes from callee to caller

2021-08-07T07:12:45+00:00

The one of the latest change to the driver reveals the problem that
the error codes from callee aren't propagated to the caller of
__sso_led_dt_parse(). Fix this accordingly.

Fixes: 9999908ca1ab ("leds: lgm-sso: Put fwnode in any case during ->probe()")
Fixes: c3987cd2bca3 ("leds: lgm: Add LED controller driver for LGM SoC")
Reported-by: kernel test robot 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Pavel Machek

leds: lgm-sso: Convert to use list_for_each_entry*() API

2021-08-03T21:46:12+00:00

Convert to use list_for_each_entry*() API insted of open coded variants.
It saves few lines of code and makes iteasier to read and maintain.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Pavel Machek

leds: lgm-sso: Remove explicit managed GPIO resource cleanup

2021-08-03T21:46:12+00:00

The idea of managed resources is that they will be cleaned up automatically
and in the proper order. Remove explicit GPIO cleanup.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Pavel Machek

leds: lgm-sso: Don't spam logs when probe is deferred

2021-08-03T21:46:11+00:00

When requesting GPIO line the probe can be deferred.
In such case don't spam logs with an error message.
This can be achieved by switching to dev_err_probe().

Fixes: c3987cd2bca3 ("leds: lgm: Add LED controller driver for LGM SoC")
Cc: Amireddy Mallikarjuna reddy 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Pavel Machek

leds: lgm-sso: Put fwnode in any case during ->probe()

2021-08-03T21:46:10+00:00

fwnode_get_next_child_node() bumps a reference counting of a returned variable.
We have to balance it whenever we return to the caller.

All the same in fwnode_for_each_child_node() case.

Fixes: c3987cd2bca3 ("leds: lgm: Add LED controller driver for LGM SoC")
Cc: Amireddy Mallikarjuna reddy 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Pavel Machek

leds: lgm: Fix up includes

2021-06-23T22:55:41+00:00

This driver is including the legacy GPIO header 
but the only thing it is using from that header is the wrong
define for GPIOF_DIR_OUT.

Fix it up by using GPIO_LINE_DIRECTION_OUT and including the
correct consumer and driver headers.

Cc: Amireddy Mallikarjuna reddy 
Signed-off-by: Linus Walleij 
Signed-off-by: Pavel Machek

leds: lgm-sso: Drop duplicate NULL check for GPIO operations

2021-05-28T10:00:01+00:00

Since GPIO operations are NULL-aware, we don't need to duplicate
this check. Remove it and fold the rest of the code.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Pavel Machek

leds: lgm-sso: Remove unneeded of_match_ptr()

2021-05-28T10:00:00+00:00

LGM SSO is an OF dependent driver, so of_match_ptr() can be safely
removed.

Remove the unneeded of_match_ptr().

Signed-off-by: Andy Shevchenko 
Signed-off-by: Pavel Machek

leds: lgm-sso: Fix clock handling

2021-05-28T10:00:00+00:00

The clock handling has a few issues:
 - when getting second clock fails, the first one left prepared and enabled
 - on ->remove() clocks are unprepared and disabled twice

Fix all these by converting to use bulk clock operations since both clocks
are mandatory.

Fixes: c3987cd2bca3 ("leds: lgm: Add LED controller driver for LGM SoC")
Cc: Amireddy Mallikarjuna reddy 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Pavel Machek