linux.git/drivers/interconnect/qcom/qcs404.c, branch v6.2

interconnect: qcom: constify icc_node pointers

2022-04-23T12:11:48+00:00

Pointers to struct qcom_icc_node (and similar structures) are not
modified, so they can be made const for safety.  The contents of struct
qcom_icc_node must stay non-const.

Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20220412102623.227607-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Georgi Djakov

interconnect: qcom: constify qcom_icc_desc

2022-04-23T12:11:35+00:00

struct qcom_icc_desc is not modified so it can be made const for safety.

Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20220412102623.227607-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Georgi Djakov

interconnect: qcs404: expand DEFINE_QNODE macros

2021-10-04T11:13:58+00:00

To follow the example of the rest of icc-rpm.h drivers, expand
DEFINE_QNODE macros in the driver.

Suggested-by: Bjorn Andersson 
Signed-off-by: Dmitry Baryshkov 
Reviewed-by: AngeloGioacchino Del Regno 
Link: https://lore.kernel.org/r/20210903232421.1384199-11-dmitry.baryshkov@linaro.org
Signed-off-by: Georgi Djakov

interconnect: icc-rpm: move bus clocks handling into qnoc_probe

2021-10-04T10:37:47+00:00

All icc-rpm drivers use the same set of bus clocks. Move handling of bus
clocks to qnoc_probe. This both simplifies the code and allows using
qnoc_probe as device's probe function.

Signed-off-by: Dmitry Baryshkov 
Reviewed-by: AngeloGioacchino Del Regno 
Reviewed-by: Marijn Suijten 
Tested-by: Shawn Guo 
Link: https://lore.kernel.org/r/20210903232421.1384199-2-dmitry.baryshkov@linaro.org
Signed-off-by: Georgi Djakov

interconnect: qcom: qcs404: use shared code

2021-01-05T11:10:12+00:00

Use shared code for aggregate functionalities and probe function
to remove duplicated code.

Signed-off-by: Jun Nie 
Link: https://lore.kernel.org/r/20201204075345.5161-3-jun.nie@linaro.org
Signed-off-by: Georgi Djakov

interconnect: qcom: qcs404: Remove GPU and display RPM IDs

2020-11-20T13:52:05+00:00

The following errors are noticed during boot on a QCS404 board:
[    2.926647] qcom_icc_rpm_smd_send mas 6 error -6
[    2.934573] qcom_icc_rpm_smd_send mas 8 error -6

These errors show when we try to configure the GPU and display nodes.
Since these particular nodes aren't supported on RPM and are purely
local, we should just change their mas_rpm_id to -1 to avoid any
requests being sent for these master IDs.

Reviewed-by: Mike Tipton 
Reviewed-by: Bjorn Andersson 
Link: https://lore.kernel.org/r/20201118111044.26056-1-georgi.djakov@linaro.org
Signed-off-by: Georgi Djakov

interconnect: qcom: Use the standard aggregate function

2019-12-16T07:25:24+00:00

Now we have a common function for standard aggregation, so let's use it,
instead of duplicating the code.

Reviewed-by: Brian Masney 
Reviewed-by: Bjorn Andersson 
Reviewed-by: Evan Green 
Signed-off-by: Georgi Djakov

interconnect: qcom: Use the new common helper for node removal

2019-12-16T07:25:23+00:00

There is a new helper function for removing all nodes. Let's use it instead
of duplicating the code.

Reviewed-by: Bjorn Andersson 
Signed-off-by: Georgi Djakov

interconnect: qcom: qcs404: Walk the list safely on node removal

2019-12-12T09:28:53+00:00

As we will remove items off the list using list_del(), we need to use the
safe version of list_for_each_entry().

Fixes: 5e4e6c4d3ae0 ("interconnect: qcom: Add QCS404 interconnect provider driver")
Reported-by: Dmitry Osipenko 
Reviewed-by: Bjorn Andersson 
Signed-off-by: Georgi Djakov 
Cc:  # v5.4
Link: https://lore.kernel.org/r/20191212075332.16202-4-georgi.djakov@linaro.org
Signed-off-by: Greg Kroah-Hartman

interconnect: qcom: Fix icc_onecell_data allocation

2019-10-20T09:09:31+00:00

This is a struct with a trailing zero-length array of icc_node pointers
but it's allocated as if it were a single array of icc_nodes instead.

This allocates too much memory at probe time but shouldn't have any
noticeable effect. Both sdm845 and qcs404 are affected.

Fix by replacing kcalloc with kzalloc and using the "struct_size" macro.

Signed-off-by: Leonard Crestez 
Fixes: 5e4e6c4d3ae0 ("interconnect: qcom: Add QCS404 interconnect provider driver")
Link: https://lore.kernel.org/linux-pm/a7360abb6561917e30bbfaa6084578449152bf1d.1569348056.git.leonard.crestez@nxp.com/
Signed-off-by: Georgi Djakov