linux.git/drivers/input/mouse/synaptics.c, branch v4.17

Input: synaptics - add Lenovo 80 series ids to SMBus

2018-05-23T18:47:04+00:00

This time, Lenovo decided to go with different pieces in its latest
series of Thinkpads.

For those we have been able to test:
- the T480 is using Synaptics with an IBM trackpoint
   -> it behaves properly with or without intertouch, there is no point
      not using RMI4
- the X1 Carbon 6th gen is using Synaptics with an IBM trackpoint
   -> the touchpad doesn't behave properly under PS/2 so we have to
      switch it to RMI4 if we do not want to have disappointed users
- the X280 is using Synaptics with an ALPS trackpoint
   -> the recent fixes in the trackpoint handling fixed it so upstream
      now works fine with or without RMI4, and there is no point not
      using RMI4
- the T480s is using an Elan touchpad, so that's a different story

Cc:  # v4.14.x, v4.15.x, v4.16.x
Signed-off-by: Benjamin Tissoires 
Acked-by: KT Liao 
Signed-off-by: Dmitry Torokhov

Input: synaptics - add Intertouch support on X1 Carbon 6th and X280

2018-05-23T18:46:42+00:00

Synaptics devices reported it has Intertouch support,
and it fails via PS/2 as following logs:

psmouse serio2: Failed to reset mouse on synaptics-pt/serio0
psmouse serio2: Failed to enable mouse on synaptics-pt/serio0

Set these new devices to use SMBus to fix this issue, then they report
SMBus version 3 is using, patch:
https://patchwork.kernel.org/patch/9989547/ enabled SMBus ver 3 and
makes synaptics devices work fine on SMBus mode.

Signed-off-by: Aaron Ma 
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov

Input: synaptics - Lenovo Thinkpad X1 Carbon G5 (2017) with Elantech trackpoints should use RMI

2018-05-23T18:45:50+00:00

Lenovo use two different trackpoints in the fifth generation Thinkpad X1
Carbon. Both are accessible over SMBUS/RMI but the pnpIDs are missing.
This patch is for the Elantech trackpoint specifically which also
reports SMB version 3 so rmi_smbus needs to be updated in order to
handle it.

For the record, I was not the first one to come up with this patch as it
has been floating around the internet for a while now. However, I have
spent significant time with testing and my efforts to find the original
author of the patch have been unsuccessful.

Signed-off-by: Edvard Holst 
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov

Input: synaptics - Lenovo Carbon X1 Gen5 (2017) devices should use RMI

2018-05-23T18:44:35+00:00

The touchpad on Lenovo Carbon X1 Gen 5 (2017 - Kabylake) is accessible over
SMBUS/RMI, so let's activate it by default.

Cc: stable@vger.kernel.org
Reviewed-by: Benjamin Tissoires 
Signed-off-by: Dmitry Torokhov

Merge branch 'next' into for-linus

2018-04-04T23:11:49+00:00

Prepare input updates for 4.17 merge window.

Merge branch 'psmouse' into next

2018-03-17T17:58:05+00:00

Merge various PS/2 handling improvements.

Revert "Input: synaptics - Lenovo Thinkpad T460p devices should use RMI"

2018-03-07T23:50:29+00:00

This reverts commit 48282969826b3d3c76e908182f69724d86d995fe which
caused the following issues:

1. On T460p with BIOS version 2.22 touchpad and trackpoint stop working
after suspend-resume cycle. Due to strange state of the device another
suspend is impossible.

The following dmesg errors can be observed:
thinkpad_acpi: EC reports that Thermal Table has changed
rmi4_smbus 7-002c: failed to get SMBus version number!
rmi4_physical rmi4-00: rmi_driver_reset_handler: Failed to read current IRQ mask.
rmi4_f01 rmi4-00.fn01: Failed to restore normal operation: -16.
rmi4_f01 rmi4-00.fn01: Resume failed with code -16.
rmi4_physical rmi4-00: Failed to suspend functions: -16
rmi4_smbus 7-002c: Failed to resume device: -16
PM: resume devices took 0.640 seconds
rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Failed to write to F03 TX register (-16).
rmi4_physical rmi4-00: rmi_driver_clear_irq_bits: Failed to change enabled interrupts!
rmi4_physical rmi4-00: rmi_driver_set_irq_bits: Failed to change enabled interrupts!
psmouse: probe of serio3 failed with error -1

2. On another T460p with BIOS version 2.15 two finger scrolling gesture
on the touchpad stops working after suspend-resume cycle (about 75%
reproducibility, when it still works, the scrolling gesture becomes
laggy). Nothing suspicious appears in the dmesg.

Analysis form Richard Schütz:

"RMI is unreliable on the ThinkPad T460p because the device is affected
by the firmware behavior addressed in a7ae81952cda ("i2c: i801: Allow
ACPI SystemIO OpRegion to conflict with PCI BAR")."

The affected devices often show:

i801_smbus 0000:00:1f.4: BIOS is accessing SMBus registers
i801_smbus 0000:00:1f.4: Driver SMBus register access inhibited

Reported-by: Richard Schütz 
Signed-off-by: Arkadiusz Hiler 
Tested-by: Martin Peres 
Tested-by: Arkadiusz Hiler 
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov

Input: synaptics - handle errors from input_mt_init_slots()

2018-02-03T01:04:08+00:00

input_mt_init_slots() may fail, we need to handle this condition.

Signed-off-by: Dmitry Torokhov

Input: synaptics - switch to using input_set_capability

2018-02-03T01:04:08+00:00

Instead of manipulating capability bits directly, use
input_set_capability().

Signed-off-by: Dmitry Torokhov

Input: psmouse - move sliced command implementation to libps2

2018-02-03T00:50:24+00:00

In preparation to adding some debugging statements to PS/2 control
sequences let's move psmouse_sliced_command() into libps2 and rename it
to ps2_sliced_command().

Signed-off-by: Dmitry Torokhov