linux.git/drivers/input/mouse/alps.c, branch v4.17

Input: alps - fix reporting pressure of v3 trackstick

2018-04-23T23:38:16+00:00

According to documentation, all 7 lower bits represents trackpoint pressure.

Fixes: 4621c9660459 ("Input: alps - report pressure of v3 and v7 trackstick")
Signed-off-by: Pali Rohár 
Signed-off-by: Dmitry Torokhov

Merge branch 'next' into for-linus

2018-04-04T23:11:49+00:00

Prepare input updates for 4.17 merge window.

Input: ALPS - fix TrackStick detection on Thinkpad L570 and Latitude 7370

2018-03-30T22:30:25+00:00

The primary interface for the touchpad device in Thinkpad L570 is SMBus,
so ALPS overlooked PS2 interface Firmware setting of TrackStick, and
shipped with TrackStick otp bit is disabled.

The address 0xD7 contains device number information, so we can identify
the device by checking this value, but to access it we need to enable
Command mode, and then re-enable the device. Devices shipped in Thinkpad
L570 report either 0x0C or 0x1D as device numbers, if we see them we assume
that the devices are DualPoints.

The same issue exists on Dell Latitude 7370.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196929
Fixes: 646580f793 ("Input: ALPS - fix multi-touch decoding on SS4 plus touchpads")
Signed-off-by: Masaki Ota 
Tested-by: Aaron Ma 
Tested-by: Jonathan Liu 
Tested-by: Jaak Ristioja 
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov

Input: alps - report pressure of v3 and v7 trackstick

2018-03-27T00:03:05+00:00

ALPS v3 and v7 packet formats reports trackstick pressure. This information
is already parsed in unused "z" variable.

ALPS SS4 S2 devices already reports trackstick pressure as ABS_PRESSURE
attribute, therefore reports pressure in the same way also for v3 and v7.

This patch also updates parsing v3 pressure information, it is also stored
in 7 bits.

Signed-off-by: Pali Rohár 
Signed-off-by: Dmitry Torokhov

Input: psmouse - create helper for reporting standard buttons/motion

2018-02-03T00:48:56+00:00

Many protocol driver re-implement code to parse buttons or motion data from
the standard PS/2 protocol. Let's split the parsing into separate
functions and reuse them in protocol drivers.

Signed-off-by: Dmitry Torokhov

Input: ALPS - fix multi-touch decoding on SS4 plus touchpads

2018-01-12T08:41:36+00:00

The fix for handling two-finger scroll (i4a646580f793 - "Input: ALPS -
fix two-finger scroll breakage in right side on ALPS touchpad")
introduced a minor "typo" that broke decoding of multi-touch events are
decoded on some ALPS touchpads.  For example, tapping with three-fingers
can no longer be used to emulate middle-mouse-button (the kernel doesn't
recognize this as the proper event, and doesn't report it correctly to
userspace).  This affects touchpads that use SS4 "plus" protocol
variant, like those found on Dell E7270 & E7470 laptops (tested on
E7270).

First, probably the code in alps_decode_ss4_v2() for case
SS4_PACKET_ID_MULTI used inconsistent indices to "f->mt[]". You can see
0 & 1 are used for the "if" part but 2 & 3 are used for the "else" part.

Second, in the previous patch, new macros were introduced to decode X
coordinates specific to the SS4 "plus" variant, but the macro to
define the maximum X value wasn't changed accordingly. The macros to
decode X values for "plus" variant are effectively shifted right by 1
bit, but the max wasn't shifted too. This causes the driver to
incorrectly handle "no data" cases, which also interfered with how
multi-touch was handled.

Fixes: 4a646580f793 ("Input: ALPS - fix two-finger scroll breakage...")
Signed-off-by: Nir Perry 
Reviewed-by: Masaki Ota 
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov

Input: alps - convert to using timer_setup()

2017-10-23T23:31:50+00:00

In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.

Signed-off-by: Kees Cook 
Reviewed-by: Pali Rohár 
Signed-off-by: Dmitry Torokhov

Input: ALPS - fix two-finger scroll breakage in right side on ALPS touchpad

2017-08-24T22:53:46+00:00

Fixed the issue that two finger scroll does not work correctly
on V8 protocol. The cause is that V8 protocol X-coordinate decode
is wrong at SS4 PLUS device. I added SS4 PLUS X decode definition.

Mote notes:
the problem manifests itself by the commit e7348396c6d5 ("Input: ALPS
- fix V8+ protocol handling (73 03 28)"), where a fix for the V8+
protocol was applied.  Although the culprit must have been present
beforehand, the two-finger scroll worked casually even with the
wrongly reported values by some reason.  It got broken by the commit
above just because it changed x_max value, and this made libinput
correctly figuring the MT events.  Since the X coord is reported as
falsely doubled, the events on the right-half side go outside the
boundary, thus they are no longer handled.  This resulted as a broken
two-finger scroll.

One finger event is decoded differently, and it didn't suffer from
this problem.  The problem was only about MT events. --tiwai

Fixes: e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")
Signed-off-by: Masaki Ota 
Tested-by: Takashi Iwai 
Tested-by: Paul Donohue 
Cc: 
Signed-off-by: Takashi Iwai 
Signed-off-by: Dmitry Torokhov

Merge tag 'v4.11-rc5' into next

2017-04-03T19:01:20+00:00

Sync up with mainline to bring in changes to input subsystem merged
through other trees.

Input: ALPS - fix trackstick button handling on V8 devices

2017-03-17T21:25:04+00:00

Alps stick devices always have physical buttons, so we should not check
ALPS_BUTTONPAD flag to decide whether we should report them.

Fixes: 4777ac220c43 ("Input: ALPS - add touchstick support for SS5 hardware")
Signed-off-by: Masaki Ota 
Acked-by: Pali Rohar 
Tested-by: Paul Donohue 
Tested-by: Nick Fletcher 
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov