linux.git/drivers/infiniband, branch v4.4-rc7

IB/mlx5: Postpone remove_keys under knowledge of coming preemption

2015-12-08T21:55:31+00:00

The remove_keys() logic is performed as garbage collection task. Such
task is intended to be run when no other active processes are running.

The need_resched() will return TRUE if there are user tasks to be
activated in near future.

In such case, we don't execute remove_keys() and postpone
the garbage collection work to try to run in next cycle,
in order to free CPU resources to other tasks.

The possible pseudo-code to trigger such scenario:
1. Allocate a lot of MR to fill the cache above the limit.
2. Wait a small amount of time "to calm" the system.
3. Start CPU extensive operations on multi-node cluster.
4. Expect performance degradation during MR cache shrink operation.

Signed-off-by: Leon Romanovsky 
Signed-off-by: Eli Cohen 
Signed-off-by: Doug Ledford

IB/mlx4: Use vmalloc for WR buffers when needed

2015-12-08T21:48:10+00:00

There are several hits that WR buffer allocation(kmalloc) failed.
It failed at order 3 and/or 4 contigous pages allocation. At the same time
there are actually 100MB+ free memory but well fragmented.
So try vmalloc when kmalloc failed.

Signed-off-by: Wengang Wang 
Acked-by: Or Gerlitz 
Signed-off-by: Doug Ledford

iser-target: Remove explicit mlx4 work-around

2015-12-08T18:01:11+00:00

The driver now exposes sufficient limits so we can
avoid having mlx4 specific work-around.

Signed-off-by: Sagi Grimberg 
Reviewed-by: Steve Wise 
Signed-off-by: Doug Ledford

mlx4: Expose correct max_sge_rd limit

2015-12-08T17:42:44+00:00

mlx4 devices (ConnectX-2, ConnectX-3) has a limitation
where rdma read work queue entries cannot exceed 512 bytes.
A rdma_read wqe needs to fit in 512 bytes:
- wqe control segment (16 bytes)
- rdma segment (16 bytes)
- scatter elements (16 bytes each)

So max_sge_rd should be: (512 - 16 - 16) / 16 = 30.

Signed-off-by: Sagi Grimberg 
Reviewed-by: Steve Wise 
Signed-off-by: Doug Ledford

IB/mad: Require CM send method for everything except ClassPortInfo

2015-12-08T17:19:11+00:00

Receipt of CM MAD with other than the Send method for an attribute
other than the ClassPortInfo attribute is invalid.

CM attributes other than ClassPortInfo only use the send method.

The SRP initiator does not maintain a timeout policy for CM connect
requests relies on the CM layer to do that. The result was that
the SRP initiator hung as the connect request never completed.

A new SRP target has been observed to respond to Send CM REQ
with GetResp of CM REQ with bad status. This is non conformant
with IBA spec but exposes a vulnerability in the current MAD/CM
code which will respond to the incoming GetResp of CM REQ as if
it was a valid incoming Send of CM REQ rather than tossing
this on the floor. It also causes the MAD layer not to
retransmit the original REQ even though it has not received a REP.

Reviewed-by: Sagi Grimberg 
Signed-off-by: Hal Rosenstock 
Reviewed-by: Ira Weiny 
Signed-off-by: Doug Ledford

IB/cma: Add a missing rcu_read_unlock()

2015-12-08T17:14:43+00:00

Ensure that validate_ipv4_net_dev() calls rcu_read_unlock() if
fib_lookup() fails. Detected by sparse. Compile-tested only.

Fixes: "IB/cma: Validate routing of incoming requests" (commit f887f2ac87c2).
Cc: Haggai Eran 
Cc: stable 
Reviewed-by: Sagi Grimberg 
Reviewed-by: Haggai Eran 
Reviewed-by: Jason Gunthorpe 

Signed-off-by: Doug Ledford

IB core: Fix ib_sg_to_pages()

2015-12-07T22:20:12+00:00

On 12/03/2015 01:18 AM, Christoph Hellwig wrote:
> The patch looks good to me, but while we touch this area, how about
> throwing in a few cosmetic fixes as well?

How about the patch below ? In that version of the ib_sg_to_pages() fix
these concerns have been addressed and additionally to more bugs have been fixed.

------------

[PATCH] IB core: Fix ib_sg_to_pages()

Fix the code for detecting gaps. A gap occurs not only if the
second or later scatterlist element is not aligned but also if
any scatterlist element other than the last does not end at a
page boundary.

In the code for coalescing contiguous elements, ensure that
mr->length is correct and that last_page_addr is up-to-date.

Ensure that this function returns a negative
error code instead of zero if the first set_page() call fails.

Fixes: commit 4c67e2bfc8b7 ("IB/core: Introduce new fast registration API")
Reported-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg 
Reviewed-by: Christoph Hellwig 

Signed-off-by: Doug Ledford

IB/srp: Fix srp_map_sg_fr()

2015-12-07T22:20:11+00:00

After dma_map_sg() has been called the return value of that function
must be used as the number of elements in the scatterlist instead of
scsi_sg_count().

Fixes: commit f7f7aab1a5c0 ("IB/srp: Convert to new registration API")
Reported-by: Christoph Hellwig 
Signed-off-by: Bart Van Assche 
Cc: stable  # v4.4+
Cc: Sagi Grimberg 
Cc: Sebastian Parschauer 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Doug Ledford

IB/srp: Fix indirect data buffer rkey endianness

2015-12-07T22:20:11+00:00

Detected by sparse.

Fixes: commit 330179f2fa93 ("IB/srp: Register the indirect data buffer descriptor")
Signed-off-by: Bart Van Assche 
Cc: stable  # v4.3+
Cc: Sagi Grimberg 
Cc: Christoph Hellwig 
Cc: Sebastian Parschauer 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Doug Ledford

IB/srp: Initialize dma_length in srp_map_idb

2015-12-07T22:20:11+00:00

Without this sg_dma_len will return 0 on architectures tha have
the dma_length field.

Fixes: commit f7f7aab1a5c0 ("IB/srp: Convert to new registration API")
Signed-off-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Doug Ledford