linux.git/drivers/infiniband/ulp, branch v4.3-rc2

Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending

2015-09-12T02:00:42+00:00

Pull SCSI target updates from Nicholas Bellinger:
 "Here are the outstanding target-pending updates for v4.3-rc1.

  Mostly bug-fixes and minor changes this round.  The fallout from the
  big v4.2-rc1 RCU conversion have (thus far) been minimal.

  The highlights this round include:

   - Move sense handling routines into scsi_common code (Sagi)

   - Return ABORTED_COMMAND sense key for PI errors (Sagi)

   - Add tpg_enabled_sendtargets attribute for disabled iscsi-target
     discovery (David)

   - Shrink target struct se_cmd by rearranging fields (Roland)

   - Drop iSCSI use of mutex around max_cmd_sn increment (Roland)

   - Replace iSCSI __kernel_sockaddr_storage with sockaddr_storage (Andy +
     Chris)

   - Honor fabric max_data_sg_nents I/O transfer limit (Arun + Himanshu +
     nab)

   - Fix EXTENDED_COPY >= v4.1 regression OOPsen (Alex + nab)"

* 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending: (37 commits)
  target: use stringify.h instead of own definition
  target/user: Fix UFLAG_UNKNOWN_OP handling
  target: Remove no-op conditional
  target/user: Remove unused variable
  target: Fix max_cmd_sn increment w/o cmdsn mutex regressions
  target: Attach EXTENDED_COPY local I/O descriptors to xcopy_pt_sess
  target/qla2xxx: Honor max_data_sg_nents I/O transfer limit
  target/iscsi: Replace __kernel_sockaddr_storage with sockaddr_storage
  target/iscsi: Replace conn->login_ip with login_sockaddr
  target/iscsi: Keep local_ip as the actual sockaddr
  target/iscsi: Fix np_ip bracket issue by removing np_ip
  target: Drop iSCSI use of mutex around max_cmd_sn increment
  qla2xxx: Update tcm_qla2xxx module description to 24xx+
  iscsi-target: Add tpg_enabled_sendtargets for disabled discovery
  drivers: target: Drop unlikely before IS_ERR(_OR_NULL)
  target: check DPO/FUA usage for COMPARE AND WRITE
  target: Shrink struct se_cmd by rearranging fields
  target: Remove cmd->se_ordered_id (unused except debug log lines)
  target: add support for START_STOP_UNIT SCSI opcode
  target: improve unsupported opcode message
  ...

IB/ipoib: Suppress warning for send only join failures

2015-09-03T21:11:05+00:00

We expect send only joins to fail, it just means there are no listeners
for the group. The correct thing to do is silently drop the packet
at source.

Eg avahi will full join 224.0.0.251 which causes a send only IGMP packet
to 224.0.0.22, and then a warning level kmessage like this:

 ib0: sendonly multicast join failed for ff12:401b:ffff:0000:0000:0000:0000:0016, status -22

If there is no IP router listening to IGMP.

Signed-off-by: Jason Gunthorpe 
Signed-off-by: Doug Ledford

IB/ipoib: Clean up send-only multicast joins

2015-09-03T21:05:58+00:00

Even though we don't expect the group to be created by the SM we
sill need to provide all the parameters to force the SM to validate
they are correct.

Signed-off-by: Jason Gunthorpe 
Signed-off-by: Doug Ledford

IB/srp: Fix possible protection fault

2015-09-03T19:59:48+00:00

srp_destroy_qp is designed to indicate we are safe to continue with
freeing the channel resources by modifying the qp error state,
posting a dummy wr on the queue-pair and waiting for it to flush.
This also holds for the channel registration pool as we are unmapping
the memory region when handling a scsi response. Destroying the
channel registration pool before we make sure we processed all the
inflight IO might introduce a use-after-free of the registration pool.

This use-after-free is demonstrated in the stack trace below where
srp is trying to unmap a used FMR after the fmr_pool was already destroyed.

general protection fault: 0000 [#1] SMP
RIP: 0010:[]  [] _raw_spin_lock_irqsave+0x1b/0x50
Call Trace:
 [] ib_fmr_pool_unmap+0x1a/0xb0 [ib_core]
 [] srp_unmap_data.isra.28+0x17d/0x250 [ib_srp]
 [] srp_free_req+0x2b/0x60 [ib_srp]
 [] srp_recv_completion+0x174/0x580 [ib_srp]
 [] mlx4_eq_int+0x4de/0xe50 [mlx4_core]
 [] mlx4_msi_x_interrupt+0x10/0x20 [mlx4_core]
 [] handle_irq_event_percpu+0x35/0x1b0
 [] handle_irq_event+0x32/0x50
 [] handle_edge_irq+0x6f/0x120
 [] handle_irq+0x1a/0x30
 [] do_IRQ+0x45/0xb0
 [] common_interrupt+0x6d/0x6d
 [] cpuidle_enter_state+0x4f/0xc0
 [] cpuidle_idle_call+0xcc/0x210
 [] arch_cpu_idle+0xa/0x30
 [] cpu_startup_entry+0xe1/0x270
 [] start_secondary+0x21a/0x2c0

Reported-by: Eliott Kespi 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

IB/core: Make ib_dealloc_pd return void

2015-08-30T22:12:39+00:00

The majority of callers never check the return value, and even if they
did, they can't do anything about a failure.

All possible failure cases represent a bug in the caller, so just
WARN_ON inside the function instead.

This fixes a few random errors:
 net/rd/iw.c infinite loops while it fails. (racing with EBUSY?)

This also lays the ground work to get rid of error return from the
drivers. Most drivers do not error, the few that do are broken since
it cannot be handled.

Since uverbs can legitimately make use of EBUSY, open code the
check.

Signed-off-by: Jason Gunthorpe 
Reviewed-by: Chuck Lever 
Signed-off-by: Doug Ledford

IB/srp: Create an insecure all physical rkey only if needed

2015-08-30T22:12:39+00:00

The SRP initiator only needs this if the insecure register_always=N
performance optimization is enabled, or if FRWR/FMR is not supported
in the driver.

Do not create an all physical MR unless it is needed to support
either of those modes. Default register_always to true so the out of
the box configuration does not create an insecure all physical MR.

Signed-off-by: Jason Gunthorpe 
[bvanassche: reworked and rebased this patch]
Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

IB/srp: Register the indirect data buffer descriptor

2015-08-30T22:12:38+00:00

Instead of always using the global rkey for the indirect data
buffer descriptor, register that descriptor with the HCA if
the kernel module parameter register_always has been set to Y.

Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

IB/srp: Introduce srp_device.use_fmr

2015-08-30T22:12:38+00:00

Introduce the variable srp_device.use_fmr. Leave out the dev->has_fr /
dev->has_fmr and ch->fr_pool / ch->fmr_pool checks since these are
redundant. This patch does not change any functionality but makes the
source code easier to read.

Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

IB/srp: Remove use_mr argument from srp_map_sg_entry()

2015-08-30T22:12:38+00:00

Move the srp_map_desc() call from inside srp_map_sg_entry() to
srp_map_sg() such that the use_mr argument can be removed from
srp_map_sg_entry().

Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

IB/srp: Remove the memory registration backtracking code

2015-08-30T22:12:37+00:00

Mapping a discontiguous sg-list requires multiple memory regions
and hence can exhaust the memory region pool. The SRP initiator
already handles this by temporarily reducing the queue depth. This
means that it is safe to remove the memory registration backtracking
code. This patch has been tested with direct I/O sizes up to 256 MB.

Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford