linux.git/drivers/infiniband/ulp, branch v3.17-rc2

Merge tag 'rdma-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband

2014-08-14T17:09:05+00:00

Pull infiniband/rdma updates from Roland Dreier:
 "Main set of InfiniBand/RDMA updates for 3.17 merge window:

   - MR reregistration support
   - MAD support for RMPP in userspace
   - iSER and SRP initiator updates
   - ocrdma hardware driver updates
   - other fixes..."

* tag 'rdma-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband: (52 commits)
  IB/srp: Fix return value check in srp_init_module()
  RDMA/ocrdma: report asic-id in query device
  RDMA/ocrdma: Update sli data structure for endianness
  RDMA/ocrdma: Obtain SL from device structure
  RDMA/uapi: Include socket.h in rdma_user_cm.h
  IB/srpt: Handle GID change events
  IB/mlx5: Use ARRAY_SIZE instead of sizeof/sizeof[0]
  IB/mlx4: Use ARRAY_SIZE instead of sizeof/sizeof[0]
  RDMA/amso1100: Check for integer overflow in c2_alloc_cq_buf()
  IPoIB: Remove unnecessary test for NULL before debugfs_remove()
  IB/mad: Add user space RMPP support
  IB/mad: add new ioctl to ABI to support new registration options
  IB/mad: Add dev_notice messages for various umad/mad registration failures
  IB/mad: Update module to [pr|dev]_* style print messages
  IB/ipoib: Avoid multicast join attempts with invalid P_key
  IB/umad: Update module to [pr|dev]_* style print messages
  IB/ipoib: Avoid flushing the workqueue from worker context
  IB/ipoib: Use P_Key change event instead of P_Key polling mechanism
  IB/ipath: Add P_Key change event support
  mlx4_core: Add support for secure-host and SMP firewall
  ...

Merge branches 'core', 'cxgb4', 'ipoib', 'iser', 'iwcm', 'mad', 'misc', 'mlx4', 'mlx5', 'ocrdma' and 'srp' into for-next

2014-08-14T15:58:04+00:00

IB/srp: Fix return value check in srp_init_module()

2014-08-14T15:57:54+00:00

In case of error, the function create_workqueue() returns NULL pointer
not ERR_PTR().  The IS_ERR() test in the return value check should be
replaced with NULL test.

Signed-off-by: Wei Yongjun 
Acked-by: Bart Van Assche 
Signed-off-by: Roland Dreier

IB/srpt: Handle GID change events

2014-08-13T05:01:55+00:00

GID change events need a refresh just like LID change events and several
others.  Handle this the same as the others.

Signed-off-by: Doug Ledford 
Signed-off-by: Roland Dreier

IPoIB: Remove unnecessary test for NULL before debugfs_remove()

2014-08-13T04:59:54+00:00

Fix checkpatch warning:

    WARNING: debugfs_remove(NULL) is safe this check is probably not required

Signed-off-by: Fabian Frederick 
Signed-off-by: Doug Ledford 
Signed-off-by: Roland Dreier

IB/mad: add new ioctl to ABI to support new registration options

2014-08-11T03:36:00+00:00

Registrations options are specified through flags.  Definitions of flags will
be in subsequent patches.

Signed-off-by: Ira Weiny 
Signed-off-by: Roland Dreier

IB/ipoib: Avoid multicast join attempts with invalid P_key

2014-08-11T02:53:56+00:00

Currently, the parent interface keeps sending broadcast group join
requests even if p_key index 0 is invalid, which is possible/common in
virtualized environments where a VF has been probed to VM but the
actual P_key configuration has not yet been assigned by the management
software. This creates unnecessary noise on the fabric and in the
kernel logs:

    ib0: multicast join failed for ff12:401b:8000:0000:0000:0000:ffff:ffff, status -22

The original code run the multicast task regardless of the actual
P_key value, which can be avoided. The fix is to re-init resources and
bring interface up only if P_key index 0 is valid either when starting
up or on PKEY_CHANGE event.

Fixes: c290414169 ("IPoIB: Fix pkey change flow for virtualization environments")
Reviewed-by: Ira Weiny 
Signed-off-by: Alex Estrin 
Signed-off-by: Roland Dreier

IB/ipoib: Avoid flushing the workqueue from worker context

2014-08-05T14:47:33+00:00

The error flow of ipoib_ib_dev_open() invokes ipoib_ib_dev_stop() with
workqueue flushing enabled, which deadlocks if the open procedure
itself was called by a worker thread.

Fix this by adding a flush enabled flag to ipoib_ib_dev_open() and set
it accordingly from the locations where such a call is made.

The call trace was the following:

 [] ? flush_workqueue+0x54/0x80
 [] ? ipoib_ib_dev_stop+0x447/0x650 [ib_ipoib]
 [] ? ipoib_ib_dev_open+0x284/0x430 [ib_ipoib]
 [] ? ipoib_open+0x78/0x1d0 [ib_ipoib]
 [] ? ipoib_pkey_open+0x38/0x40 [ib_ipoib]
 [] ? __ipoib_ib_dev_flush+0x15c/0x2c0 [ib_ipoib]
 [] ? __ipoib_ib_dev_flush+0x76/0x2c0 [ib_ipoib]
 [] ? ipoib_ib_dev_flush_heavy+0x0/0x20 [ib_ipoib]
 [] ? ipoib_ib_dev_flush_heavy+0x1a/0x20 [ib_ipoib]
 [] ? worker_thread+0x170/0x2a0
 [] ? autoremove_wake_function+0x0/0x40

Signed-off-by: Erez Shitrit 
Signed-off-by: Or Gerlitz 
Acked-by: Alex Estrin 
Signed-off-by: Roland Dreier

IB/ipoib: Use P_Key change event instead of P_Key polling mechanism

2014-08-05T14:47:33+00:00

The current code use a dedicated polling logic to determine when the P_Key
assigned to the ipoib device is present in HCA port table and act accordingly.

Move to use the code which acts upon getting PKEY_CHANGE event to handle this
task and remove the P_Key polling logic/thread as they add extra complexity
which isn't needed.

Signed-off-by: Erez Shitrit 
Signed-off-by: Or Gerlitz 
Acked-by: Alex Estrin 
Signed-off-by: Roland Dreier

IB/srp: Fix residual handling

2014-08-01T22:21:51+00:00

From Documentation/scsi/scsi_mid_low_api.txt: "resid - an LLD should
set this signed integer to the requested transfer length (i.e.
'request_bufflen') less the number of bytes that are actually
transferred."  This means that resid > 0 in case of an underrun and
also that resid < 0 in case of an overrun.  Modify the SRP initiator
code such that it matches this requirement.

Signed-off-by: Bart Van Assche 
Reviewed-by: Sagi Grimberg 
Reviewed-by: David Dillow 
Signed-off-by: Roland Dreier