linux.git/drivers/infiniband/sw, branch v6.8

RDMA/siw: Call orq_get_current if possible

2023-12-05T00:13:30+00:00

Use orq_get_current() in siw_orq_empty().

Link: https://lore.kernel.org/r/20231203092655.28102-5-guoqing.jiang@linux.dev
Acked-by: Bernard Metzler 
Signed-off-by: Guoqing Jiang 
Signed-off-by: Jason Gunthorpe

RDMA/siw: Set qp_state in siw_query_qp

2023-12-05T00:13:30+00:00

Run test_query_rc_qp against siw failed since siw didn't set qp_state
accordingly. To address it, introduce siw_qp_state_to_ib_qp_state
which convert SIW_QP_STATE_IDLE to IB_QPS_INIT which is similar as
in cxgb4.

rdma-core# ./build/bin/run_tests.py --dev siw0 tests.test_qp.QPTest.test_query_rc_qp -v
test_query_rc_qp (tests.test_qp.QPTest)
Queries an RC QP after creation. Verifies that its properties are as ... FAIL

======================================================================
FAIL: test_query_rc_qp (tests.test_qp.QPTest)
Queries an RC QP after creation. Verifies that its properties are as
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/gjiang/rdma-core/tests/test_qp.py", line 284, in test_query_rc_qp
    self.query_qp_common_test(e.IBV_QPT_RC)
  File "/home/gjiang/rdma-core/tests/test_qp.py", line 265, in query_qp_common_test
    self.verify_qp_attrs(caps, e.IBV_QPS_INIT, qp_init_attr, qp_attr)
  File "/home/gjiang/rdma-core/tests/test_qp.py", line 239, in verify_qp_attrs
    self.assertEqual(state, attr.qp_state)
AssertionError:  != 0

----------------------------------------------------------------------
Ran 1 test in 0.057s

FAILED (failures=1)

Link: https://lore.kernel.org/r/20231203092655.28102-4-guoqing.jiang@linux.dev
Signed-off-by: Guoqing Jiang 
Acked-by: Bernard Metzler 
Signed-off-by: Jason Gunthorpe

RDMA/siw: Reduce memory usage of struct siw_rx_stream

2023-12-05T00:13:30+00:00

We can reduce the memory of the struct by move some of it's
member.

Before,

	/* size: 144, cachelines: 3, members: 17 */
	/* sum members: 124, holes: 3, sum holes: 12 */
	/* sum bitfield members: 7 bits (0 bytes) */
	/* padding: 7 */
	/* bit_padding: 1 bits */

After

	/* size: 128, cachelines: 2, members: 17 */
	/* padding: 3 */
	/* bit_padding: 1 bits */

Link: https://lore.kernel.org/r/20231203092655.28102-3-guoqing.jiang@linux.dev
Acked-by: Bernard Metzler 
Signed-off-by: Guoqing Jiang 
Signed-off-by: Jason Gunthorpe

RDMA/siw: Move tx_cpu ahead

2023-12-05T00:13:30+00:00

We can reduce one cacheline for the usage of struct siw_qp.

Before,

	/* size: 1928, cachelines: 31, members: 38 */
	/* sum members: 1920, holes: 2, sum holes: 8 */
	/* paddings: 4, sum paddings: 13 */
	/* forced alignments: 3 */

after

	/* size: 1920, cachelines: 30, members: 38 */
	/* paddings: 4, sum paddings: 13 */
	/* forced alignments: 3 */

Link: https://lore.kernel.org/r/20231203092655.28102-2-guoqing.jiang@linux.dev
Acked-by: Bernard Metzler 
Signed-off-by: Guoqing Jiang 
Signed-off-by: Jason Gunthorpe

RDMA/siw: Update comments for siw_qp_sq_process

2023-11-15T13:58:14+00:00

There is no siw_sq_work_handler in code, change it with siw_tx_thread
since siw_run_sq -> siw_sq_resume -> siw_qp_sq_process.

Acked-by: Bernard Metzler 
Signed-off-by: Guoqing Jiang 
Link: https://lore.kernel.org/r/20231113115726.12762-18-guoqing.jiang@linux.dev
Signed-off-by: Leon Romanovsky

RDMA/siw: Introduce siw_destroy_cep_sock

2023-11-15T13:58:14+00:00

Add one helper to simplify code a bit.

Reported-by: kernel test robot 
Closes: https://lore.kernel.org/oe-kbuild-all/202310091735.oG7bTvLR-lkp@intel.com/`
Acked-by: Bernard Metzler 
Signed-off-by: Guoqing Jiang 
Link: https://lore.kernel.org/r/20231113115726.12762-17-guoqing.jiang@linux.dev
Signed-off-by: Leon Romanovsky

RDMA/siw: Only check attrs->cap.max_send_wr in siw_create_qp

2023-11-15T13:58:14+00:00

We can just check max_send_wr here given both max_send_wr and
max_recv_wr are defined as u32 type, and we also need to ensure
num_sqe (derived from max_send_wr) shouldn't be zero.

Acked-by: Bernard Metzler 
Signed-off-by: Guoqing Jiang 
Link: https://lore.kernel.org/r/20231113115726.12762-16-guoqing.jiang@linux.dev
Signed-off-by: Leon Romanovsky

RDMA/siw: Fix typo

2023-11-15T13:58:14+00:00

Replace ORRQ with ORQ.

Acked-by: Bernard Metzler 
Signed-off-by: Guoqing Jiang 
Link: https://lore.kernel.org/r/20231113115726.12762-15-guoqing.jiang@linux.dev
Signed-off-by: Leon Romanovsky

RDMA/siw: Remove siw_sk_save_upcalls

2023-11-15T13:58:14+00:00

Let's move it into siw_sk_assign_cm_upcalls, then we only
need to get sk_callback_lock once.

Acked-by: Bernard Metzler 
Signed-off-by: Guoqing Jiang 
Link: https://lore.kernel.org/r/20231113115726.12762-14-guoqing.jiang@linux.dev
Signed-off-by: Leon Romanovsky

RDMA/siw: Cleanup siw_accept

2023-11-15T13:58:14+00:00

With the initialization of rv and the two added label, we can
simplifiy code a bit.

Acked-by: Bernard Metzler 
Signed-off-by: Guoqing Jiang 
Link: https://lore.kernel.org/r/20231113115726.12762-13-guoqing.jiang@linux.dev
Signed-off-by: Leon Romanovsky