<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux.git/drivers/ide/pmac.c, branch v2.6.28</title>
<subtitle>Linux kernel source tree</subtitle>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/'/>
<entry>
<title>ide: build-fix for CONFIG_BLK_DEV_IDEDMA_PMAC=n</title>
<updated>2008-12-08T16:52:05+00:00</updated>
<author>
<name>Bartlomiej Zolnierkiewicz</name>
<email>bzolnier@gmail.com</email>
</author>
<published>2008-12-08T16:52:05+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=53846574799884a04a4498f6342400d5c1423c79'/>
<id>53846574799884a04a4498f6342400d5c1423c79</id>
<content type='text'>
IDE pmac host driver build fails with CONFIG_BLK_DEV_IDEDMA_PMAC=n
as reported by Kamalesh:

&gt; drivers/ide/pmac.c: In function 'pmac_ide_set_pio_mode':
&gt; drivers/ide/pmac.c:527: error: implicit declaration of function 'kauai_lookup_timing'
&gt; drivers/ide/pmac.c:527: error: 'shasta_pio_timings' undeclared (first use in this function)
&gt; drivers/ide/pmac.c:527: error: (Each undeclared identifier is reported only once
&gt; drivers/ide/pmac.c:527: error: for each function it appears in.)
&gt; drivers/ide/pmac.c:534: error: 'kauai_pio_timings' undeclared (first use in this function)
&gt; drivers/ide/pmac.c: In function 'pmac_ide_do_resume':
&gt; drivers/ide/pmac.c:914: error: 'IDE_WAKEUP_DELAY' undeclared (first use in this function)
&gt; drivers/ide/pmac.c: At top level:
&gt; drivers/ide/pmac.c:1007: error: 'pmac_ide_init_dma' undeclared here (not in a function)
&gt; drivers/ide/pmac.c: In function 'pmac_ide_setup_device':
&gt; drivers/ide/pmac.c:1107: error: 'IDE_WAKEUP_DELAY' undeclared (first use in this function)
&gt; drivers/ide/pmac.c: In function 'pmac_ide_macio_attach':
&gt; drivers/ide/pmac.c:1209: error: 'pmac_ide_hwif_t' has no member named 'dma_regs'
&gt; drivers/ide/pmac.c:1210: error: 'pmac_ide_hwif_t' has no member named 'dma_regs'
&gt; make[2]: *** [drivers/ide/pmac.o] Error 1

Fix it by removing the superfluous config option.

Reported-and-tested-by: Kamalesh Babulal &lt;kamalesh@linux.vnet.ibm.com&gt;
Cc: Benjamin Herrenschmidt &lt;benh@kernel.crashing.org&gt;
Cc: Sergei Shtylyov &lt;sshtylyov@ru.mvista.com&gt;
Cc: Stephen Rothwell &lt;sfr@canb.auug.org.au&gt;
Signed-off-by: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
IDE pmac host driver build fails with CONFIG_BLK_DEV_IDEDMA_PMAC=n
as reported by Kamalesh:

&gt; drivers/ide/pmac.c: In function 'pmac_ide_set_pio_mode':
&gt; drivers/ide/pmac.c:527: error: implicit declaration of function 'kauai_lookup_timing'
&gt; drivers/ide/pmac.c:527: error: 'shasta_pio_timings' undeclared (first use in this function)
&gt; drivers/ide/pmac.c:527: error: (Each undeclared identifier is reported only once
&gt; drivers/ide/pmac.c:527: error: for each function it appears in.)
&gt; drivers/ide/pmac.c:534: error: 'kauai_pio_timings' undeclared (first use in this function)
&gt; drivers/ide/pmac.c: In function 'pmac_ide_do_resume':
&gt; drivers/ide/pmac.c:914: error: 'IDE_WAKEUP_DELAY' undeclared (first use in this function)
&gt; drivers/ide/pmac.c: At top level:
&gt; drivers/ide/pmac.c:1007: error: 'pmac_ide_init_dma' undeclared here (not in a function)
&gt; drivers/ide/pmac.c: In function 'pmac_ide_setup_device':
&gt; drivers/ide/pmac.c:1107: error: 'IDE_WAKEUP_DELAY' undeclared (first use in this function)
&gt; drivers/ide/pmac.c: In function 'pmac_ide_macio_attach':
&gt; drivers/ide/pmac.c:1209: error: 'pmac_ide_hwif_t' has no member named 'dma_regs'
&gt; drivers/ide/pmac.c:1210: error: 'pmac_ide_hwif_t' has no member named 'dma_regs'
&gt; make[2]: *** [drivers/ide/pmac.o] Error 1

Fix it by removing the superfluous config option.

Reported-and-tested-by: Kamalesh Babulal &lt;kamalesh@linux.vnet.ibm.com&gt;
Cc: Benjamin Herrenschmidt &lt;benh@kernel.crashing.org&gt;
Cc: Sergei Shtylyov &lt;sshtylyov@ru.mvista.com&gt;
Cc: Stephen Rothwell &lt;sfr@canb.auug.org.au&gt;
Signed-off-by: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ide: remove useless subdirs from drivers/ide/</title>
<updated>2008-10-21T18:57:23+00:00</updated>
<author>
<name>Bartlomiej Zolnierkiewicz</name>
<email>bzolnier@gmail.com</email>
</author>
<published>2008-10-21T18:57:23+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=2bfba3c444fe8b2ab1c38112a89d8f03b61136ca'/>
<id>2bfba3c444fe8b2ab1c38112a89d8f03b61136ca</id>
<content type='text'>
Suggested-by: Ralf Baechle &lt;ralf@linux-mips.org&gt;
Signed-off-by: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Suggested-by: Ralf Baechle &lt;ralf@linux-mips.org&gt;
Signed-off-by: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
