linux.git/drivers/ide/ide-taskfile.c, branch v2.6.24

ide: add missing #ifdef/#endif CONFIG_IDE_TASK_IOCTL

2007-11-05T20:42:27+00:00

Signed-off-by: Bartlomiej Zolnierkiewicz

ide: add missing rq.ref_count initialization to ide_diag_taskfile()

2007-11-05T20:42:27+00:00

Noticed by Tejun Heo.

Cc: Tejun Heo 
Signed-off-by: Bartlomiej Zolnierkiewicz

[SG] Update drivers to use sg helpers

2007-10-22T19:19:53+00:00

Signed-off-by: Jens Axboe

ide: check drive->using_dma in flagged_taskfile()

2007-10-19T22:32:37+00:00

Acked-by: Sergei Shtylyov 
Signed-off-by: Bartlomiej Zolnierkiewicz

ide: check ->dma_setup() return value in flagged_taskfile()

2007-10-19T22:32:37+00:00

Acked-by: Sergei Shtylyov 
Signed-off-by: Bartlomiej Zolnierkiewicz

ide: remove stale comments from ide-taskfile.c

2007-10-19T22:32:36+00:00

Acked-by: Sergei Shtylyov 
Signed-off-by: Bartlomiej Zolnierkiewicz

IDE: sg chaining support

2007-10-16T09:21:00+00:00

Acked-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Jens Axboe

ide: never called printk statement in ide-taskfile.c::wait_drive_not_busy

2007-07-03T20:28:34+00:00

Look at wait_drive_not_busy in drivers/ide/ide-taskfile.c:

    static u8 wait_drive_not_busy(ide_drive_t *drive)
    {
            ide_hwif_t *hwif = HWIF(drive);
            int retries = 100;
            u8 stat;

            /*
             * Last sector was transfered, wait until drive is ready.
             * This can take up to 10 usec, but we will wait max 1 ms
             * (drive_cmd_intr() waits that long).
             */
            while (((stat = hwif->INB(IDE_STATUS_REG)) & BUSY_STAT) && retries--)
                    udelay(10);

            if (!retries)
                    printk(KERN_ERR "%s: drive still BUSY!\n", drive->name);

            return stat;
    }

`printk' is never called because `retries' never holds zero at the
outside of `while' loop: when `retries' holds zero at the while's loop
condition, `retries' will hold -1 at the if condition.

Signed-off-by: Masatake YAMATO 
Cc: Chuck Ebbert 
Cc: joe@perches.com
Signed-off-by: Bartlomiej Zolnierkiewicz

[PATCH] ide: add sanity checking to ide taskfile ioctl

2006-10-16T15:27:54+00:00

Without this the user can feed in bogus values and get very bogus
results. Security impact is minimal as this ioctl isn't available to
unpriviledged processes anyway.

Reported to the l/k list and found with an auditing tool.

Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

[PATCH] Split struct request ->flags into two parts

2006-09-30T18:23:37+00:00

Right now ->flags is a bit of a mess: some are request types, and
others are just modifiers. Clean this up by splitting it into
->cmd_type and ->cmd_flags. This allows introduction of generic
Linux block message types, useful for sending generic Linux commands
to block devices.

Signed-off-by: Jens Axboe