linux.git/drivers/ide/ide-cd.c, branch v2.6.31

ide-cd: handle fragmented packet commands gracefully

2009-06-26T18:22:37+00:00

There are some devices in the wild that clear the DRQ bit during the
last word of a packet command and therefore could use a "second chance"
for that last word of data to be xferred instead of simply failing the
request. Do that by attempting to suck in those last bytes in PIO mode.

In addition, the ATA_ERR bit has to be cleared for we cannot be sure the
data is valid otherwise.

See http://bugzilla.kernel.org/show_bug.cgi?id=13399 for details.

Signed-off-by: Borislav Petkov 
Acked-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: David S. Miller

ide-cd: Improve "weird block size" error message

2009-06-24T07:32:31+00:00

Currently the error gets repeated too frequently, for example each
time HAL polls the device when a disc is present. Avoid that by using
printk_once instead of printk.

Also join the error and corrective action messages into a single line.

Signed-off-by: Frans Pop 
Acked-by: Borislav Petkov 
Signed-off-by: David S. Miller

ide-cd: Don't warn on bogus block size unless it actually matters.

2009-06-24T07:32:30+00:00

Frans Pop reported that his CDROM drive reports a blocksize of 2352,
and this causes new warnings due to commit
e8e7b9eb11c34ee18bde8b7011af41938d1ad667 ("ide-cd: fix oops when using
growisofs").

What we're trying to do is make sure that "blocklen >> SECTOR_BITS"
is something the block layer won't choke on.

And for Frans' case "2352 >> SECTOR_BITS" is equal to
"2048 >> SECTOR_BITS", and thats "4".

So warning in this case gives no real benefit.

Reported-by: Frans Pop 
Tested-by: Frans Pop 
Signed-off-by: David S. Miller

ide-cd: prevent null pointer deref via cdrom_newpc_intr

2009-06-20T10:22:47+00:00

With 2.6.30, the error handling code in cdrom_newpc_intr was changed
to deal with partial request failures by normally completing the 'good'
parts of a request and only 'error' the last (and presumably,
incompletely transferred) bio associated with a particular
request. In order to do this, ide_complete_rq is called over
ide_cd_error_cmd() to partially complete the rq. The block layer
does partial completion only for requests with bio's and if the
rq doesn't have one (eg 'GPCMD_READ_DISC_INFO') the request is
completed as a whole and the drive->hwif->rq pointer set to NULL
afterwards. When calling ide_complete_rq again to report
the error, this null pointer is derefenced, resulting in a kernel
crash.

This fixes http://bugzilla.kernel.org/show_bug.cgi?id=13399.

Signed-off-by: Rainer Weikusat 
Signed-off-by: Borislav Petkov 
Signed-off-by: Bartlomiej Zolnierkiewicz

ide: BUG() on unknown requests

2009-06-15T20:16:10+00:00

Unsupported requests should be never handed down to device drivers
and the best thing we can do upon discovering such request inside
driver's ->do_request method is to just BUG().

Signed-off-by: Bartlomiej Zolnierkiewicz

Merge branch 'bp-remove-pc-buf' into for-next

2009-06-13T10:00:54+00:00

Conflicts:
	drivers/ide/ide-tape.c

block: Do away with the notion of hardsect_size

2009-05-22T21:22:54+00:00

Until now we have had a 1:1 mapping between storage device physical
block size and the logical block sized used when addressing the device.
With SATA 4KB drives coming out that will no longer be the case.  The
sector size will be 4KB but the logical block size will remain
512-bytes.  Hence we need to distinguish between the physical block size
and the logical ditto.

This patch renames hardsect_size to logical_block_size.

Signed-off-by: Martin K. Petersen 
Signed-off-by: Jens Axboe

Merge branch 'master' into for-2.6.31

2009-05-22T18:25:34+00:00

Conflicts:
	drivers/block/hd.c
	drivers/block/mg_disk.c

Signed-off-by: Jens Axboe

block: set rq->resid_len to blk_rq_bytes() on issue

2009-05-19T09:36:08+00:00

In commit c3a4d78c580de4edc9ef0f7c59812fb02ceb037f, while introducing
rq->resid_len, the default value of residue count was changed from
full count to zero.  The conversion was done under the assumption that
when a request fails residue count wasn't defined.  However, Boaz and
James pointed out that this wasn't true and the residue count should
be preserved for failed requests too.

This patchset restores the original behavior by setting rq->resid_len
to blk_rq_bytes(rq) on request start and restoring explicit clearing
in affected drivers.  While at it, take advantage of the fact that
rq->resid_len is set to full count where applicable.

* ide-cd: rq->resid_len cleared on pc success

* mptsas: req->resid_len cleared on success

* sas_expander: rsp/req->resid_len cleared on success

* mpt2sas_transport: req->resid_len cleared on success

* ide-cd, ide-tape, mptsas, sas_host_smp, mpt2sas_transport, ub: take
  advantage of initial full count to simplify code

Boaz Harrosh spotted bug in resid_len initialization.  Fixed as
suggested.

Signed-off-by: Tejun Heo 
Acked-by: Borislav Petkov 
Cc: Boaz Harrosh 
Cc: James Bottomley 
Cc: Pete Zaitcev 
Cc: Bartlomiej Zolnierkiewicz 
Cc: Sergei Shtylyov 
Cc: Eric Moore 
Cc: Darrick J. Wong 
Signed-off-by: Jens Axboe

ide: unify interrupt reason checking

2009-05-15T04:44:45+00:00

Add ide_check_ireason() function that handles all ATAPI devices.
Reorganize all unlikely cases in ireason checking further down in the
code path.

In addition, add PFX for printks originating from ide-atapi. Finally,
remove ide_cd_check_ireason.

Signed-off-by: Borislav Petkov