linux.git/drivers/i2c, branch v2.6.33

i2c-tiny-usb: Fix on big-endian systems

2010-02-05T16:48:13+00:00

The functionality bit vector is always returned as a little-endian
32-bit number by the device, so it must be byte-swapped to the host
endianness.

On the other hand, the delay value is handled by the USB stack, so no
byte swapping is needed on our side.

This fixes bug #15105:
http://bugzilla.kernel.org/show_bug.cgi?id=15105

Reported-by: Jens Richter 
Signed-off-by: Jean Delvare 
Tested-by: Jens Richter 
Cc: Till Harbaum 
Cc: stable@kernel.org

i2c: imx: call ioremap only after request_mem_region

2010-01-24T15:25:57+00:00

accordingly adapt order of release_mem_region and release_mem_region on
remove.

Signed-off-by: Uwe Kleine-König 
Cc: Ben Dooks 
Cc: Wolfram Sang 
Cc: Richard Zhao 
Cc: Darius Augulis 
Cc: Sascha Hauer 
Cc: linux-i2c@vger.kernel.org
Acked-by: Wolfram Sang 
Signed-off-by: Ben Dooks

i2c: mxc: let time to generate stop bit

2010-01-24T15:25:56+00:00

After generating the stop bit by changing MSTA from 1 to 0,
the i2c_imx->stopped was immediatly set to 1. The second test
on i2c_imx->stopped then is correct and the controller never
waits if the bus is busy. This patch corrects this.

On mx31moboard, stop bit was not generated on single write transfers.
This was kept unnoticed as other transfers are made afterwards that
help the write recipient to resynchronize.

Thanks to Philippe and Michael for the debugging.

Signed-off-by: Valentin Longchamp 
Signed-off by: Philippe Rétornaz 
Reported-by: Michael Bonani 
Acked-by; Wolfram Sang 
Signed-off-by: Ben Dooks

i2c: Do not use device name after device_unregister

2010-01-16T19:43:13+00:00

dev_dbg outputs dev_name, which is released with device_unregister. This bug
resulted in output like this:

i2c Xy2�0: adapter [SMBus I801 adapter at 1880] unregistered

The right output would be:
i2c i2c-0: adapter [SMBus I801 adapter at 1880] unregistered

Signed-off-by: Thadeu Lima de Souza Cascardo 
Signed-off-by: Jean Delvare

i2c/pca: Don't use *_interruptible

2010-01-16T19:43:13+00:00

Unexpected signals can disturb the bus-handling and lock it up. Don't use
interruptible in 'wait_event_*' and 'wake_*' as in commits
dc1972d02747d2170fb1d78d114801f5ecb27506 (for cpm),
1ab082d7cbd0f34e39a5396cc6340c00bc5d66ef (for mpc),
b7af349b175af45f9d87b3bf3f0a221e1831ed39 (for omap).

Signed-off-by: Wolfram Sang 
Signed-off-by: Jean Delvare

i2c-ali1563: Remove sparse warnings

2010-01-16T19:43:13+00:00

Remove the following sparse warnings (see "make C=1"):
 * drivers/i2c/busses/i2c-ali1563.c:91:3: warning: do-while statement
   is not a compound statement
 * drivers/i2c/busses/i2c-ali1563.c:161:3: warning: do-while statement
   is not a compound statement

Signed-off-by: Márton Németh 
Signed-off-by: Jean Delvare

i2c: Test off by one in {piix4,vt596}_transaction()

2010-01-16T19:43:12+00:00

With `while (timeout++ < MAX_TIMEOUT)' timeout reaches MAX_TIMEOUT + 1
after the loop. This is probably unlikely to produce a problem.

Signed-off-by: Roel Kluin 
Signed-off-by: Jean Delvare

i2c-core: Storage class should be before const qualifier

2010-01-16T19:43:12+00:00

The C99 specification states in section 6.11.5:

The placement of a storage-class specifier other than at the beginning
of the declaration specifiers in a declaration is an obsolescent
feature.

Signed-off-by: Tobias Klauser 
Signed-off-by: Jean Delvare

i2c-omap: OMAP3: Fix I2C lockup during timeout/error cases

2009-12-24T01:30:54+00:00

Current OMAP3 I2C driver code does not follow the correct sequence for soft
reset. Due to this, lock up issues are reported during timeout/error cases.

This patch fixes above issue by disabling I2C controller as per OMAP3430 TRM
for soft reset. As per TRM, I2C controller needs to be disabled as a first
step during soft reset.

Here is correct soft reset sequence:
a. Ensure that the module is disabled
(clear the I2Ci.I2C_CON[15] I2C_EN bit to 0).
b. Set the I2Ci.I2C_SYSC[1] SRST bit to 1.
c. Enable the module by setting I2Ci.I2C_CON[15] I2C_EN bit to 1.
d. Check the I2Ci.I2C_SYSS[0] RDONE bit until it is set to 1 to
indicate the software reset is complete.

Tested on Zoom2, Zoom3, 3430SDP and 3630SDP

Signed-off-by: Manjunatha GK 
Signed-off-by: George, Harith
Acked-by: Varadarajan, Charu Latha
Signed-off-by: Ben Dooks

i2c-omap: Don't write IE state in unidle if 0

2009-12-24T01:26:06+00:00

Commit ef871432... (i2c-omap: OMAP3: PM: (re)init for every transfer
to support off-mode) introduced a change which make the dev->iestate
contents be written to the OMAP_I2C_IE_REG every time omap_i2c_unidle
is called.  Previously, the state was only written if it wasn't equal
to zero.

In omap_i2c_probe, omap_i2c_unidle() is called prior to omap_i2c_init(),
in which case dev->iestate has not yet been initialized and will be set
to zero.  Having this value written to the registers causes deadlock
while booting.

As such, this change restores the original functionality.

Signed-off-by: Cory Maccarrone 
Signed-off-by: Ben Dooks