linux.git/drivers/hwmon/pkgtemp.c, branch v2.6.39

hwmon: (pkgtemp) Use pr_fmt and pr_

2011-01-08T18:55:17+00:00

Added #define pr_fmt KBUILD_MODNAME ": " fmt
Converted printks to pr_
Coalesced any long formats
Removed prefixes from formats

Signed-off-by: Joe Perches 
Signed-off-by: Guenter Roeck

hwmon: ({core, pkg, via-cpu}temp) remove unnecessary CONFIG_HOTPLUG_CPU ifdefs

2010-10-25T21:11:21+00:00

CONFIG_HOTPLUG_CPU is used too much in some drivers.
This patch clean them up.

Signed-off-by: Chen Gong 
Signed-off-by: Guenter Roeck

hwmon: (pkgtemp) align driver initialization style with coretemp

2010-10-25T21:11:20+00:00

pkgtemp is derived from coretemp, so some reasonable
logics should be applied onto pkgtemp, too. Such as
the init logic here.

Signed-off-by: Chen Gong 
Signed-off-by: Guenter Roeck

x86/hwmon: remove inclusion of unnecessary headers from {core, pkg, via-cpu}temp.c

2010-10-25T21:11:20+00:00

These likely originate from these drivers being clones of one another
and/or other drivers which actually needed these includes.

Signed-off-by: Jan Beulich 
Signed-off-by: Guenter Roeck

x86/hwmon: {core, pkg, via}cpu_temp_device_remove() can all be __cpuinit

2010-10-25T21:11:19+00:00

... as they're being called only from a __cpuinit function.

Signed-off-by: Jan Beulich 
Signed-off-by: Guenter Roeck

x86/hwmon: pkgtemp has no dependency on PCI

2010-09-24T18:44:19+00:00

Other than coretemp, from which this code was apparently derived, there
is no PCI specific code in this driver.

Signed-off-by: Jan Beulich 
Cc: Fenghua Yu 
Signed-off-by: Guenter Roeck

x86/hwmon: fix initialization of pkgtemp

2010-09-24T18:44:19+00:00

Feature availability should also be checked in the hotplug code path.

Signed-off-by: Jan Beulich 
Cc: Fenghua Yu 
Signed-off-by: Guenter Roeck

x86/hwmon: don't leak device attribute file from pkgtemp_probe() and pkgtemp_remove()

2010-09-24T18:44:19+00:00

While apparently inherited from coretemp source, this particular error handling
cleanup and exit path wasn't copied properly (or perhaps got discarded
intermediately and not re-added properly later).

Signed-off-by: Jan Beulich 
Cc: Fenghua Yu 
Signed-off-by: Guenter Roeck 
(added device file removal in pkgtemp_remove)

x86/hwmon: avoid deadlock on CPU removal in pkgtemp

2010-09-24T18:44:18+00:00

pkgtemp_device_remove(), holding the list protecting mutex, calls
pkgtemp_device_add(), which itself wants to acquire the same mutex.
Holding the mutex over the entire loop body in pkgtemp_device_remove()
isn't really necessary, as long as the loop gets exited after
processing the matched CPU.

Once exiting the loop after removing an eventual match, there's no
need for using the "safe" list iterator anymore.

Signed-off-by: Jan Beulich 
Cc: Fenghua Yu 
Signed-off-by: Guenter Roeck

x86, hwmon: Package Level Thermal/Power: pkgtemp hwmon driver

2010-08-03T22:58:07+00:00

This patch adds a hwmon driver for package level thermal control. The driver
dumps package level thermal information through sysfs interface so that upper
level application (e.g. lm_sensor) can retrive the information.

Instead of having the package level hwmon code in coretemp, I write a seperate
driver pkgtemp because:

First, package level thermal sensors include not only sensors for each core,
but also sensors for uncore, memory controller or other components in the
package. Logically it will be clear to have a seperate hwmon driver for package
level hwmon to monitor wider range of sensors in a package. Merging package
thermal driver into core thermal driver doesn't make sense and may mislead.

Secondly, merging the two drivers together may cause coding mess. It's easier
to include various package level sensors info if more sensor information is
implemented. Coretemp code needs to consider a lot of legacy machine cases.
Pkgtemp code only considers platform starting from Sandy Bridge.

On a 1Sx4Cx2T Sandy Bridge platform, lm-sensors dumps the pkgtemp and coretemp:

pkgtemp-isa-0000
Adapter: ISA adapter
physical id 0: +33.0°C  (high = +79.0°C, crit = +99.0°C)

coretemp-isa-0000
Adapter: ISA adapter
Core 0:      +32.0°C  (high = +79.0°C, crit = +99.0°C)

coretemp-isa-0001
Adapter: ISA adapter
Core 1:      +32.0°C  (high = +79.0°C, crit = +99.0°C)

coretemp-isa-0002
Adapter: ISA adapter
Core 2:      +32.0°C  (high = +79.0°C, crit = +99.0°C)

coretemp-isa-0003
Adapter: ISA adapter
Core 3:      +32.0°C  (high = +79.0°C, crit = +99.0°C)

[ hpa: folded v3 patch removing improper global variable "SHOW" ]

Signed-off-by: Fenghua Yu 
LKML-Reference: <1280448826-12004-3-git-send-email-fenghua.yu@intel.com>
Reviewed-by: Len Brown 
Signed-off-by: H. Peter Anvin