linux.git/drivers/hid/hid-thrustmaster.c, branch v5.16

HID: check for valid USB device for many HID drivers

2021-12-02T14:36:18+00:00

Many HID drivers assume that the HID device assigned to them is a USB
device as that was the only way HID devices used to be able to be
created in Linux.  However, with the additional ways that HID devices
can be created for many different bus types, that is no longer true, so
properly check that we have a USB device associated with the HID device
before allowing a driver that makes this assumption to claim it.

Cc: Jiri Kosina 
Cc: Benjamin Tissoires 
Cc: Michael Zaidman 
Cc: Stefan Achatz 
Cc: Maxime Coquelin 
Cc: Alexandre Torgue 
Cc: linux-input@vger.kernel.org
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman 
Tested-by: Benjamin Tissoires 
[bentiss: amended for thrustmater.c hunk to apply]
Signed-off-by: Benjamin Tissoires 
Link: https://lore.kernel.org/r/20211201183503.2373082-3-gregkh@linuxfoundation.org

HID: thrustmaster: fix sparse warnings

2021-11-19T14:53:31+00:00

Changed 0 to NULL to fix following sparse warnings:

    drivers/hid/hid-thrustmaster.c:208:43: warning: Using plain integer as NULL pointer
    drivers/hid/hid-thrustmaster.c:241:17: warning: Using plain integer as NULL pointer
    drivers/hid/hid-thrustmaster.c:275:37: warning: Using plain integer as NULL pointer

Signed-off-by: Vihas Mak 
Signed-off-by: Jiri Kosina

HID: thrustmaster: Fix memory leak in thrustmaster_interrupts()

2021-08-20T12:24:57+00:00

thrustmaster_interrupts() does not free memory for send_buf when
usb_interrupt_msg() fails. This is fixed by the given patch.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov 
Signed-off-by: Jiri Kosina

HID: thrustmaster: Fix memory leak in remove

2021-08-20T12:24:57+00:00

thrustmaster_remove() does not release memory for
tm_wheel->change_request. This is fixed by the patch.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov 
Signed-off-by: Jiri Kosina

HID: thrustmaster: Fix memory leaks in probe

2021-08-20T12:24:56+00:00

When thrustmaster_probe() handles errors of usb_submit_urb() it does not
free allocated resources and fails. The patch fixes that.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov 
Signed-off-by: Jiri Kosina

HID: thrustmaster: Switch to kmemdup() when allocate change_request

2021-06-25T12:11:01+00:00

Use kmemdup() helper instead of open-coding to
simplify the code when allocate change_request.

Signed-off-by: Yang Yingliang 
Signed-off-by: Jiri Kosina

HID: thrustmaster: fix return value check in thrustmaster_probe()

2021-05-05T12:26:38+00:00

Fix the return value check which testing the wrong variable
in thrustmaster_probe().

Fixes: c49c33637802 ("HID: support for initialization of some Thrustmaster wheels")
Reported-by: Hulk Robot 
Signed-off-by: Wei Yongjun 
Signed-off-by: Jiri Kosina

HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses

2021-04-07T15:53:13+00:00

Fixes the following W=1 kernel build warning(s):

 drivers/hid/hid-thrustmaster.c:23: warning: Incorrect use of kernel-doc format:  * These interrupts are used to prevent a nasty crash when initializing the
 drivers/hid/hid-thrustmaster.c:26: warning: cannot understand function prototype: 'const u8 setup_0[] = '
 drivers/hid/hid-thrustmaster.c:49: warning: cannot understand function prototype: 'struct tm_wheel_info '
 drivers/hid/hid-thrustmaster.c:62: warning: wrong kernel-doc identifier on line:
 drivers/hid/hid-thrustmaster.c:84: warning: cannot understand function prototype: 'struct __packed tm_wheel_response '
 drivers/hid/hid-thrustmaster.c:143: warning: wrong kernel-doc identifier on line:
 drivers/hid/hid-thrustmaster.c:202: warning: Function parameter or member 'urb' not described in 'thrustmaster_model_handler'
 drivers/hid/hid-thrustmaster.c:202: warning: expecting prototype for Called by the USB subsystem when the wheel responses to our request(). Prototype was for thrustmaster_model_handler() instead
 drivers/hid/hid-thrustmaster.c:265: warning: wrong kernel-doc identifier on line:

Cc: Jiri Kosina 
Cc: Benjamin Tissoires 
Cc: Maxime Coquelin 
Cc: Alexandre Torgue 
Cc: Dario Pagani 
Cc: Kim Kuparinen 
Cc: linux-input@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones 
Signed-off-by: Benjamin Tissoires

HID: fix memdup.cocci warnings

2021-03-30T07:44:31+00:00

drivers/hid/hid-thrustmaster.c:300:27-34: WARNING opportunity for kmemdup

 Use kmemdup rather than duplicating its implementation

Generated by: scripts/coccinelle/api/memdup.cocci

Fixes: c49c33637802 ("HID: support for initialization of some Thrustmaster wheels")
CC: Dario Pagani 
Reported-by: kernel test robot 
Signed-off-by: kernel test robot 
Signed-off-by: Jiri Kosina

HID: support for initialization of some Thrustmaster wheels

2021-03-19T13:21:53+00:00

Add support for proper initialization of some Thrustmaster wheels that
appear like a "Thrustmaster FFB Wheel" (044f:b65d) to the host. When the
device is connected a special usb request is sent, this request makes the
wheel disconnect and reappear to the host as the "real wheel".
For example: a T150 will re-appear as 044f:b677 and a T300 as 044f:b66e

[jkosina@suse.cz: renamed driver to hid-thrustmaster]
Link: https://github.com/scarburato/hid-tminit
Signed-off-by: Dario Pagani 
Co-developed-by: Kim Kuparinen 
Signed-off-by: Kim Kuparinen 
Signed-off-by: Jiri Kosina