linux.git/drivers/hid/hid-multitouch.c, branch v4.18

HID: multitouch: fix calculation of last slot field in multi-touch reports

2018-05-30T06:53:09+00:00

According to [1] and also seemingly agreed by [2], the Scan Time usage
(0x0D 0x56) is a report level usage, not a contact level usage.

However, the hid-multitouch driver currently includes HID_DG_SCANTIME
when calculating `td->last_slot_field', which may lead to
mt_complete_slot() being prematurely called in certain cases (e.g. when
each touch input report includes more than one contact and the Scan Time
usage appears before any contact logical collection).

This patch fixes the issue by skipping mt_store_field() on
HID_DG_SCANTIME, similar to how HID_DG_CONTACTCOUNT and
HID_DG_CONTACTMAX are handled.

[1] https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/windows-precision-touchpad-required-hid-top-level-collections#windows-precision-touchpad-input-reports
[2] https://patchwork.kernel.org/patch/1742181/

Fixes: 29cc309d8bf19 ("HID: hid-multitouch: forward MSC_TIMESTAMP")
Signed-off-by: Ben Chan 
Reviewed-by: Dmitry Torokhov 
Signed-off-by: Jiri Kosina

HID: multitouch: fix types returned from mt_need_to_apply_feature()

2018-05-16T09:02:07+00:00

Some exit paths from mt_need_to_apply_feature() returned int instead
of bool; fix that up.

Reported-by: kbuild test robot 
Signed-off-by: Jiri Kosina

HID: multitouch: implement precision touchpad latency and switches

2018-04-26T12:17:55+00:00

The Win 8.1 precision touchpad spec introduce new modes for touchpads
that can come in handy[1].

Implement the settings of these modes, so we are not taken off-guard if
a firmware decides to enforce them.

[1] https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/windows-precision-touchpad-required-hid-top-level-collections

Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: multitouch: simplify the settings of the various features

2018-04-26T12:17:55+00:00

The Win8 spec also declare other features we want to support:
latency and surface and button switches.

Though it doesn't seem we need to activate those by default, we have been
proved in the past that manufacturers rely on the Windows driver behavior
so we better mimic it to prevent further issues.

The current way of setting the features is cumbersome. It avoids iterating
over the list of features, but the way we store/retrieve the data just
doesn't scale with more than two values.

So iterate over the features when we decide to switch on the device and
make it simpler to extend.

Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: multitouch: make use of HID_QUIRK_INPUT_PER_APP

2018-04-26T12:17:55+00:00

We now have HID_QUIRK_INPUT_PER_APPLICATION that splits the devices
into several devices. This helps us as we can now rely on hid-input
to set the names for us.

Also, this helps removing some magical numbers '0' when calling
.input_configured().

The only thing to take care of is that the field .report in struct
hid_input is now null. We need to iterate over the full list of
reports attached to a hid_input.

This is required for some Advanced Silicon touchscreen to correctly apply
the HID_QUIRK_INPUT_PER_APPLICATION as they have 2 reports associated
with the hidinput node. One contains the Input data, the other one
contains the Output data.

Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

Merge branch 'for-4.17/upstream' into for-linus

2018-04-05T11:28:46+00:00

Pull a few small generic code cleanups.

Merge branch 'for-4.17/multitouch' into for-linus

2018-04-05T11:27:22+00:00

Pull Razer Blade Stealth support improvement and a few generic cleanups

HID: core: reset the quirks before calling probe again

2018-03-23T14:46:09+00:00

Given that now the quirk handling is done in hid-quirk.c, we can actually
reset the quirks before calling .probe(), so that the drivers do not need
to keep track of initial quirks.

Signed-off-by: Benjamin Tissoires 
Acked-by: Peter Hutterer 
Signed-off-by: Jiri Kosina

HID: multitouch: do not set HID_QUIRK_NO_INIT_REPORTS

2018-03-23T14:46:09+00:00

It is set by default now, so there is no point setting it in the driver

Signed-off-by: Benjamin Tissoires 
Acked-by: Peter Hutterer 
Signed-off-by: Jiri Kosina

HID: core: remove the need for HID_QUIRK_NO_EMPTY_INPUT

2018-03-23T14:44:57+00:00

There is no real point of registering an empty input node.
This should be default, but given some drivers need the blank input
node to set it up during input_configured, we need to postpone
the check for hidinput_has_been_populated().

Signed-off-by: Benjamin Tissoires 
Acked-by: Peter Hutterer 
Signed-off-by: Jiri Kosina